•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-2004-3 11 Dec 2025

Do these belong in the spent chamber fill group?

LEAHI-TESTSUITES-LDT-1802-1 12 Dec 2025

Not able to find in your test.py, but these types of texts will change with the translation, and if the text is used as has been defined here, your test will fail in other languages.
Just be aware and think of a solution to be flexible for later when testing with other languages.

LEAHI-DD-FIRMWARE-LDT-2936-1 02 Dec 2025

Fixed.

LEAHI-DD-FIRMWARE-LDT-618-2 04 Dec 2025

Updated

LEAHI-TESTSUITES-LDT-2278-1 11 Dec 2025

When popup is open need to add test to hit measure button adn FW sends rejection and confirm rejection reason is displayed on popup and popup stays open upon rejection

LEAHI-TD-FIRMWARE-LDT-4033-1 22 May 2026

Removed

LEAHI-TESTSUITES-LDT-2174-1 03 Dec 2025

Updated the step with timeout 1000

LEAHI-TESTSUITES-LDT-2174-1 05 Dec 2025

Removed the wait function

LEAHI-DD-FIRMWARE-LDT-618-2 04 Dec 2025

Add blank line before return statement.

LEAHI-TESTSUITES-LDT-1550-1 03 Dec 2025

can we make this a more general method and put in a shared file and update throughout.. update to something like

def setObjectText(obj, text):
    obj["text"] = text
    return obj:
LEAHI-TD-FIRMWARE-LDT-3259-1 27 May 2026

same.

LEAHI-TESTSUITES-LDT-1036-1 03 Dec 2025

can we make this a more general method and put in a shared file and update throughout.. update to something like

def setObjectText(obj, text):
    obj["text"] = text
    return obj:
LEAHI-TESTSUITES-LDT-2174-1 11 Dec 2025

remove commented out lines

LEAHI-TD-FIRMWARE-LDT-1886-1 14 Dec 2025

Done

LEAHI-TD-FIRMWARE-LDT-1886-1 02 Dec 2025

Should be 2 blank lines above/below test banner.

LEAHI-TESTSUITES-LDT-2174-1 02 Dec 2025

Please update report on JIRA everytime there is a change to the test cases

LEAHI-DD-FIRMWARE-LDT-2185-1 11 Dec 2025

Greater than or equal to for low limit
pressureP13 >= MAX_INLET_RO_PUMP_PRESSURE_WARNING_LOW_PSIG

Also give space before and after parentheses.

LEAHI-TESTSUITES-LDT-2174-1 03 Dec 2025

ive noticed this common method being used in other test cases. If its a general method that is used throughout please move outside in a shared file and call from there. Please update other repositories that use this as well.

LEAHI-DD-FIRMWARE-LDT-618-2 04 Dec 2025

Changed this section and rewritten

LEAHI-DD-FIRMWARE-LDT-618-2 04 Dec 2025

Noted.

LEAHI-TD-FIRMWARE-LDT-3259-1 27 May 2026

If the check RAM ECC is disabled in the HALCoGen, this code will not be created.

LEAHI-DD-FIRMWARE-LDT-618-2 04 Dec 2025

Removed

LEAHI-DD-FIRMWARE-LDT-618-2 03 Dec 2025

Remove extra blank line.

LEAHI-TD-FIRMWARE-LDT-473-1 02 Dec 2025

Not sure that we need a get function (or even a flag) for rejection. Recommend removing this function.

LEAHI-TESTSUITES-LDT-2278-1 05 Dec 2025

update to setObjectText to match what is in staging

LEAHI-TESTSUITES-LDT-2278-1 03 Dec 2025

moved to shared file and update to have the object as a parameter

LEAHI-DD-FIRMWARE-LDT-2936-1 03 Dec 2025

add any override function if required

LEAHI-TD-FIRMWARE-LDT-3970-1 26 May 2026

Please break it into two lines

LEAHI-TD-FIRMWARE-LDT-473-1 15 Dec 2025

Sure.

LEAHI-DD-FIRMWARE-LDT-2004-3 08 Dec 2025

Done.

LEAHI-TD-FIRMWARE-LDT-3970-1 26 May 2026

Please break it into two lines

LEAHI-DD-FIRMWARE-LDT-3272-1 27 May 2026

Done

LEAHI-TESTSUITES-LDT-1802-1 03 Dec 2025

remove the outer startSection("Verification of General Alarm Requirements ") as it encapsulates the entire test case not section. Please reupload new report as well

LEAHI-TESTSUITES-LDT-2174-1 10 Dec 2025

Renamed the function setObjectText to match the staging and to avoid conflicts

LEAHI-TESTSUITES-LDT-2278-1 11 Dec 2025

Testing the values with rejection reason and with no rejection reason

LEAHI-TESTSUITES-LDT-2174-1 12 Dec 2025

duplicate line?

LEAHI-DD-FIRMWARE-LDT-3272-1 27 May 2026

Remove extra copyright block.

LEAHI-DD-FIRMWARE-LDT-2185-1 12 Dec 2025

fixed it.

LEAHI-DD-FIRMWARE-LDT-1773-1 12 Dec 2025

fixed. thanks!

LEAHI-DD-FIRMWARE-LDT-2185-1 18 Dec 2025

Can we remove this code?

LEAHI-TD-FIRMWARE-LDT-4013-1 20 May 2026

remove comma

LEAHI-DIALIN-LDT-2998-1 18 Dec 2025

Please move this to level sensor enum. this is not a conductivity sensor; it is a conductive Level sensor.

LEAHI-TD-FIRMWARE-LDT-4072-2 27 May 2026

Remove this comment since we have a comment to right.

LEAHI-TD-FIRMWARE-LDT-473-1 16 Dec 2025

Deleted.

LEAHI-TD-FIRMWARE-LDT-1886-1 16 Dec 2025

The else in this trinary looks wrong - doesn't round up to multiple of 8.

LEAHI-DD-FIRMWARE-LDT-2185-1 17 Dec 2025

Plan is for 4 wire and currently there is no data for both 2 wire and 4 wire . So its TODO list and hence mark it as resolved

LEAHI-DD-FIRMWARE-LDT-2004-3 08 Dec 2025

Mixing static and public function , let public function comes on top

LEAHI-TD-FIRMWARE-LDT-1886-1 18 Dec 2025

We tend to initialize the local variables as a standard practice.

LEAHI-APPLICATION-LDT-2825-1 17 Dec 2025

U32

LEAHI-APPLICATION-LDT-2825-1 17 Dec 2025

call vInstitutionalRecord.doAdjustment() and update advanced to do the same