Comment Search

I would describe function as "reconfigures FPGA driver to use appropriate FPGA register maps".

complicated check should be replaced with boolean flag

fixed.

Need two spaces before the test function

Is there no "first" enum for this group?

Are we supporting multiple models? Is this for Teensy or new sensor or both?

Add a comment to right listing math functions used.

Minor: Need space between parentheses

can we get each group of level check in to a function and call those functions for each case?

arrange this code and new sensor code in a group- line 131 - 142

removed.

Could you update all the overrides to use the generic method? So we don't need to maintain these on more than one place
Broadcast -> cmd_generic_broadcast_interval_override
others -> cmd_generic_override

You can check any of the other modules how to use them

It is there in line 131

It would be nice to have it clubbed it together like

#ifdef _TEENSY_CONDUCTIVITY_DRIVER_
place all code for teensy here

,
#else
// move the all code under #ifndef _TEENSY_CONDUCTIVITY_DRIVER_ here

#endif

Looks like you updated wrong function (the one below instead of this one). It's an output in function below and it's an input in this function.

Actually, for casting, I prefer no spaces around ().

Declare these earlier and just assign them here (i.e. keep declarations together at top of function).

removed.

Does it make more sense to have them together?

align the comment

it stop gap to see if it was valve specific. Its been reverted.

reordered and wrapped in a macro

Can you follow up with whoever commented it out and find out if that was intentional? And, if so, will it be coming back? And, if so, should we at least put a TODO on this to restore later?

Minor: Need space in (BLOOD_LEAK_EMB_MODE_CMD_T)

Updated

Updated