should be utility.aut() if you only want "leahi" utility.aut(""-E")) if you want "leahi -E" only pass in arguemets and remove name parameter in our aut() method
For spent chamber fill, we don't know how low the liquid level is ( in Chamber H) and hence decided not to turn on the trimmer heater for safety reasons. For bicarb fill, the dry bicart code should cover the actuators status. the current bicarb chamber fill code here should be updated with the newly implemented dry bi cart code changes.
Since trimmer heater is enabled, no need of temp compensation. only for testing purposes, temp compensation is needed. Hence by default, temp compensation is disabled.
I guess, Fill and Drain are priority items than the Supply request, which means upon request of fill and drain, state machine should service that operation.
Also, setting supply request should be based on the level sensor later (there shouldn't be any default request -> currently supply is assigned)
we should use the functions defined in testsupport.c/h -> getU32OverrideValue, getF32OverrideValue based on data type. this needs to be fixed throughout the file.
To make it exclusive operation. no previous request should be pending when a new operation is requested. So only one state machine is running at a time. otherwise, while chamber fill is in progress, anyone can request drain and both requests will be handled. even through new code run only one state machine at a time, this will ensure that only one request is submitted to drybicart
This was a concern reported by Sean and proposed for restructuring into a single state machine.
This doesn't look like a valid substate. We should have an enum for valid substates. In default case, we should trigger a s/w fault and also set the state to a valid state (idle or something like that).
Since fill and drain is a single time request and it is not a frequent request similar to supply during dialysate generation. I removed and now run as idle
We agreed to change back the enums into the static variation. Why would that cover a class that has been implemented to mask the enums from direct access, so if they need to be changed to dynamic or renamed or anything, the other repositories that are using them through this class won't be affected or need any update.
I see it as a list, don't know why it is named enum or what the original purpose of it was. It was never updated, so I added the update part at least, so it will at least reflect the current states instead of always stating zeros.
