•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-TD-FIRMWARE-LDT-3970-1 12 May 2026

Please add a comment about this condition check.

Move this part : ( fabs( request.ufRate - validatedUFRateLhr ) < NEARLY_ZERO ) ) to the next line.

LEAHI-TD-FIRMWARE-LDT-4072-2 27 May 2026

Should we publish all registers read?

LEAHI-TD-FIRMWARE-LDT-4033-1 28 May 2026

REmoved

LEAHI-TD-FIRMWARE-LDT-4033-1 27 May 2026

I don't think we need this.

LEAHI-TD-FIRMWARE-LDT-4033-1 27 May 2026

Move to driver.

LEAHI-TD-FIRMWARE-LDT-4033-1 27 May 2026

Move publish call from exec to the check state handle function.

LEAHI-TD-FIRMWARE-LDT-4033-1 28 May 2026

Yes

LEAHI-DD-FIRMWARE-LDT-2004-1 26 Jan 2026

see previous comment.

CLOUDSYNC-DENBUG-337-1 28 May 2026

RESOLVED

RI: It's defined in two places because cs.py and watchdog.py live on opposite sides of a process boundary and don't share a common import. watchdog.py (SENTINEL_PATH) is the producer - it runs inside the cloud_sync.py app process and writes the sentinel file when a thread can't be recovered. cs.py (SENTINEL_FILE) is the consumer - it's the lightweight launcher that spawns cloud_sync.py and polls for that file to restart it. cs.py is deliberately kept minimal and doesn't import the cloudsync package, so the path is duplicated as a local literal rather than shared.

LEAHI-TD-FIRMWARE-LDT-4009-1 29 May 2026

Should check if iso UF volume + UF volume < max. And if user can do multiple iso uf sessions, you would check iso UF volume + any previous iso UF volume + UF volume.
I don't know if there is a minimum iso UF volume.

LEAHI-TD-FIRMWARE-LDT-4013-1 20 May 2026

Add fluid bolus state

LEAHI-TESTSUITES-LDT-3447-1 29 May 2026

File is removed

LEAHI-DD-FIRMWARE-LDT-3958-1 29 May 2026

Done.

LEAHI-DD-FIRMWARE-LDT-4001-1 29 May 2026

This needs TD source update and also dialin update, keep informed system team about this change as this would impact DD demo running.

DG-DENBUG-335-1 31 May 2026

Done

HD-DENBUG-335-1 20 May 2026

This doesn't look right. Check parenthesis.

LEAHI-TD-FIRMWARE-LDT-4072-2 27 May 2026

Not a float anymore. Use u32Override function and no need to cast the pointer.

LEAHI-TD-FIRMWARE-LDT-4033-1 27 May 2026

bpPublishTimerCtr is the output?

LEAHI-DD-FIRMWARE-LDT-3963-1 14 May 2026

makes sense. removed it.

LEAHI-RO-FIRMWARE-LDT-2116-1 22 Nov 2025

Fixed. Thanks

LEAHI-DD-FIRMWARE-LDT-3963-1 14 May 2026

added TODO for all

LEAHI-RO-FIRMWARE-LDT-2116-1 22 Nov 2025

Fixed. Thanks

LEAHI-RO-FIRMWARE-LDT-2116-1 24 Nov 2025

Will fix on Beta branch to avoid changes to Dialin

LEAHI-DD-FIRMWARE-LDT-3963-1 14 May 2026

updated.

LEAHI-DD-FIRMWARE-LDT-3963-1 21 May 2026

Can we make these low priority and 999 rank?

LEAHI-DD-FIRMWARE-LDT-2030-2 26 Nov 2025

fixed. thanks

LEAHI-TD-FIRMWARE-LDT-4033-1 21 May 2026

We need to call this from ModeTreatment transition function.

LEAHI-DD-FIRMWARE-LDT-2030-2 26 Nov 2025

fixed. thank you.

LEAHI-TD-FIRMWARE-LDT-2240-1 19 May 2026

These alarms are in the wrong place. Their enums are 187..199. So they should be at the very end of this table, not here near the beginning.

LEAHI-DD-FIRMWARE-LDT-2030-2 26 Nov 2025

fixed. thank you.

LEAHI-DD-FIRMWARE-LDT-2030-2 26 Nov 2025

fixed. thank you.

LEAHI-DD-FIRMWARE-LDT-2030-2 26 Nov 2025

fixed. thank you.

LEAHI-TD-FIRMWARE-LDT-1886-1 25 Nov 2025

Why are we bypassing driver here?

LEAHI-DD-FIRMWARE-LDT-2004-1 21 Nov 2025

///

LEAHI-DD-FIRMWARE-LDT-2004-1 21 Nov 2025

Add space between } and type name.

LEAHI-DD-FIRMWARE-LDT-2004-1 21 Nov 2025

Seems like eePromDataTX is an output, not an input.

LEAHI-DD-FIRMWARE-LDT-2030-2 25 Nov 2025

If both monitor and driver need visibility to something, consider moving it to the driver's header file since monitor needs to include driver anyway. Driver should not have to know about the monitor stuff as it is higher level.

LEAHI-TESTSUITES-LDT-2174-1 26 Nov 2025

These steps should outline the sections in the report https://diality.atlassian.net/browse/LDT-2176. Please sync them up so they match the flow

LEAHI-DD-FIRMWARE-LDT-2004-1 21 Nov 2025

Fix indent.

LEAHI-TD-FIRMWARE-LDT-4033-1 21 May 2026

same.

LEAHI-TD-FIRMWARE-LDT-3505-1 20 May 2026

I thought this was a TEST_CONFIG thing. We aren't doing s/w config status, so maybe we should convert it to a TEST_CONFIG.

LEAHI-TD-FIRMWARE-LDT-4033-1 20 May 2026

Might have to wait for module to not be busy before getting the data.

LEAHI-TD-FIRMWARE-LDT-4033-1 20 May 2026

SW fault here?

LEAHI-TD-FIRMWARE-LDT-3259-1 27 May 2026

Done

LEAHI-TD-FIRMWARE-LDT-4033-1 21 May 2026

Updated

LEAHI-TD-FIRMWARE-LDT-4033-1 21 May 2026

Why do you have {} in the cases?

LEAHI-TD-FIRMWARE-LDT-4033-1 21 May 2026

Where are these get functions defined? I can't find them.

LEAHI-TD-FIRMWARE-LDT-3259-1 26 May 2026

Yes the ECC checks are done in the bootloader stack.

LEAHI-TD-FIRMWARE-LDT-3259-1 26 May 2026

These are located in the integrity.c

LEAHI-TD-FIRMWARE-LDT-3259-1 27 May 2026

This file was updated automatically using HALCoGen.