•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-3194-1 29 Jan 2026

Change to remove 'Goal' from filename.

LEAHI-DD-FIRMWARE-LDT-3343-1 04 Feb 2026

Updated

LEAHI-TESTSUITES-LDT-2971-1 30 Jan 2026

should this method be moved to navigation.py?

LEAHI-TD-FIRMWARE-LDT-1415-1 26 Jan 2026

Fix indent on this case.

LEAHI-TD-FIRMWARE-LDT-1415-1 26 Jan 2026

Is there still a requirement to re-stabilize every 15 minutes (or some interval) in Leahi? It looks like Denali had such a requirement and it would jump back to STABILIZATION_2 state to do it. Since we don't have a STABILIZATION_2 state, we would need to jump back to STABILIZATION state instead.

LEAHI-DD-FIRMWARE-LDT-2030-2 02 Feb 2026

Remove blank line.

LEAHI-TD-FIRMWARE-LDT-1415-1 29 Jan 2026

Updated

LEAHI-TD-FIRMWARE-LDT-1415-1 29 Jan 2026

Updated

LEAHI-TD-FIRMWARE-LDT-2749-1 29 Jan 2026

MSG_ID_TD_ENABLE_VENOUS_BUBBLE_ALARM

LEAHI-TD-FIRMWARE-LDT-2749-1 29 Jan 2026

Not needed. Remove.

LEAHI-DIALIN-LDT-2749-1 29 Jan 2026

Since this isn't an override, is this still appropriate?

LEAHI-TD-FIRMWARE-LDT-1415-1 28 Jan 2026

This function does not return next state.

LEAHI-TD-FIRMWARE-LDT-2749-1 29 Jan 2026

done.

LEAHI-TD-FIRMWARE-LDT-1415-1 29 Jan 2026

I removed

LEAHI-TESTSUITES-LDT-2971-1 29 Jan 2026

after changing states to TREATMENT_DIALYSIS_STATE can you add the following line after

waitForObject(names.o_listView_Item)

LEAHI-APPLICATION-LDT-3194-1 03 Feb 2026

Updated to align naming with regular ultrafiltration.

LEAHI-APPLICATION-LDT-3194-1 03 Feb 2026

Updated.

LEAHI-DD-FIRMWARE-LDT-2004-3 30 Jan 2026

It looks to me like the state machine (drain for example) will keep running so long as the flag is true. I would think it should set the flag to false when drain is done.

LEAHI-DD-FIRMWARE-LDT-2004-3 30 Jan 2026

Fixed.

LEAHI-DD-FIRMWARE-LDT-2004-3 30 Jan 2026

Why is drain request flag different (ends in "ed")?

LEAHI-DD-FIRMWARE-LDT-2004-3 30 Jan 2026

Where do these request flags get set back to FALSE after request is serviced?

LEAHI-DIALIN-LDT-2004-1 03 Feb 2026

Based on the msg id, it should be here

LEAHI-DIALIN-LDT-3350-1 02 Feb 2026

Same here.

LEAHI-DIALIN-LDT-3350-1 02 Feb 2026

same here

LEAHI-APPLICATION-LDT-3194-1 29 Jan 2026

Delete file and remove from .pro.

LEAHI-TESTSUITES-LDT-2971-1 30 Jan 2026

remove commented out line

LEAHI-APPLICATION-LDT-3307-1 03 Feb 2026

mvoe to TD file and remove file

LEAHI-DD-FIRMWARE-LDT-1473-1 02 Feb 2026

Mis-spelled "Stabilized".

LEAHI-DD-FIRMWARE-LDT-3103-1 02 Feb 2026

Add a blank line before return statement.

LEAHI-TD-FIRMWARE-LDT-1415-1 28 Jan 2026

Fix spelling in comment (membrane should not have a 'c' in it).

LEAHI-TESTSUITES-LDT-1630-1 29 Jan 2026

Removed the line

LEAHI-APPLICATION-LDT-3194-1 29 Jan 2026

remove this one

LEAHI-DIALIN-LDT-2749-1 29 Jan 2026

done

LEAHI-DIALIN-LDT-2749-1 29 Jan 2026

I see the same implementations for set functions as well. So, I thought it is required and necessary.

LEAHI-TD-FIRMWARE-LDT-2749-1 29 Jan 2026

testEnableVenousBubbleAlarm?

LEAHI-DIALIN-LDT-2749-1 29 Jan 2026

Should be ENABLE in this name somewhere.

LEAHI-DIALIN-LDT-2749-1 29 Jan 2026

Function needs function header comments (see other functions for example).

LEAHI-TD-FIRMWARE-LDT-1415-1 29 Jan 2026

Align | separators all the way to right end of these 2 rows.

LEAHI-TD-FIRMWARE-LDT-2749-1 29 Jan 2026

done.

LEAHI-TESTSUITES-LDT-2971-1 29 Jan 2026

after changing states to TREATMENT_DIALYSIS_STATE can you add the following line after

waitForObject(names.o_listView_Item)

LEAHI-DD-FIRMWARE-LDT-2004-4 03 Feb 2026

Do FP sensors have to be treated separately? I realize there needs to be separate messages as they will be coming from different Dialin classes, but can't we handle both messages with same function (assuming shared enum to index)?

LEAHI-TESTSUITES-LDT-2971-1 30 Jan 2026

Why do you need try-catch?

LEAHI-APPLICATION-LDT-3194-1 03 Feb 2026

Updated.

LEAHI-APPLICATION-LDT-3194-1 03 Feb 2026

Updated.

LEAHI-APPLICATION-LDT-3194-1 03 Feb 2026

Updated.

LEAHI-DD-FIRMWARE-LDT-1473-1 02 Feb 2026

I would think this would be enabled by default.

LEAHI-DD-FIRMWARE-LDT-2004-3 03 Feb 2026

I would prefer to fix this in balancing chamber new algorithm implementation. That is why i didn't mark it as Unresolved.

LEAHI-DIALIN-LDT-2004-1 03 Feb 2026

Please pull the latest staging and update the test configs regarding that.
I think the dry bicart test config is already there

LEAHI-DIALIN-LDT-3350-1 02 Feb 2026

what are these?
and do we need them?

LEAHI-TESTSUITES-LDT-2741-1 28 Jan 2026

removed AUT_NAME and AUT_NAME_ONLY