•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-TD-FIRMWARE-LDT-1415-1 26 Jan 2026

When comment is too far to right to align with other comments, use the following comment format:
<blank line>
/// comment...
#define ...
<blank line>

LEAHI-TD-FIRMWARE-LDT-1415-1 29 Jan 2026

Updated

LEAHI-APPLICATION-LDT-3194-1 30 Jan 2026

Updated.

LEAHI-DD-FIRMWARE-LDT-2004-3 02 Feb 2026

Why is this flag set to FALSE here in start state while the other request flags are set to FALSE in their completed states?

LEAHI-APPLICATION-LDT-3194-1 03 Feb 2026

User waited too long would follow the same rejected behavior, do we still need to show the specific rejection path for the user waiting too long?

LEAHI-DIALIN-LDT-3350-1 03 Feb 2026

Obviously not.
You were reminding me about backwards compatibility. This variable and class ensures that even with this major refactor to the enum structure, the current codebase remains working.

LEAHI-DIALIN-LDT-3350-1 03 Feb 2026

Look in the td_defs.py for the same comment.

LEAHI-APPLICATION-LDT-3194-1 29 Jan 2026

Change HD to TD if moved to td directory.

LEAHI-APPLICATION-LDT-3194-1 27 Jan 2026

Fix MSG description

LEAHI-DD-FIRMWARE-LDT-2004-4 03 Feb 2026

I think Dialin will need get (or UI proxy) commands to have us send cal, s/n, and versions.

LEAHI-TESTSUITES-LDT-2971-1 30 Jan 2026

Same (translation)

LEAHI-DIALIN-LDT-3350-1 02 Feb 2026

Not sure about this change. This script is used during the automated builds. Do you use this script anywhere else?

LEAHI-DD-FIRMWARE-LDT-2030-2 02 Feb 2026

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-3160-1 27 Jan 2026

SPENT_CHAMBER_H_FILL

LEAHI-TD-FIRMWARE-LDT-1415-1 28 Jan 2026

Added

LEAHI-TD-FIRMWARE-LDT-1415-1 28 Jan 2026

Once I get latest staging I will update this

LEAHI-TD-FIRMWARE-LDT-1415-1 29 Jan 2026

Sorry, updated

LEAHI-TESTSUITES-LDT-2971-1 29 Jan 2026

Added the line

LEAHI-DD-FIRMWARE-LDT-2004-3 22 Jan 2026

state is not an input. It is a local (internal to function) variable.

LEAHI-TD-FIRMWARE-LDT-1415-1 02 Feb 2026

Shouldn't we be getting these defaults from the TxParams unit?

LEAHI-TESTSUITES-LDT-2971-1 02 Feb 2026

All strings are placed in config.py

LEAHI-DIALIN-LDT-3350-1 02 Feb 2026

same

LEAHI-APPLICATION-LDT-3194-1 29 Jan 2026

Rename to add *Stack.qml. Update Duration as well.

LEAHI-DIALIN-LDT-3350-1 02 Feb 2026

Are these part of FPTemperatureSensorName class?

LEAHI-DD-FIRMWARE-LDT-1473-1 02 Feb 2026

I think you can do this in 1 line of code using the RANGE macro in Common.h.

LEAHI-DD-FIRMWARE-LDT-2004-3 03 Feb 2026

Remove extra blank line.

LEAHI-DIALIN-LDT-3160-1 27 Jan 2026

ENABLE_DRY_BICART_FILL vs ENABLE_LIQUID_BICARB => we can use only one of these. We can keep test config 2 ( may rename as ENABLE_DRY_BICARB) and 8 can be deleted.

LEAHI-TD-FIRMWARE-LDT-2749-1 02 Feb 2026

input and output is not updated properly

LEAHI-DD-FIRMWARE-LDT-2004-4 03 Feb 2026

Add a blank line after public defs banner.
Add a dox comment to the right.
I believe they reserve space for 12 bytes, not 10.
Not really for calibration - it's for s/n and versions.

LEAHI-TD-FIRMWARE-LDT-1415-1 28 Jan 2026

Updated

LEAHI-DD-FIRMWARE-LDT-2004-4 03 Feb 2026

Structures need a top level dox comment.

LEAHI-TD-FIRMWARE-LDT-1415-1 28 Jan 2026

Yes, deleted

LEAHI-TD-FIRMWARE-LDT-1415-1 26 Jan 2026

Why are we making this change? It doesn't look correct to have a LongCount capped with a ShortCount and SIZE.

LEAHI-DD-FIRMWARE-LDT-2004-4 03 Feb 2026

Are these really going to be different types? I assumed they would all be floats.

LEAHI-TESTSUITES-LDT-2971-1 29 Jan 2026

Modified the step to get all elements in the list dynamically and performing the action based on user input

LEAHI-DD-FIRMWARE-LDT-2004-3 02 Feb 2026

fixed it

LEAHI-TD-FIRMWARE-LDT-2749-1 29 Jan 2026

done.

LEAHI-TD-FIRMWARE-LDT-2749-1 29 Jan 2026

done.

LEAHI-DIALIN-LDT-2749-1 29 Jan 2026

done

LEAHI-TD-FIRMWARE-LDT-2749-1 29 Jan 2026

Update function name to match actual name. Remove references to standby mode - function should work in any mode.

LEAHI-DD-FIRMWARE-LDT-2004-3 02 Feb 2026

fixed it

LEAHI-TD-FIRMWARE-LDT-2749-1 29 Jan 2026

Check msg payload length, set result to TRUE and set enable only if length is correct.

LEAHI-TD-FIRMWARE-LDT-2749-1 29 Jan 2026

I would make another local variable (BOOL) above and set it per trinary operation and then pass the BOOL to the function.
I think we want to avoid complex logic or function calls as a function parameter per our coding standards.

LEAHI-TD-FIRMWARE-LDT-1415-1 28 Jan 2026

Missing param.

LEAHI-DD-FIRMWARE-LDT-3222-1 03 Feb 2026

I don't think valve needs to be initialized here. The for loop initializes it.

LEAHI-TESTSUITES-LDT-2971-1 29 Jan 2026

Added the line

LEAHI-APPLICATION-LDT-3194-1 30 Jan 2026

Updated.

LEAHI-APPLICATION-LDT-3194-1 03 Feb 2026

Updated.

LEAHI-APPLICATION-LDT-3323-1 03 Feb 2026

Updated.

LEAHI-DD-FIRMWARE-LDT-2004-4 03 Feb 2026

Do we not need this anymore? I still see it in code all over the place and I don't think we're done w/ Teensy until Beta 1.9 units are obsolete.