BN approves
same.
BN appproves
BatteryDriver
updated
Why is this commented out? Do we not need to initialize it?
bpMeasurementReady is an output?
Added
Make the 6 a #define
Updated
leak in the comment section.
Add a 5th enum for NUM_OF_BP_DRIVER_STATES. And, does this need to be public?
Looks like you removed error state, so we should remove it here too.
I think we may need to give a get data command here.
Same. Set a request flag to TRUE (for Peds this time) and let the state machine do the rest.
For init function, just say "BPDriver variables initialized."
Initialize bpResults and new flags.
same comment as above
Should be #ifndef
restored
Just like driver state machine, we should only set a request flag to TRUE here and let the state machine handle the transition.
Remove blank line.
How do we get out of Idle state?
This should be called in all states (so in controller's exec function).
Is this all we need to look at to know that measurement is done? Do we need to look at busy status?
Fixed
please align the comments
all these changes should be in tst_create_treatment test case. We need to update the existing one with the new design not just create a nmew t estcase
Comment this out before merge.
please add @param
Use #define for array size.
Add fluid bolus state
removed
Please sync this payload in DD firmware, Leahi-dialin and System Scripts.
We only add File level or global variables in Inputs and Outputs. Please remove functions from the input section of this and other functions.
fixed
Where is alarm 191..203?
Remove this blank line.
According to the HDD, it is a '1' when inactive and becomes a '0' when active. It becomes active when it reaches the position.
Move these 3 override messages (should end in OVERRIDE_REQUEST) to TD Dialin section below and assign an ID in the 0x8... range.
Should this be an enum at driver level? Driver get would return enum so controller doesn't have to figure out what it means.
If no parameters, just don't have any param lines (don't say none).
Use a #define instead of 1000.
Do we need to call initBloodLeakDriver() here?
Remove extra space before void. Align comments.
We can abbreviate things in function and variable names, but in descriptive text we should write things out in complete words as this text goes into SDD document.
Fix indent.
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
