•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-2004-1 21 Nov 2025

No overrides?

LEAHI-DD-FIRMWARE-LDT-2004-1 21 Nov 2025

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-3958-1 17 May 2026

These P being so much bigger than I are going to be very volatile (lots of big ups and downs). I think these should all be primarily I with much smaller P coefficients.

LEAHI-TD-FIRMWARE-LDT-4033-1 18 May 2026

Yes Noe said to replace with new register

LEAHI-APPLICATION-LDT-4193-1 18 May 2026

added

LEAHI-APPLICATION-LDT-4193-1 18 May 2026

added

LEAHI-TD-FIRMWARE-LDT-4072-2 15 May 2026

Should be BatteryDriver?

LEAHI-TD-FIRMWARE-LDT-4033-1 21 May 2026

For init function, just say "BPModule variables initialized."

LEAHI-TD-FIRMWARE-LDT-4033-1 17 May 2026

What is in registers 378..383? We need to add those registers or incoming data won't overlay properly into structure.

LEAHI-TD-FIRMWARE-LDT-4033-1 20 May 2026

added

LEAHI-TD-FIRMWARE-LDT-4033-1 20 May 2026

Used in handle function

LEAHI-DD-FIRMWARE-LDT-4011-2 08 Jun 2026

comment starts with capital letter?

LEAHI-TD-FIRMWARE-LDT-4033-1 20 May 2026

Should we also check whether bpMeasurementReady is TRUE?

LEAHI-TD-FIRMWARE-LDT-3259-1 27 May 2026

Comment this out before merge.

LEAHI-TD-FIRMWARE-LDT-4033-1 22 May 2026

Make h10DACControl a U08.

LEAHI-TD-FIRMWARE-LDT-4033-1 22 May 2026

Remove extra blank line.

LEAHI-TD-FIRMWARE-LDT-4033-1 22 May 2026

Add alarm here.

LEAHI-DD-FIRMWARE-LDT-3272-1 27 May 2026

This is auto generated code. How do we keep this code from re-appearing when somebody regenerates this code?

LEAHI-TD-FIRMWARE-LDT-3259-1 27 May 2026

If the check RAM ECC is disabled in the HALCoGen, this code will not be created.

LEAHI-TD-FIRMWARE-LDT-3970-1 12 May 2026

Even if you do not have an Output, please add the tag with None as the value.
Please fix in other functions as well.

LEAHI-TD-FIRMWARE-LDT-3970-1 26 May 2026

Please break it into two lines
Should the name of the message id be MSG_ID_TD_TREATMENT_UF_VOLUME_VALIDATE_RESPONSE?

LEAHI-TD-FIRMWARE-LDT-4013-1 20 May 2026

maybe use target rate for both.

LEAHI-TD-FIRMWARE-LDT-4033-1 27 May 2026

pendingVitalsRequest is the output?

LEAHI-TD-FIRMWARE-LDT-4013-1 20 May 2026

signal functions should return BOOL.

LEAHI-DD-FIRMWARE-LDT-3958-1 29 May 2026

Done.

LEAHI-DD-FIRMWARE-LDT-3958-1 17 May 2026

Should we just set this flag to FALSE at top of loop?

HD-DENBUG-335-1 31 May 2026

Done

HD-DENBUG-335-1 01 Jun 2026

Dara, work with Nick to get the right text for this new alarm.

LEAHI-TESTSUITES-LDT-3321-1 26 May 2026

please move under tst_headerbar_information_popup

DG-DENBUG-335-1 29 May 2026

Update comment as FPGA.

LEAHI-DD-FIRMWARE-LDT-3958-1 01 Jun 2026

Done.

LEAHI-TD-FIRMWARE-LDT-2240-1 03 Jun 2026

Add blank line before return statement.

LEAHI-TD-FIRMWARE-LDT-4072-2 20 May 2026

Initialize .override to OVERRIDE_RESET

LEAHI-DD-FIRMWARE-LDT-4001-1 09 Jun 2026

fixed. thanks!

LEAHI-DD-FIRMWARE-LDT-4409-2 09 Jun 2026

remove blank lines

LEAHI-RO-FIRMWARE-LDT-2116-1 22 Nov 2025

Fixed. Thanks

LEAHI-DD-FIRMWARE-LDT-2030-2 26 Nov 2025

fixed. thank you.

LEAHI-DD-FIRMWARE-LDT-2004-1 21 Nov 2025

///

LEAHI-DD-FIRMWARE-LDT-2004-3 21 Nov 2025

Align comments.

LEAHI-DD-FIRMWARE-LDT-2004-1 21 Nov 2025

Add comment to right.

LEAHI-DD-FIRMWARE-LDT-3963-1 14 May 2026

updated as suggested.

LEAHI-TD-FIRMWARE-LDT-3970-1 26 May 2026

Please break it into two lines and check other functions too.

LEAHI-TD-FIRMWARE-LDT-4033-1 20 May 2026

Don't change state from outside signal. We should just set a requestBPMeasurement flag to TRUE in this function (if current state is IDLE) and then when the state machine runs next, the IDLE state should look for this flag to be TRUE and transition to MEASURE state (by doing all of these things you have here in this function).

LEAHI-TD-FIRMWARE-LDT-2240-1 20 Apr 2026

Both of these should be alarms. No need to respond to UI's response. Remove.

LEAHI-APPLICATION-LDT-4193-1 18 May 2026

updated

LEAHI-APPLICATION-LDT-4193-1 18 May 2026

added

LEAHI-APPLICATION-LDT-4193-1 18 May 2026

moved changing logic to main.qml

LEAHI-APPLICATION-LDT-4193-1 19 May 2026

BN approves

LEAHI-TD-FIRMWARE-LDT-4072-2 15 May 2026

should be below and use "" instead of <>

LEAHI-TD-FIRMWARE-LDT-4033-1 21 May 2026

You are getting bpResults, but not doing anything with them. Should you pass as parameter to checkBloodPressureReading() function?