Added alarm
Removed
Do we not need the module error alarm?
I don't think iso uf is considered a modality - at least not in phase 1 of development.
Add a banner before Dialin test support functions (see other units for example).
These 2 new channels should be using message boxes before Dialin channel message boxes. Align with buffers enum.
What is the difference between the bicarbonateConcentrate and bicarbonate. Please update the comment.
please add a comment
requestAbortBPReading is the output?
Not needed.
moved this function to tst_headerbar_information_popup as per comment
update the comment as required: ml or L?
RESOLVED in CODE WALKTHROUGH
looks Bicarb and sodium settings interchanged? There are multiple macros on the same values. remove the duplicates.
Missing comment.
return result;
Align comment.
Not a float.
this payload has been updated by fw. Please update the payload as it is now failing
I don't see it.
Retain the previous( dryBicartFillRequested) and add 'bicarbChamberPregenFillRequested' flag here.
Updated
Then your doxygen return comment looks backward.
added TODO above
There is a #define for BAL_CHAMBER_FILL_VOLUME_ML in BalancingChamber.h. Why can't we just use that instead of redefining it here?
Why bypassing driver here?
Use U32 unless there is a good reason to use U08.
///
need structure packing
copy right missing
Why does this case manage so many more valves than other cases?
Please restore before you merge to staging.
Add a doxygen comment above structure for the whole structure (see structure above for example).
please add bpLeftHomeTimerCounter to inputs and outputs.
align comment
Add a blank line after banner.
bn approves
BN approves
Update all function headers to Leahi format (e.g. input and output have a \b to make them bold).
uncomment.
references to Denali has been removed
The driver has one of these too. Does the controller need to store the results when it can ask the driver for them?
s/w fault needs alarm data. See other examples.
Yes. Otherwise, we will have to hard code the calibration record for the time being.
In Leahi, we want to do all initialization in the init function instead of here at declaration (see Bubble.c for example).
Added back
Done
Please break it into two lines
Alphabetize.
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
