•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-3194-1 29 Jan 2026

Inherit from MAbstract for all Ms in td directory.

LEAHI-APPLICATION-LDT-3194-1 29 Jan 2026

Add separator.

LEAHI-APPLICATION-LDT-3194-1 27 Jan 2026

Remove comment

LEAHI-APPLICATION-LDT-3194-1 27 Jan 2026

Add user waited too long.

LEAHI-DIALIN-LDT-3350-1 02 Feb 2026

Is this the only import that is needed?

LEAHI-DD-FIRMWARE-LDT-2030-2 02 Feb 2026

Remove blank line.

LEAHI-APPLICATION-LDT-3323-1 03 Feb 2026

Add comment for why using * 2 (look & feel)

LEAHI-TESTSUITES-LDT-2741-1 30 Jan 2026

move this to navigation.py?

LEAHI-APPLICATION-LDT-3307-1 03 Feb 2026

ask caryn if we can remove text value

LEAHI-APPLICATION-LDT-3307-1 03 Feb 2026

move model to outside when instantiated

LEAHI-APPLICATION-LDT-3307-1 03 Feb 2026

add comment why updating the double click to adding the threashold

LEAHI-TD-FIRMWARE-LDT-2749-1 02 Feb 2026

input parameter not updated

LEAHI-DD-FIRMWARE-LDT-3103-1 02 Feb 2026

Why is this commented out?

LEAHI-DIALIN-LDT-3160-1 28 Jan 2026

This was made for the UI team, but it slowing down the init process and always throwing that error, that is not an error and not affecting the SW VV and SYS teams. So removing them to fasten the init process and to not have confusing messages

LEAHI-TD-FIRMWARE-LDT-1415-1 28 Jan 2026

Fixed

LEAHI-TD-FIRMWARE-LDT-2749-1 29 Jan 2026

removed

LEAHI-TD-FIRMWARE-LDT-1415-1 29 Jan 2026

Sorry, Updated

LEAHI-TD-FIRMWARE-LDT-2749-1 29 Jan 2026

MSG_ID_TD_ENABLE_VENOUS_BUBBLE_ALARM?

LEAHI-TD-FIRMWARE-LDT-1415-1 29 Jan 2026

Yes we need to add

LEAHI-TD-FIRMWARE-LDT-2749-1 29 Jan 2026

Please keep local declarations together up top.

LEAHI-APPLICATION-LDT-3194-1 03 Feb 2026

Updated.

LEAHI-DIALIN-LDT-3350-1 03 Feb 2026

DialinEnum from_str function using it to match a strung to an enum member. Converting the string to enum for cleaner code in test cases.

LEAHI-DD-FIRMWARE-LDT-2004-3 03 Feb 2026

It is replied by Vinay , there is no need to maintain two different rpm. so we can close this.

LEAHI-DIALIN-LDT-3350-1 03 Feb 2026

Look in the td_defs.py for the same comment.

LEAHI-APPLICATION-LDT-3194-1 29 Jan 2026

Remove debug output.

LEAHI-TESTSUITES-LDT-2971-1 30 Jan 2026

please move these into the config.py to be consistent with other test cases

LEAHI-TESTSUITES-LDT-2971-1 30 Jan 2026

The translatable strings shall be defined in a global space.
Generally, please make sure this is handled everywhere.

LEAHI-DD-FIRMWARE-LDT-2030-2 02 Feb 2026

Remove blank line.

LEAHI-TD-FIRMWARE-LDT-2749-1 02 Feb 2026

structure packing required

LEAHI-DD-FIRMWARE-LDT-2004-4 03 Feb 2026

enums need a top level dox comment.

LEAHI-TD-FIRMWARE-LDT-2749-1 29 Jan 2026

Not an override command. We want to update bubbleDetectionEnabled[] for the venous sensor (index 0) to the given T/F state.

LEAHI-TESTSUITES-LDT-2971-1 02 Feb 2026

All strings are placed in config.py

LEAHI-APPLICATION-LDT-3194-1 03 Feb 2026

Updated.

LEAHI-APPLICATION-LDT-3194-1 03 Feb 2026

Updated.

LEAHI-DIALIN-LDT-3350-1 03 Feb 2026

When building locally without all the parameters the generated name throws an error during python pip install.
So this ensures that if no parameter is added, it uses the default name which is compatible with pip install.
The " -+. " sequence is throwing an error.

LEAHI-APPLICATION-LDT-3194-1 29 Jan 2026

Set Def to Min.

LEAHI-TESTSUITES-LDT-2741-1 29 Jan 2026

the aut will always be "leahi" so leave that as a constant in the method and only pass in arguements

LEAHI-TD-FIRMWARE-LDT-1415-1 28 Jan 2026

You added them, but you're not really using them and you're not using the tmp override either as far as I can see. Do we need any of these?

LEAHI-TESTSUITES-LDT-2741-1 19 Jan 2026

it looks like we keep adding a new variable for a specific arguement.

Lets make it more modular and create a function to pass in any arguement

Something like

def aut(name, *args):
    return " ".join((name, *args))"



and use it like

 aut("leahi", "-k", "-K", "-S", "-q")" 
LEAHI-TESTSUITES-LDT-1630-1 29 Jan 2026

remove line as treatment parameters has been removed

LEAHI-TD-FIRMWARE-LDT-1415-1 29 Jan 2026

No, by mistake I copy pasted the same

LEAHI-TD-FIRMWARE-LDT-1415-1 28 Jan 2026

Align function name with others (1 more space before name).

LEAHI-TD-FIRMWARE-LDT-2749-1 29 Jan 2026

removed.

LEAHI-DIALIN-LDT-3350-1 03 Feb 2026

removed commented out line

LEAHI-APPLICATION-LDT-3194-1 29 Jan 2026

Change to remove 'Goal' from filename.

LEAHI-DD-FIRMWARE-LDT-3343-1 04 Feb 2026

Updated

LEAHI-TESTSUITES-LDT-2971-1 30 Jan 2026

should this method be moved to navigation.py?

LEAHI-TD-FIRMWARE-LDT-1415-1 26 Jan 2026

Fix indent on this case.

LEAHI-TD-FIRMWARE-LDT-1415-1 26 Jan 2026

Is there still a requirement to re-stabilize every 15 minutes (or some interval) in Leahi? It looks like Denali had such a requirement and it would jump back to STABILIZATION_2 state to do it. Since we don't have a STABILIZATION_2 state, we would need to jump back to STABILIZATION state instead.

LEAHI-DD-FIRMWARE-LDT-2030-2 02 Feb 2026

Remove blank line.