•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-TD-FIRMWARE-LDT-3259-1 26 May 2026

Yes. The integrity module is in leahi-fwcommon repository, and it serves both TD and DD.

LEAHI-TD-FIRMWARE-LDT-3970-1 12 May 2026

Please add a comment for this check and break the line in two lines.

LEAHI-TD-FIRMWARE-LDT-3259-1 27 May 2026

Done

LEAHI-DD-FIRMWARE-LDT-3272-1 27 May 2026

Same.

LEAHI-TD-FIRMWARE-LDT-3970-1 26 May 2026

Looks like comment for 208 and 223 are swapped?

LEAHI-TD-FIRMWARE-LDT-3259-1 27 May 2026

This is auto generated code. How do we keep this code from re-appearing when somebody regenerates this code?

LEAHI-TD-FIRMWARE-LDT-4033-1 27 May 2026

Input is none.
Add @Alarms

CLOUDSYNC-DENBUG-337-1 28 May 2026

RESOLVED

RI: The sentinel sub-folder (/media/sd-card/cloudsync/sentinel/) is created by the Watchdog._init_() constructor in cloudsync/utils/watchdog.py - it runs os.makedirs(sentinel_dir, exist_ok=True) at construction time, so the folder exists before any sentinel file gets written.

LEAHI-TD-FIRMWARE-LDT-4013-1 20 May 2026

Keep 2 blank lines before banner

LEAHI-DD-FIRMWARE-LDT-3958-1 29 May 2026

Done.

LEAHI-TD-FIRMWARE-LDT-4009-1 29 May 2026

else reason is Invalid Request Format

LEAHI-DD-FIRMWARE-LDT-4001-1 29 May 2026

Substitution pump

LEAHI-TD-FIRMWARE-LDT-4033-1 27 May 2026

command is a param?

LEAHI-RO-FIRMWARE-LDT-2116-1 22 Nov 2025

Fixed. Thanks

LEAHI-RO-FIRMWARE-LDT-2116-1 22 Nov 2025

Fixed. Thanks

LEAHI-RO-FIRMWARE-LDT-2116-1 24 Nov 2025

Resolved Thanks

LEAHI-DD-FIRMWARE-LDT-2004-1 01 Dec 2025

For default cases (throughout this unit), we either need a s/w fault (because this should never happen and indicates memory corruption) or a comment noting it is ok to ignore invalid cases (commands in this case).

LEAHI-TD-FIRMWARE-LDT-4033-1 17 May 2026

create a local BOOL result and use a ternary to assign FALSE or TRUE explicitly.

LEAHI-TD-FIRMWARE-LDT-3970-1 12 May 2026

Please list names of variables in inputs and outputs.
You can move any description in the brief section.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

Update inputs/outputs to include RR broadcast related variables.

LEAHI-DD-FIRMWARE-LDT-2936-1 26 Nov 2025

I do not see structure packing. is it not required ?

LEAHI-TD-FIRMWARE-LDT-4072-2 15 May 2026

Remove blank line.

LEAHI-TD-FIRMWARE-LDT-473-1 02 Dec 2025

Remove extra blank line.

LEAHI-TESTSUITES-LDT-2174-1 27 Nov 2025

Added the sections in the report

LEAHI-TESTSUITES-LDT-2174-1 27 Nov 2025

Added test.endsection in the report

LEAHI-TESTSUITES-LDT-2174-1 27 Nov 2025

Removed the Visible property in the objects

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

Fixed

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

Updated, missed to increment.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

Fixed.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

Updated. Now using 0x71

LEAHI-RO-FIRMWARE-LDT-2116-1 01 Dec 2025

Structure packing statement missing. add it even if not required

LEAHI-TD-FIRMWARE-LDT-1886-1 01 Dec 2025

Done

LEAHI-TD-FIRMWARE-LDT-1886-1 01 Dec 2025

Should we initialize to inactive (and use #define)?

LEAHI-RO-FIRMWARE-LDT-2116-1 01 Dec 2025

Once Dara enable the copyright script, that will handle it

LEAHI-DD-FIRMWARE-LDT-2936-1 26 Nov 2025

not initialized in init function

LEAHI-DD-FIRMWARE-LDT-2936-1 26 Nov 2025

Not initialized ? who modifies this variable ?

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

Input is roRejectionRatio.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

roRRAvg is an input.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

Input is roRejectionRatioTankFill.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

Declare local variables at top of scope (top of function in this case).

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

isFlushComplete looks like an output.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

roRRTankFillAvg is an input.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

concentateFlushTankFullTimer looks like an input.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

isFlushComplete in an output. pendingStartConcentrateFlushRequest appears to be an input and an output.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

Update inputs/outputs.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

Update inputs/outputs (throughout this unit).

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

These divisions should have a divide by zero check.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

roPumpState is not an array. stopPumpRequest isn't referenced in this function. targetROPumpFlowRate is an input and an output and there are others.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

Remove extra blank line.