•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-2004-3 06 Feb 2026

I prefer to be explicit on BOOL conditions like this (e.g. TRUE == isFreshDialysatePressureInRange).

LEAHI-DD-FIRMWARE-LDT-3222-1 06 Feb 2026

I don't think so. The state is bit encoded, so special handling is required.

LEAHI-DD-FIRMWARE-LDT-3222-1 06 Feb 2026

This one looks like maybe we could use the helper function. Have Vinay look at it.

LEAHI-DD-FIRMWARE-LDT-3222-1 06 Feb 2026

The type of payload expected by the function u32ArrayOverride is TEST_OVERRIDE_ARRAY_PAYLOAD_T whereas the type of payload received by the function testBCValveStatesOverride is DD_BC_VALVE_OVERRIDE_PAYLOAD_T. Because of the mismatch is payload type, we cannot use the function u32ArrayOverride in this case.

LEAHI-DIALIN-LDT-2994-3 06 Feb 2026

Can you review this with Michael G and find out if this is even needed? Can we remove? If not, what is it doing and why?

LEAHI-DD-FIRMWARE-LDT-1473-1 06 Feb 2026

So shouldn't we stop trimmer heater here then?

LEAHI-DD-FIRMWARE-LDT-2004-3 06 Feb 2026

Fixed it

LEAHI-DD-FIRMWARE-LDT-3222-1 06 Feb 2026

This function sounds a duplicate of 'testValveStateOverride' and not specifically in use. we can delete it.

LEAHI-DD-FIRMWARE-LDT-2004-3 06 Feb 2026

fixed it

LEAHI-DD-FIRMWARE-LDT-2004-3 06 Feb 2026

Fixed it

LEAHI-DD-FIRMWARE-LDT-2004-3 06 Feb 2026

fixed it

LEAHI-DD-FIRMWARE-LDT-2004-3 06 Feb 2026

Ya , I forgot the coding guide line .
Fixed it

LEAHI-DIALIN-LDT-2004-1 06 Feb 2026

for Dry Bicart , I have reserved the message ID long time back as 0x70 and its correct. I was confused after staging branch merged with my local branch, since all of my other message ID are used by other modules except BICART_DATA. please dis regard this question.

LEAHI-DIALIN-LDT-3350-1 05 Feb 2026

Did we not decide to revert all the changes back and the redesign the whole concept again?

LEAHI-DIALIN-LDT-2004-1 06 Feb 2026

This is a merge issue. when I updated the code and aligned to staging , this all change happened. Need to check with Dara

LEAHI-TESTSUITES-LDT-2741-1 09 Feb 2026

updated as per comment

LEAHI-TESTSUITES-LDT-2741-1 09 Feb 2026

updated to utility.aut("-q")

LEAHI-TESTSUITES-LDT-2741-1 09 Feb 2026

updated to utility.aut("-q")

LEAHI-TESTSUITES-LDT-2741-1 09 Feb 2026

updated to utility.aut("-q")

LEAHI-TESTSUITES-LDT-2741-1 09 Feb 2026

updated to utility.aut("-q")

LEAHI-TESTSUITES-LDT-2741-1 09 Feb 2026

updated to utility.aut("-q")

LEAHI-TESTSUITES-LDT-2741-1 09 Feb 2026

updated as per comment

LEAHI-TESTSUITES-LDT-2741-1 09 Feb 2026

updated to utility.aut("-q")

LEAHI-DIALIN-LDT-2004-1 06 Feb 2026

Add a blank line between functions.

LEAHI-DIALIN-LDT-2994-3 06 Feb 2026

What is happening here? Is this a dynamic enum? Where is it used?

LEAHI-DIALIN-LDT-2004-1 09 Feb 2026

fixed it

LEAHI-DD-FIRMWARE-LDT-3344-1 09 Feb 2026

Align comments.

LEAHI-DD-FIRMWARE-LDT-2004-3 06 Feb 2026

Use explicit BOOL conditions (e.g. TRUE == isFreshDialysatePressureInRange).

LEAHI-DD-FIRMWARE-LDT-1473-1 10 Feb 2026

Updated

LEAHI-DIALIN-LDT-2004-1 06 Feb 2026

Is this staying? Is all of above replacing this class?

LEAHI-DD-FIRMWARE-LDT-3173-1 10 Feb 2026

see other comment.

LEAHI-DD-FIRMWARE-LDT-3173-1 09 Feb 2026

Is there going to be an #else for new sensor?

LEAHI-DD-FIRMWARE-LDT-3344-1 09 Feb 2026

Why doesn't name and comment match?

LEAHI-DD-FIRMWARE-LDT-2030-2 11 Feb 2026

Please change

bloodLeakState != BLOOD_LEAK_VERIFY_INTENSITY_AFTER_ZEROING_STATE
to
BLOOD_LEAK_VERIFY_INTENSITY_AFTER_ZEROING_STATE != bloodLeakState

LEAHI-TESTSUITES-LDT-3014-1 10 Feb 2026

Removed the duplicate objects

LEAHI-DD-FIRMWARE-LDT-3352-1 10 Feb 2026

Add comment to right listing which math functions we're using.

LEAHI-DIALIN-LDT-2994-3 09 Feb 2026

This class member is a way for dialin to present all the valve states in a list like so:

>>> fp = FP()
>>> fp.valves.valve_states_enum
[0, 0, 0, 0, 0, 0, 0]


It is organized in the order of the enum that was used to iterate. This is purely for presentation / Quality of life feature for the dialin user. We can remove it if we know users are no longer using it for monitoring

LEAHI-DD-FIRMWARE-LDT-2030-2 11 Feb 2026

Should these 2 #defines be converted to an enum? If we did that, we could add a "NUM_OF_" to end and use the "NUM_OF_" enum for array declarations instead of literal "2".

LEAHI-DD-FIRMWARE-LDT-2030-2 11 Feb 2026

Minor: Need space between parentheses

LEAHI-DD-FIRMWARE-LDT-2030-2 11 Feb 2026

Minor: Please add space in [cmd].

LEAHI-DD-FIRMWARE-LDT-2030-2 11 Feb 2026

Should it be bloodLeakEmbModeCmd?

LEAHI-DD-FIRMWARE-LDT-3344-1 10 Feb 2026

Resolved

LEAHI-DD-FIRMWARE-LDT-3344-1 11 Feb 2026

Can we remove this #if check? we can keep the comment.

LEAHI-DIALIN-LDT-3287-1 11 Feb 2026

fixed.

LEAHI-DD-FIRMWARE-LDT-3103-1 10 Feb 2026

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-3103-1 09 Feb 2026

This is from latest staging changes.

LEAHI-DIALIN-LDT-2004-1 09 Feb 2026

This is a change from Zoltan and I am updated that into my local branch

LEAHI-DIALIN-LDT-2004-1 10 Feb 2026

This is not the code that is currently on staging, so I think you need to update it from there

LEAHI-DD-FIRMWARE-LDT-3344-1 09 Feb 2026

Indenting looks off for most fields in this struct.

LEAHI-DD-FIRMWARE-LDT-3344-1 09 Feb 2026

Add space between } and type name.