•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-4001-1 01 Jun 2026

Also, add option individual parameter override for substitutions pump rate as well.

LEAHI-TD-FIRMWARE-LDT-2240-1 03 Jun 2026

Add doxygen comments to the right of each structure field.

LEAHI-TESTSUITES-LDT-2174-1 11 Dec 2025

Remove the delay

LEAHI-APPLICATION-LDT-2825-1 17 Dec 2025

add message id and number of parameters

LEAHI-DD-FIRMWARE-LDT-2185-1 11 Dec 2025

Put quadratic and linear terms in parentheses.

LEAHI-TD-FIRMWARE-LDT-473-1 16 Dec 2025

Deleted.

LEAHI-TD-FIRMWARE-LDT-473-1 16 Dec 2025

Yes, I deleted.

LEAHI-TESTSUITES-LDT-1802-1 18 Dec 2025

Now using get_object_color, get_object_source_path, get_object_text method and moved to configuration folder utility.py file

LEAHI-APPLICATION-LDT-3000-1 18 Dec 2025

removed

LEAHI-RO-FIRMWARE-LDT-2116-1 18 Dec 2025

fixed. thanks!

LEAHI-APPLICATION-LDT-3000-1 18 Dec 2025

updated to older design

LEAHI-DIALIN-LDT-2998-1 18 Dec 2025

Updated

LEAHI-APPLICATION-LDT-3000-1 17 Dec 2025

only update size on EndTreatmentDialog and leave this size as is. and fiz settings confirm dialogs

LEAHI-TESTSUITES-LDT-2278-1 16 Dec 2025

sorry "reasom" is mispelled.. should be "reason"

LEAHI-TD-FIRMWARE-LDT-2932-1 14 Dec 2025

Make ////< to ///< for doxygen to recognize it.

LEAHI-DD-FIRMWARE-LDT-2936-1 02 Dec 2025

Fixed.

LEAHI-TESTSUITES-LDT-2174-1 03 Dec 2025

this looks like a genaral method that can be moved to a shared file to be used elsewhere as well

LEAHI-TD-FIRMWARE-LDT-4033-1 20 May 2026

Write private handle functions for each state and call them in each case.

LEAHI-DD-FIRMWARE-LDT-618-2 04 Dec 2025

Noted.

LEAHI-TESTSUITES-LDT-2174-1 04 Dec 2025

Common methods are moved to utility.py file

LEAHI-DD-FIRMWARE-LDT-618-2 04 Dec 2025

Add blank line before return statement.

LEAHI-TD-FIRMWARE-LDT-473-1 02 Dec 2025

This is not how we typically spec details in function headers. Should be inputs and outputs at a minimum (see other function headers for example) and optionally alarms or messages sent or notes.
We can keep these details if you like, but they should be part of the brief above.

LEAHI-DIALIN-LDT-618-1 08 Dec 2025

Updated

LEAHI-TESTSUITES-LDT-1802-1 03 Dec 2025

I have updated the workflow text

LEAHI-TD-FIRMWARE-LDT-4033-1 21 May 2026

Typically, we would have state handle function return "next state" instead of changing the state directly.

LEAHI-TD-FIRMWARE-LDT-473-1 02 Dec 2025

validTreatParamsReceived is an input.

LEAHI-DD-FIRMWARE-LDT-2936-1 03 Dec 2025

We might need to provide a possibility to override the persistence time on alarm. To be clarified.

LEAHI-DD-FIRMWARE-LDT-2030-2 09 Dec 2025

Vendor - TEL - Sameer Poyil this structure is not used to message handling.

LEAHI-TESTSUITES-LDT-2174-1 05 Dec 2025

the QR code should not be visible. This test is not valid and incorrect because this should fail as we only get QR code once we validate all this checks if that object is there which it is there but not visible. We should be testing the visible property of the QR code section.

This also needs to be moved after the FW td_Treatment_Parameters_Validation to pass

LEAHI-TESTSUITES-LDT-1078-1 03 Dec 2025

can we make this a more general method and put in a shared file and update throughout.. update to something like

def setObjectText(obj, text):
    obj["text"] = text
    return obj:
LEAHI-TD-FIRMWARE-LDT-4033-1 20 May 2026

if syrPumpDACControl is U16 (2 bytes), then nibpCtl should be at 42.

LEAHI-TD-FIRMWARE-LDT-4033-1 22 May 2026

This looks like leftover from merge conflict. Remove this line.

LEAHI-TESTSUITES-LDT-2174-1 02 Dec 2025

#1. Change Duration -> Verify Heparin Stop Time "active" property is set to off

1. First set Duration, then Bolus Volume, then dispensing rate and then Hep Stop time
2. Change Duration.
3. Verify the "isActive" property of o_PreTreatmentCreate_heparinStopTimeControl_ValueAdjuster is set to False

LEAHI-TESTSUITES-LDT-2278-1 03 Dec 2025

move to a shared file

LEAHI-TESTSUITES-LDT-2278-1 03 Dec 2025

remove waits and add delay in waitforobject if needed

LEAHI-TD-FIRMWARE-LDT-3259-1 27 May 2026

If you disable mpu in the HALCoGen, this code will not be created.

LEAHI-TESTSUITES-LDT-2174-1 11 Dec 2025

Removed the waitForGUI

LEAHI-APPLICATION-LDT-2957-1 10 Dec 2025

Please use the mainTreatment screen as the default.
If necessary, could you create a specific enum to clean up the stack (which I do not believe is needed.)

LEAHI-APPLICATION-LDT-2957-1 10 Dec 2025

You no longer need this after you move the heparin screen from the sections folder.

LEAHI-TD-FIRMWARE-LDT-3970-1 26 May 2026

Please break it into two lines

LEAHI-RO-FIRMWARE-LDT-2116-1 18 Dec 2025

roRRTankFillAvg is an input.

LEAHI-TESTSUITES-LDT-2278-1 05 Dec 2025

use setObjectText () and remove this

LEAHI-TD-FIRMWARE-LDT-3259-1 27 May 2026

We shouldn't delete Halcogen code.
Add a #if 0 in this user code section and add a #endif in the user code section following _coreEnableFlashEcc() call.

LEAHI-APPLICATION-LDT-2957-1 12 Dec 2025

We will address this later on code modularizations.
RESOLVED.

LEAHI-DD-FIRMWARE-LDT-2185-1 12 Dec 2025

fixed it

LEAHI-DD-FIRMWARE-LDT-2185-1 11 Dec 2025

Remove handlePreGenPDefInletWaterState

LEAHI-TD-FIRMWARE-LDT-473-1 16 Dec 2025

ModeTxParams.c/.h are still not deleted. I want you to delete them and commit/push that change. Then I will see both files in RED here in this CR.

LEAHI-TD-FIRMWARE-LDT-473-1 16 Dec 2025

Does OperationModes.c need to include TxParams.h? TxParams is not a mode.

TEENSY-BOARD-LDT-2004-6 18 Dec 2025

fixed. thanks!

LEAHI-APPLICATION-LDT-2825-1 17 Dec 2025

Pull this line into the grouped property below.