•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-3103-1 10 Feb 2026

done

LEAHI-DD-FIRMWARE-LDT-3103-1 10 Feb 2026

Why not "TRUE == "?

LEAHI-DD-FIRMWARE-LDT-1473-1 10 Feb 2026

Done.

LEAHI-DIALIN-LDT-2004-1 10 Feb 2026

New code pushed

LEAHI-DD-FIRMWARE-LDT-1473-1 09 Feb 2026

seems to be old , need to merge the staging code

LEAHI-DD-FIRMWARE-LDT-3173-1 10 Feb 2026

reordered MSG IDs such that the teensy specific ones are wrapped in a macro and are far enough in sequence to not cause trouble when we are ready to remove them.

LEAHI-DD-FIRMWARE-LDT-3344-1 11 Feb 2026

changed.

LEAHI-DD-FIRMWARE-LDT-1473-1 10 Feb 2026

Looks crucible is not seeing those. let me check once with Dara.

LEAHI-DD-FIRMWARE-LDT-3173-1 10 Feb 2026

removed

LEAHI-DD-FIRMWARE-LDT-1473-1 11 Feb 2026

Done

LEAHI-DD-FIRMWARE-LDT-2030-2 11 Feb 2026

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-2030-2 11 Feb 2026

Please remove extra line

LEAHI-DIALIN-LDT-3287-1 11 Feb 2026

reverted handler to the original version. This was required to get a merge with develop to work

LEAHI-DIALIN-LDT-3287-1 10 Feb 2026

This code won't work. The sensor list missing the for loop that's populating it, and the original one is missing the M3 unpack. It's a merge of an old and a new code but both incomplete.

Please reference https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3480-1 for working solution on this.

LEAHI-DD-FIRMWARE-LDT-2030-2 11 Feb 2026

For init functions, I'm ok with saying something like "Blood leak driver unit variables initialized".