Comment Search

Details looks weird. Where is inputs and outputs like other function headers?

I think we are using it to send a message to Dialin, to let the tester know whether the command has passed/failed or timed out.

Can't have 3 values. Maximum 2 values allowed.

Missing doxygen group

Looks like the description part should only be in the @param part.
sysConfigTreatmentParameters should be an output? Input is None.
Add @details for alarms

Shouldn't we use Leahi instead of Denali?

It is weird that we're responding so far from request. It is not clear to me that Dialin has requested anything at this point.

added

Add blank line after banner

I think we only need one data message for both charger and battery pack data.

BN approves

BN approves

Add a blank line after banner.

Initialize in init function instead of here.

removed

This definitions has a terrible name (I have no idea what it does) and I think it should be reversed (i.e. alarms are disabled when defined so that a release build will have alarms enabled).

If I'm reading this right, we're saying that if bad CRC alarm is NOT enabled, initialize the alarm? That seems backward.

Just use requestAdultBPReading.

Space after closing paranthesis.

Removedd

updated accordingly.

Remove extra blank line.

Fix indent.

There is still merge conflict?
Please resolve merge conflict and build the code in your local before pushing.

i see some of the code is for building the code , could you please remove all such code ? or create a new branch and push it , it will confuse. while pushing the code , all supporting code for build / functionality should be removed.

Updated