•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-3174-1 26 Jan 2026

make variable

LEAHI-APPLICATION-LDT-2937-1 21 Jan 2026

Rinseback is initiated by the user during end treatment.

LEAHI-APPLICATION-LDT-3139-1 19 Jan 2026

remove empty lines

LEAHI-TESTSUITES-LDT-2971-1 19 Jan 2026

variable name has been update to: vTransmembranePressureLimitWindowRejectReason

LEAHI-APPLICATION-LDT-3106-1 21 Jan 2026

Removed.

LEAHI-DD-FIRMWARE-LDT-1925-1 20 Jan 2026

Fixed

LEAHI-DD-FIRMWARE-LDT-1925-1 20 Jan 2026

Updated

LEAHI-DD-FIRMWARE-LDT-1925-1 20 Jan 2026

Fixed

LEAHI-DD-FIRMWARE-LDT-1925-1 20 Jan 2026

For init functions, I think it's ok (and cleaner) to just say we initialize ALL unit variables.

LEAHI-DD-FIRMWARE-LDT-1925-1 20 Jan 2026

Why are we setting timer for pressure and PWM controls? Isn't it only applicable in flow control?
And why aren't we resetting exempt flag in same place as timer?

LEAHI-DD-FIRMWARE-LDT-1925-1 20 Jan 2026

I think this function should return TRUE if exempt (we are in first 10 seconds of flow control from off state). All criteria checked here in this function.

LEAHI-DD-FIRMWARE-LDT-1925-1 20 Jan 2026

Updated

LEAHI-DD-FIRMWARE-LDT-1925-1 20 Jan 2026

timeSinceP12Started?

BOOTLOADER-LEAH-1415-1 01 Oct 2024

This else could be removed if you just set next state to idle at top of function.

BOOTLOADER-LEAH-1415-1 01 Oct 2024

I don't think you are doing a double buffer. Remove this note.

BOOTLOADER-LEAH-1415-1 20 Jan 2026

Do we need an end of group marker down here?

BOOTLOADER-LEAH-1415-1 20 Jan 2026

TODO

LEAHI-DD-FIRMWARE-LDT-2004-3 23 Jan 2026

Rename like DRAIN_BICART_PUMP_SPEED. update comment as cartridge drains at maximum speed.

LEAHI-APPLICATION-LDT-3174-1 22 Jan 2026

<Prefix @ for advanced mode>

LEAHI-DIALIN-LDT-2980-1 21 Jan 2026

Updated

LEAHI-APPLICATION-LDT-2937-1 21 Jan 2026

Updated.

LEAHI-APPLICATION-LDT-2937-1 21 Jan 2026

Updated.

LEAHI-DD-FIRMWARE-LDT-2004-3 21 Jan 2026

BICARB_CHAMBER_PERIODIC_FILL_TIME

LEAHI-TESTSUITES-LDT-2741-1 19 Jan 2026

can we give the back buttons a more descirptive name like

o_SettingsBase_backButton_UserMode

LEAHI-DD-FIRMWARE-LDT-2998-1 21 Jan 2026

An alarm is triggered in this function. Add to header.

LEAHI-APPLICATION-LDT-2937-1 20 Jan 2026

Remove if not necessary.

LEAHI-APPLICATION-LDT-2937-1 21 Jan 2026

I don't see the updates.

LEAHI-APPLICATION-LDT-3106-1 21 Jan 2026

Thanks for the update.
Please update the styles as well.

LEAHI-DD-FIRMWARE-LDT-2004-3 21 Jan 2026

Please rename as DRY_BICART_FILL_VENT_TIME_MS

LEAHI-TESTSUITES-LDT-2741-1 22 Jan 2026

Now I am using application_init.update_password_back_to_default_password() function copy password from system.dflt to system.conf as per comment

LEAHI-TESTSUITES-LDT-2741-1 22 Jan 2026

Add def aut(name, *args):
"""
Joins the executable name and argument
into a single command string
"""
return " ".join((name, *args))
function in utility.py and using it main script startApplication(utility.aut("leahi", "-E")) as per comment

LEAHI-TESTSUITES-LDT-2741-1 22 Jan 2026

Removed duplicate objects

LEAHI-APPLICATION-LDT-3174-1 22 Jan 2026

get more specific on opmode and parameter set

add TD -> SW -> UI

LEAHI-APPLICATION-LDT-3174-1 22 Jan 2026

go UI -> SW - TD and vice versa and update self test to do same

LEAHI-APPLICATION-LDT-3174-1 22 Jan 2026

change to 250

LEAHI-APPLICATION-LDT-3174-1 22 Jan 2026

add TODO comment i added for my simulation

LEAHI-APPLICATION-LDT-3174-1 22 Jan 2026

always show sub pages

LEAHI-DD-FIRMWARE-LDT-2977-1 23 Jan 2026

fixed for both _TO_PWM macros

LEAHI-DD-FIRMWARE-LDT-2977-1 23 Jan 2026

fixed.

LEAHI-APPLICATION-LDT-3174-1 23 Jan 2026

updated to alwas who sub steps

LEAHI-APPLICATION-LDT-3174-1 23 Jan 2026

updated

LEAHI-DD-FIRMWARE-LDT-2004-3 23 Jan 2026

Fixed it

LEAHI-DD-FIRMWARE-LDT-2004-3 21 Jan 2026

remove empty line.

LEAHI-DD-FIRMWARE-LDT-2004-3 21 Jan 2026

Remove this macro.

LEAHI-TESTSUITES-LDT-2971-1 26 Jan 2026

Updated

LEAHI-DD-FIRMWARE-LDT-2004-1 26 Jan 2026

our standard overrides for conductivity values is covered in the monitor. Set function for conductivity has been implemented.

LEAHI-DD-FIRMWARE-LDT-2004-1 26 Jan 2026

fixed.

LEAHI-APPLICATION-LDT-2937-1 20 Jan 2026

Get new message IDs from Dara.

LEAHI-APPLICATION-LDT-3174-1 22 Jan 2026

Pre-Treatment

LEAHI-APPLICATION-LDT-3174-1 22 Jan 2026

Remove wait retry and pre-tx participants