•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-RO-FIRMWARE-LDT-2116-1 20 Nov 2025

Add blank line between declarations and code.

LEAHI-APPLICATION-LDT-4193-1 07 May 2026

add to Colors

LEAHI-SW-SCRIPTS-LDT-2727-1 24 Nov 2025

added

LEAHI-APPLICATION-LDT-4193-1 07 May 2026

made 2 sets of colors for dark and light.. handle changing colors on the outside of this global

LEAHI-APPLICATION-LDT-4959-1 29 Jul 2026

removed

LEAHI-TD-FIRMWARE-LDT-4063-1 29 Jul 2026

Fixed.

LEAHI-DD-FIRMWARE-LDT-2030-2 26 Nov 2025

Fixed. Thank you.

LEAHI-DD-FIRMWARE-LDT-2004-1 21 Nov 2025

Add space between } and type name.

LEAHI-DD-FIRMWARE-LDT-2004-1 21 Nov 2025

Remove extra blank line.

LEAHI-TESTSUITES-LDT-1802-1 26 Nov 2025

please keep this CR to only items used for this CR.

LEAHI-DD-FIRMWARE-LDT-2030-2 25 Nov 2025

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-2030-2 25 Nov 2025

Remove blank line.

LEAHI-DD-FIRMWARE-LDT-2030-2 24 Nov 2025

copy right missing

LEAHI-DD-FIRMWARE-LDT-2004-3 21 Nov 2025

bicart? Can we spell this out since this will be main description of this unit in SDD? Assuming bicart = dry bicarbonate cartridge?
Also, this unit appears to control bicarb chamber - not just cartridge - so we should mention that here.

LEAHI-DD-FIRMWARE-LDT-2004-3 21 Nov 2025

Can't we just do all of this in the start state?

LEAHI-DD-FIRMWARE-LDT-2030-2 24 Nov 2025

order of include file is not proper

TEENSY-BOARD-LDT-2004-6 24 Nov 2025

Add comments to describe new variables.

TEENSY-BOARD-LDT-2004-6 24 Nov 2025

Fix indent.

LEAHI-TD-FIRMWARE-LDT-5214-1 29 Jul 2026

Updated

LEAHI-RO-FIRMWARE-LDT-2116-1 20 Nov 2025

Add blank line between declarations and code.

LEAHI-DD-FIRMWARE-LDT-3963-1 08 May 2026

If BC switching period is Zero, I would expect the Qd from TD to also be zero, right? But what if it's not? What if Qd from TD is 600 and switching period is zero? You are going to run the pump pretty fast with no BC switching in that case.

LEAHI-APPLICATION-LDT-4959-1 29 Jul 2026

removed isFloat

LEAHI-DD-FIRMWARE-LDT-2030-2 25 Nov 2025

Packing only needed if it's used for transmission. I don't see this structure being broadcast anywhere.

LEAHI-TD-FIRMWARE-LDT-1886-1 25 Nov 2025

Done

LEAHI-DD-FIRMWARE-LDT-2004-1 21 Nov 2025

No param, so remove this line.

LEAHI-TESTSUITES-LDT-2174-1 26 Nov 2025

There may be a test.endSection() missing somewhere as the report shows a section not sectioned out. Please update regenerate report and review and reupload.

LEAHI-DD-FIRMWARE-LDT-2030-2 24 Nov 2025

structure packing statement missing

TEENSY-BOARD-LDT-2004-6 24 Nov 2025

Fix indent.

LEAHI-APPLICATION-LDT-4959-1 29 Jul 2026

removed

LEAHI-DD-FIRMWARE-LDT-4410-3 29 Jul 2026

please document this too

LEAHI-RO-FIRMWARE-LDT-2116-1 22 Nov 2025

Fixed. Thanks

LEAHI-RO-FIRMWARE-LDT-2116-1 20 Nov 2025

Remove blank line.

LEAHI-DD-FIRMWARE-LDT-5209-1 30 Jul 2026

Add a test support for Pregen fill request.

LEAHI-TD-FIRMWARE-LDT-1886-1 25 Nov 2025

Why is controller bypassing driver to get to fpga?

LEAHI-TESTSUITES-LDT-2174-1 26 Nov 2025

remove visible property

LEAHI-DD-FIRMWARE-LDT-2004-3 21 Nov 2025

Why not D64 in this case?

LEAHI-TESTSUITES-LDT-2174-1 24 Nov 2025

please align parameters

LEAHI-DD-FIRMWARE-LDT-2004-3 21 Nov 2025

Remove extra blank line.

TEENSY-BOARD-LDT-2004-6 24 Nov 2025

Fix indent.

LEAHI-DD-FIRMWARE-LDT-4183-1 12 May 2026

This dead band control ? here is the ideal place , may be BC to incldue the .h from drybicart

LEAHI-TD-FIRMWARE-LDT-2240-1 13 May 2026

added

LEAHI-RO-FIRMWARE-LDT-2116-1 21 Nov 2025

Remove blank line.

LEAHI-TD-FIRMWARE-LDT-1886-1 25 Nov 2025

Seems backward. Why is inactive = TRUE? I would expect TRUE to indicate that the optical sensor is detecting home (retracted) position.

LEAHI-DD-FIRMWARE-LDT-2004-1 21 Nov 2025

Use /// here so doxygen will pick it up.

LEAHI-DD-FIRMWARE-LDT-2004-1 21 Nov 2025

///

LEAHI-DD-FIRMWARE-LDT-2004-1 21 Nov 2025

Add space between } and type name.

LEAHI-DD-FIRMWARE-LDT-2004-1 21 Nov 2025

measurementSettingsTX is an output.

LEAHI-RO-FIRMWARE-LDT-2116-1 24 Nov 2025

is this year correct ?

LEAHI-DD-FIRMWARE-LDT-2004-3 21 Nov 2025

Should D64 also be in the #ifndef below? The DryBiCart state machine controls this valve too.

LEAHI-DD-FIRMWARE-LDT-2030-2 24 Nov 2025

Please arrange it in alphabetical order