•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-RO-FIRMWARE-LDT-2116-1 18 Nov 2025

copy right file header missing

LEAHI-RO-FIRMWARE-LDT-2116-1 18 Nov 2025

use complete word as in line 87 and 88 , PRESSURE

LEAHI-TESTSUITES-LDT-1078-1 14 Nov 2025

for this do not hard code as it will only work with this specific build. Use"./leahi --version" to get the version then test that with what we display in GUI

LEAHI-TESTSUITES-LDT-1650-1 14 Nov 2025

this will not work and fail. This is build specific and will only work with the current leahi build.. Please get the version using "./leahi --version" and use that

LEAHI-RO-FIRMWARE-LDT-2116-1 18 Nov 2025

do not use magic numbers

LEAHI-DD-FIRMWARE-LDT-2004-2 20 Nov 2025

Should we be calling a get function in Conductivity.c (monitor) instead of driver? Monitor would give a filtered value and driver would give a raw value. I would think only the monitor would want the raw value.

LEAHI-DD-FIRMWARE-LDT-2004-2 20 Nov 2025

I think this is ok as is. We do want includes in alphabetical order, but in groups: 1) library header files, 2) HAL header files, and 3) our header files.

LEAHI-DD-FIRMWARE-LDT-2004-2 20 Nov 2025

Need doxygen comment.

LEAHI-SW-SCRIPTS-LDT-2727-1 17 Nov 2025

sleep 0.1

LEAHI-DD-FIRMWARE-LDT-2004-2 20 Nov 2025

Prefer something like if ( FALSE == isQueueFull() ).

LEAHI-DD-FIRMWARE-LDT-2004-2 20 Nov 2025

I don't see support for that with our compiler. Author of code must ensure destination buffer is large enough to hold the specified number of bytes being copied. Code reviewer should verify this.

LEAHI-DD-FIRMWARE-LDT-2004-2 20 Nov 2025

#ifdef

LEAHI-DD-FIRMWARE-LDT-2004-2 20 Nov 2025

Are we not supporting overrides with TEENSY driver?

LEAHI-RO-FIRMWARE-LDT-2116-1 18 Nov 2025

let RO comes first , MSG_ID_FP_RO_FILTERED_REJECTION_RATIO

LEAHI-DD-FIRMWARE-LDT-2004-2 20 Nov 2025

All functions need function headers.

LEAHI-DD-FIRMWARE-LDT-2004-2 18 Nov 2025

Follow alphabetical order of including header file

LEAHI-DD-FIRMWARE-LDT-2004-2 20 Nov 2025

Comment seems backward. Uncommenting would enable the Teensy driver, right?

LEAHI-TD-FIRMWARE-LDT-3970-1 29 Apr 2026

You moved this to TxParams.h and I think that's right. I also think all of these other edit treatment parameters message payloads will also need to be moved as well.

LEAHI-APPLICATION-LDT-3932-1 06 May 2026

removed demo code

LEAHI-RO-FIRMWARE-LDT-2116-1 22 Nov 2025

Fixed. Thanks

LEAHI-DD-FIRMWARE-LDT-2030-2 26 Nov 2025

fixed. thank you.

LEAHI-APPLICATION-LDT-3932-1 06 May 2026

updated

LEAHI-DD-FIRMWARE-LDT-2030-2 26 Nov 2025

called it from here. Fixed it. Thank you

LEAHI-TD-FIRMWARE-LDT-3970-1 05 May 2026

2 lines above/below banner

LEAHI-DD-FIRMWARE-LDT-2030-2 26 Nov 2025

Removed. Thank you.

LEAHI-DD-FIRMWARE-LDT-2004-3 21 Nov 2025

Add spaces around void.

LEAHI-FWCOMMON-LDT-2116-1 21 Nov 2025

Consider increasing even more. May 50 or even 100.

LEAHI-TD-FIRMWARE-LDT-2240-1 07 May 2026

Updated

LEAHI-DIALIN-LDT-3505-1 07 May 2026

Please use the generic broadcast override function from common, like all the other modules.

LEAHI-APPLICATION-LDT-4193-1 07 May 2026

add DD opmode to diagnostics

LEAHI-APPLICATION-LDT-4193-1 07 May 2026

move to system.config

LEAHI-DD-FIRMWARE-LDT-4410-3 29 Jul 2026

Remove the commented lines.

LEAHI-DD-FIRMWARE-LDT-4410-3 29 Jul 2026

Remove extra blank line.

LEAHI-TD-FIRMWARE-LDT-4031-1 30 Jul 2026

Add a blank line before return statement.

LEAHI-APPLICATION-LDT-3932-1 07 May 2026

BN APPROVES

LEAHI-APPLICATION-LDT-3932-1 07 May 2026

BN APPROVES

LEAHI-RO-FIRMWARE-LDT-2116-1 20 Nov 2025

Add blank line between declarations and code.

LEAHI-RO-FIRMWARE-LDT-2116-1 20 Nov 2025

Remove blank line.

LEAHI-DIALIN-LDT-3505-1 07 May 2026

Please remove for the above reasons.

LEAHI-SW-PLUGINS-SIM-LDT-4919-1 29 Jul 2026

updated

LEAHI-TD-FIRMWARE-LDT-1886-1 25 Nov 2025

Took note that the FPGA interface is at the driver level.

LEAHI-DD-FIRMWARE-LDT-2030-2 26 Nov 2025

Fixed. Thank you.

LEAHI-DD-FIRMWARE-LDT-2004-1 21 Nov 2025

///

LEAHI-TD-FIRMWARE-LDT-4063-1 29 Jul 2026

I would think reason code 1 would work for this - do we really need to add this one?

LEAHI-DD-FIRMWARE-LDT-4500-1 29 Jul 2026

Updated

LEAHI-DD-FIRMWARE-LDT-4410-3 29 Jul 2026

Align the indentation

LEAHI-DD-FIRMWARE-LDT-5209-1 30 Jul 2026

Add the header description.

LEAHI-TESTSUITES-LDT-2951-1 08 May 2026

delete this file and its verificationPoints folder

LEAHI-RO-FIRMWARE-LDT-2116-1 22 Nov 2025

Fixed. Thanks

LEAHI-DIALIN-LDT-3505-1 07 May 2026

please use the generic_override function from the common folder