•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-3106-1 20 Jan 2026

Remove.

LEAHI-APPLICATION-LDT-3106-1 20 Jan 2026

Remove.

LEAHI-APPLICATION-LDT-3174-1 22 Jan 2026

Change all Advanced to "@Installation"

LEAHI-DD-FIRMWARE-LDT-2004-3 23 Jan 2026

balancing chamber valves. remove pressure.

LEAHI-TESTSUITES-LDT-2741-1 22 Jan 2026

updated as per comment

LEAHI-APPLICATION-LDT-3174-1 23 Jan 2026

updated all

LEAHI-APPLICATION-LDT-3174-1 23 Jan 2026

removed all simulation code

LEAHI-APPLICATION-LDT-3174-1 23 Jan 2026

updated

LEAHI-DD-FIRMWARE-LDT-2004-3 23 Jan 2026

fixed it

LEAHI-DD-FIRMWARE-LDT-2004-3 23 Jan 2026

Not sure where to place it , so now it is implemented in Pre-Gen

LEAHI-TESTSUITES-LDT-2741-1 23 Jan 2026

thats fine leave as is then

LEAHI-TESTSUITES-LDT-2741-1 19 Jan 2026

same as above and other back button in the settings pages

LEAHI-DD-FIRMWARE-LDT-2004-3 21 Jan 2026

Move the actuators into drain start state.

LEAHI-DD-FIRMWARE-LDT-2004-3 21 Jan 2026

add space at end of close parenthesis.

LEAHI-DD-FIRMWARE-LDT-2004-3 23 Jan 2026

Fixed it

LEAHI-TESTSUITES-LDT-2971-1 26 Jan 2026

Modified as per suggestion

LEAHI-TESTSUITES-LDT-2971-1 23 Jan 2026

typo should be parameter

LEAHI-TESTSUITES-LDT-2971-1 20 Jan 2026

Please update with new steps from latest Staging build.. MODE_TPAR is now obsolete and to enter pre treatment to get to the create rx user must enter Pretreatment opmode.

LEAHI-DD-FIRMWARE-LDT-2004-1 26 Jan 2026

removed.

LEAHI-DD-FIRMWARE-LDT-2004-1 26 Jan 2026

see previous comment.

LEAHI-DD-FIRMWARE-LDT-2004-1 26 Jan 2026

yes. they are added.

LEAHI-DIALIN-LDT-2937-1 20 Jan 2026

Get new message IDs from Dara.

LEAHI-DIALIN-LDT-2004-2 26 Jan 2026

It handles different size of payloads, and requests without payload without having an issue, so I don't understand why would it cause an issue.
you are sending a message with this msg id and this payload, if the FW is expecting that, then it will work.

Should I rename the cmd_generic_override to like cmd_generic_message_sender to be less confusing?

LEAHI-APPLICATION-LDT-3174-1 22 Jan 2026

prime state

LEAHI-APPLICATION-LDT-3174-1 22 Jan 2026

Rename file to Pre-Treatment

LEAHI-DD-FIRMWARE-LDT-2004-1 26 Jan 2026

Is calibration going to be done here or at driver? I was expecting driver to calibrate since cal factors are coming from sensor.

LEAHI-DIALIN-LDT-3160-1 27 Jan 2026

Updated based on FW

LEAHI-DIALIN-LDT-3160-1 27 Jan 2026

renamed

LEAHI-APPLICATION-LDT-3174-1 26 Jan 2026

keep and add TODO comment

LEAHI-APPLICATION-LDT-3174-1 26 Jan 2026

update all [xA1: #0] Req \n\t Title

LEAHI-DD-FIRMWARE-LDT-2004-3 22 Jan 2026

Remove extra blank line.

LEAHI-TESTSUITES-LDT-2971-1 20 Jan 2026

Removed the line

LEAHI-TESTSUITES-LDT-2971-1 19 Jan 2026

variable name has been update to: vTransmembranePressureLimitWindowRejectReason

LEAHI-DIALIN-LDT-611-1 20 Jan 2026

I added the unique decorator back, except for the few that have aliases

LEAHI-DD-FIRMWARE-LDT-1925-1 20 Jan 2026

I think timer should be internal (private) to this unit.

LEAHI-DD-FIRMWARE-LDT-1925-1 20 Jan 2026

I think timeout should be handled inside ROPump unit. From here, we should just call one function that tells us whether alarm should be exempt or not.

BOOTLOADER-LEAH-1415-1 01 Oct 2024

Change "is the" to "is in". Remove extra "and".

BOOTLOADER-LEAH-1415-1 20 Jan 2026

TODO should be all caps.

LEAHI-APPLICATION-LDT-3106-1 21 Jan 2026

Updated.

LEAHI-APPLICATION-LDT-2937-1 21 Jan 2026

Does not seem to be updated, right?

LEAHI-DIALIN-LDT-2937-1 20 Jan 2026

Create specific functions for each message.

LEAHI-APPLICATION-LDT-3174-1 23 Jan 2026

added

LEAHI-APPLICATION-LDT-3174-1 23 Jan 2026

updated

LEAHI-TESTSUITES-LDT-2741-1 23 Jan 2026

please remove AUT_NAME and AUT_NAME_ONLY and update the other tests accordinglt please

LEAHI-DD-FIRMWARE-LDT-2004-3 21 Jan 2026

bicarbChamberPeriodicFillCounter

LEAHI-DIALIN-LDT-2004-2 26 Jan 2026

fixed writing over the error count override.

Model ID isnt an override. Its a set as it does not revert back to another value. FW will be looking for only 1 U32 instead of a TEST_OVERRIDE_PAYLOAD_T.

the generic override will cause the FW to always reject the value since the payload size is not what is expected.

LEAHI-APPLICATION-LDT-3106-1 20 Jan 2026

Get new mesg IDs from Dara.

LEAHI-DD-FIRMWARE-LDT-2004-3 22 Jan 2026

Update inputs/outputs. I think more have been added.

LEAHI-TESTSUITES-LDT-2741-1 23 Jan 2026

for each sections please wrap around test.startSection() and test.endSection() so the test case report matches the outline commented at the top of the file

LEAHI-TD-FIRMWARE-LDT-1415-1 26 Jan 2026

Missing comment to right