•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-4193-1 18 May 2026

updated

LEAHI-APPLICATION-LDT-4193-1 19 May 2026

bn approves

LEAHI-TD-FIRMWARE-LDT-4072-2 19 May 2026

Combine charger and pack data into one payload with one broadcast message.

LEAHI-TD-FIRMWARE-LDT-4072-2 15 May 2026

Should have a doxygen group (like driver does).

LEAHI-TD-FIRMWARE-LDT-4072-2 15 May 2026

Use Leahi function format and helper functions for overrides.

LEAHI-TD-FIRMWARE-LDT-4033-1 17 May 2026

If we don't set this pwm time anymore, we don't need this. Please make sure we really don't need this anymore though.

LEAHI-TD-FIRMWARE-LDT-3505-1 19 May 2026

Align comment.

LEAHI-TD-FIRMWARE-LDT-4033-1 20 May 2026

Yes added

LEAHI-TD-FIRMWARE-LDT-4033-1 20 May 2026

Yes, updated

LEAHI-TD-FIRMWARE-LDT-4033-1 20 May 2026

Updated

LEAHI-TD-FIRMWARE-LDT-4033-1 20 May 2026

Look for request flag to give measure command and transition to measure state.

LEAHI-TD-FIRMWARE-LDT-4033-1 20 May 2026

Do we need this state if all it's doing is going to IDLE?

LEAHI-TD-FIRMWARE-LDT-4033-1 21 May 2026

I'm not sure we need these "Detected" functions. I would expect that when this controller gets new readings, it will check for these alarm conditions in the check state and trigger alarm if appropriate. So if we are triggering alarms in this controller, there is no need for outside code to ask if these alarms are detected.

LEAHI-APPLICATION-LDT-4193-1 21 May 2026

BN aoorives

LEAHI-TD-FIRMWARE-LDT-3505-1 20 May 2026

Use OVERRIDE_RESET for .override instead of 0.

LEAHI-DD-FIRMWARE-LDT-3963-1 17 May 2026

Same comments as ENABLE_ALARM_1 above.

LEAHI-DD-FIRMWARE-LDT-3963-1 17 May 2026

Same comments as ENABLE_ALARM_1 above.

LEAHI-TD-FIRMWARE-LDT-4033-1 21 May 2026

I don't think we want to zero this count here.

LEAHI-TD-FIRMWARE-LDT-4033-1 21 May 2026

See other switch statements with s/w faults to see how to trigger it. We need 2 data: 1 is specific s/w fault enum and 2 is the invalid state.

LEAHI-TD-FIRMWARE-LDT-4033-1 17 May 2026

I don't think these definitions need to be public. Some of these should probably be inside the FpgaTD.c and some should probably be inside your driver's .c file.

LEAHI-TD-FIRMWARE-LDT-3259-1 27 May 2026

Done

LEAHI-TD-FIRMWARE-LDT-4033-1 22 May 2026

Thats for error register so not required now

LEAHI-TD-FIRMWARE-LDT-4033-1 21 May 2026

Why do you have { here?

LEAHI-TD-FIRMWARE-LDT-3259-1 27 May 2026

These are not in alphabetical order. See ModeStandby and ModeService and ModeFault.

LEAHI-TD-FIRMWARE-LDT-3970-1 26 May 2026

Can we rename this to TREATMENT_DURATION_CONFIRM_REQUEST_PAYLOAD_T

LEAHI-TESTSUITES-LDT-3208-1 19 May 2026

yes i updated this in another current branch to better use ..

font.italic     : true


so please remove the <i> from the string

LEAHI-TD-FIRMWARE-LDT-3259-1 27 May 2026

Done

LEAHI-TD-FIRMWARE-LDT-3970-1 26 May 2026

remove camel case for SetPoint, instead use Setpoint
Update line 659 too

LEAHI-TD-FIRMWARE-LDT-3970-1 12 May 2026

Please indent the doxygen comments of all the functions, similar to existing functions.

LEAHI-TD-FIRMWARE-LDT-3259-1 27 May 2026

same.

LEAHI-TD-FIRMWARE-LDT-4072-2 20 May 2026

slaveAddr should be an enum now and so just "device".

LEAHI-TD-FIRMWARE-LDT-4013-1 20 May 2026

Move this function to your service.

LEAHI-DD-FIRMWARE-LDT-4410-3 29 Jul 2026

added

LEAHI-TD-FIRMWARE-LDT-4063-1 29 Jul 2026

I don't see it.

LEAHI-TD-FIRMWARE-LDT-4072-2 19 May 2026

Remove.

LEAHI-RO-FIRMWARE-LDT-2116-1 22 Nov 2025

Fixed. Thanks

LEAHI-RO-FIRMWARE-LDT-2116-1 18 Nov 2025

comment start with capital letter. check all other places.

LEAHI-DD-FIRMWARE-LDT-2030-2 26 Nov 2025

Moved the enums to driver header file. Fixed it.

LEAHI-DD-FIRMWARE-LDT-2030-2 24 Nov 2025

copy right missing

LEAHI-DD-FIRMWARE-LDT-2004-3 21 Nov 2025

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-2030-2 24 Nov 2025

copy right missing

LEAHI-TD-FIRMWARE-LDT-3970-1 12 May 2026

Please keep on declaration of the variables in this section and move the initialization to initTreatmentParameters

LEAHI-TD-FIRMWARE-LDT-4072-2 15 May 2026

These should be in alphabetical order.

LEAHI-TD-FIRMWARE-LDT-4072-2 15 May 2026

remove extra blank line.

LEAHI-TD-FIRMWARE-LDT-4013-1 20 May 2026

Move up with rest

LEAHI-DD-FIRMWARE-LDT-3963-1 14 May 2026

I had this commented again to push to the develop branch. It is uncommented for my testing.

LEAHI-APPLICATION-LDT-4193-1 18 May 2026

separatated

LEAHI-APPLICATION-LDT-4193-1 18 May 2026

added to diagnostics

LEAHI-APPLICATION-LDT-4213-1 18 May 2026

fixed

LEAHI-APPLICATION-LDT-4193-1 19 May 2026

BN approves