•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-2937-1 21 Jan 2026

Updated.

LEAHI-DIALIN-LDT-2937-1 21 Jan 2026

Updated.

LEAHI-APPLICATION-LDT-2937-1 22 Jan 2026

Updated.

LEAHI-APPLICATION-LDT-3174-1 23 Jan 2026

removed

LEAHI-APPLICATION-LDT-3174-1 23 Jan 2026

updated

LEAHI-DD-FIRMWARE-LDT-2004-3 23 Jan 2026

Fixed it

LEAHI-DD-FIRMWARE-LDT-2004-3 23 Jan 2026

Fixed it

LEAHI-DD-FIRMWARE-LDT-2004-1 26 Jan 2026

fixed.

LEAHI-APPLICATION-LDT-3174-1 22 Jan 2026

Change HD to TD.

LEAHI-TD-FIRMWARE-LDT-1415-1 26 Jan 2026

Add the word "pressure" after TMP in comments.

LEAHI-DD-FIRMWARE-LDT-2004-3 23 Jan 2026

Complex conditional expressions can be avoided. Introduce
temporary boolean variables instead.

for example
if ((elementNo < 0) || (elementNo > maxElement)||
elementNo == lastElement)

Unknown macro: { … }


should be replaced by:
isFinished = (elementNo < 0) || (elementNo > maxElement);
isRepeatedEntry = elementNo == lastElement;
if ((isFinished == TRUE) || (isRepeatedEntry == TRUE))

LEAHI-DD-FIRMWARE-LDT-3103-1 21 Jan 2026

We will have to look at it as well. But for now, we are just monitoring the fresh side pressure variation.

LEAHI-APPLICATION-LDT-2937-1 21 Jan 2026

Please add that to be reflected in the Sequence Diagram.

LEAHI-DD-FIRMWARE-LDT-2004-1 26 Jan 2026

function has been renamed and re-purposed. Documentation has been updated.

LEAHI-TESTSUITES-LDT-2741-1 22 Jan 2026

Updated as per comment and Named as o_SettingsBase_backButton_AdvancedMode as per New Leahi UI change from UserMode

LEAHI-DD-FIRMWARE-LDT-2004-3 22 Jan 2026

Done

LEAHI-APPLICATION-LDT-3174-1 23 Jan 2026

updated

LEAHI-APPLICATION-LDT-3174-1 23 Jan 2026

added

LEAHI-DD-FIRMWARE-LDT-2004-3 23 Jan 2026

fixed it

LEAHI-TESTSUITES-LDT-2741-1 19 Jan 2026

I am encountering an issue when running the first time I can change the manufacturing password but a consecutive time I need to reset the password manually. Can we reset the password programmatically?

Example after the test is over to revert the password you can copy the contents of the default settings.. e.q. System.dflt and overwrite the System.conf file to reset everything for future test cases that do use the service password.

LEAHI-APPLICATION-LDT-3174-1 22 Jan 2026

remove DEMO code and enable next buttons

LEAHI-DD-FIRMWARE-LDT-2004-1 26 Jan 2026

If we're not using filtered values, why filter them at all?

LEAHI-TESTSUITES-LDT-2971-1 26 Jan 2026

I am able to click on Heparin button

LEAHI-TD-FIRMWARE-LDT-1415-1 26 Jan 2026

Why are we keeping any code where the STABILIZATION_2 state used to be? Shouldn't the entire case be deleted?

LEAHI-TESTSUITES-LDT-2971-1 26 Jan 2026

this may not work all the time the number of pre treatment steps are not a exact number of steps the steps are created dyniamically.

Steps depend on:

  • advanced / standard mode
  • water sample featured/defreatured


Keep this in mind and let come up with a way to navigate through the steps.

Something like getting the "StepNavitgationTitleBar" componenet and accessing the "stepNames" property will give you a string list of the pre treatment steps. This is generating every time we enter pretreatment upon the conditions the test steps are made dynamically.

LEAHI-DD-FIRMWARE-LDT-2998-1 21 Jan 2026

Added

LEAHI-DIALIN-LDT-2937-1 21 Jan 2026

Doesn't seem to be the updated IDs.

LEAHI-APPLICATION-LDT-3174-1 23 Jan 2026

updated

LEAHI-DD-FIRMWARE-LDT-2004-1 26 Jan 2026

The monitor get's are filtered. Driver get's will pull one point of data. The old code was calling the get that was not filtered. Should dialysate temp check based off of a filtered value?

LEAHI-DD-FIRMWARE-LDT-2004-1 26 Jan 2026

removed duplicate

LEAHI-DD-FIRMWARE-LDT-2004-1 26 Jan 2026

fixed spelling

LEAHI-APPLICATION-LDT-3174-1 22 Jan 2026

change to 250

LEAHI-TESTSUITES-LDT-2971-1 26 Jan 2026

With new ui change after click on confirm no need to change the mode Is this ok Can you please confirm

LEAHI-APPLICATION-LDT-3194-1 26 Jan 2026

remove debug line

LEAHI-TD-FIRMWARE-LDT-1415-1 26 Jan 2026

Does ModeTxParams.h exist? Didn't we change this to a service?

LEAHI-APPLICATION-LDT-3174-1 26 Jan 2026

add 0.1 to variables

LEAHI-APPLICATION-LDT-2937-1 22 Jan 2026

Updated.

LEAHI-APPLICATION-LDT-2937-1 22 Jan 2026

All the different possible values for cmd in the command request message were added.

LEAHI-DD-FIRMWARE-LDT-2977-1 23 Jan 2026

its been removed. looks like we send everything down as a percentage now and the fluid pump driver will change it counts.

LEAHI-DD-FIRMWARE-LDT-2977-1 23 Jan 2026

When comment is above, use /// instead of ///<. And add blank lines before/after - doxygen seems to get confused about where to apply the comment without clear separation.

LEAHI-APPLICATION-LDT-3174-1 23 Jan 2026

updated

LEAHI-APPLICATION-LDT-3174-1 23 Jan 2026

updated

LEAHI-DD-FIRMWARE-LDT-2977-1 23 Jan 2026

For long macros, consider moving doxygen comment from right side to line above with /// since right side won't line up with others.

LEAHI-DD-FIRMWARE-LDT-2004-3 23 Jan 2026

Fixed it

LEAHI-DD-FIRMWARE-LDT-2004-3 23 Jan 2026

Fixed it

LEAHI-APPLICATION-LDT-3174-1 22 Jan 2026

add message id

LEAHI-TESTSUITES-LDT-2971-1 26 Jan 2026

Updated as per new modification

LEAHI-TESTSUITES-LDT-2971-1 23 Jan 2026

fix numbering of test steps and update to match update test report

LEAHI-DD-FIRMWARE-LDT-2004-1 26 Jan 2026

correct. It has been updated to call around based the build switch

LEAHI-DIALIN-LDT-2004-2 26 Jan 2026

Can't we use the generic override?
You just need to update 3 fields:

msg_id = MsgIds.MSG_ID_DD_SET_CONDUCTIVITY_MODEL_REQUEST
entity_name = 'DD Coductivity sensor model request'
override_text = 'Sent' or ''