•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-TD-FIRMWARE-LDT-1886-2 05 May 2026

Can we please add more comments in this function to explain the rationale behind the checks and the actions?

LEAHI-TD-FIRMWARE-LDT-2240-1 07 May 2026

Updated

LEAHI-TD-FIRMWARE-LDT-2240-1 07 May 2026

Updated

LEAHI-TD-FIRMWARE-LDT-2240-1 05 May 2026

Don't need this flag or this if statement.

LEAHI-TD-FIRMWARE-LDT-2240-1 05 May 2026

initialize start time for next state. Should we set a flag indicating we completed the tube set checks?

LEAHI-DD-FIRMWARE-LDT-4410-3 27 Jul 2026

it was updated in the latest staging

LEAHI-DD-FIRMWARE-LDT-3963-1 04 May 2026

Name something similar to 'BCSwitchingBasedOnClosePeriodCounter'?

LEAHI-DD-FIRMWARE-LDT-3963-1 28 Apr 2026

First two logics ANDed correct (first cycle and close period). the third one (BC switch only must be ANDed only with close period), not to include first cycle..

LEAHI-DD-FIRMWARE-LDT-4011-1 28 Jul 2026

renamed. thanks!

LEAHI-DIALIN-LDT-3505-1 07 May 2026

please use the generic_override function from the common folder

LEAHI-DIALIN-LDT-3505-1 07 May 2026

please use the generic_override function from the common folder

LEAHI-DIALIN-LDT-3505-1 07 May 2026

This is a duplicate, the syrnge_pump_state can be accessed directly, there is no need for a wrapper function for it, so please remove.

LEAHI-TD-FIRMWARE-LDT-3970-1 06 May 2026

I think validated variable here should be L/Hr and assigned to response.ufRate so that when we get confirmation, we can compare rates with same units.

LEAHI-APPLICATION-LDT-4919-1 28 Jul 2026

nice try BN approves

LEAHI-TD-FIRMWARE-LDT-5214-1 27 Jul 2026

the function call seems returning U16. Type cast to U32.

LEAHI-TD-FIRMWARE-LDT-4029-1 28 Jul 2026

Add initialization for heparinSetupResumeRequested and syringeLoadConfirmed

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

I do not see the script's exit code in the date_time_set.sh script.
https://devapps.diality.us/cru/#LEAHI-SW-SCRIPTS-LDT-2727-1CFR-76860

TD-LDT-1886-7 10 Nov 2025

None?

LEAHI-TD-FIRMWARE-LDT-3970-1 26 Apr 2026

See if we have already defined this stuff in Services\TxParams. TxParams may also have get function(s) for min/max values that you can use.

LEAHI-APPLICATION-LDT-3932-1 06 May 2026

removed demo code

LEAHI-TD-FIRMWARE-LDT-2240-1 07 May 2026

Removed

LEAHI-APPLICATION-LDT-2727-1 13 Nov 2025

👍 Will do all these in the enhancement story

LEAHI-APPLICATION-LDT-3932-1 07 May 2026

BN APPROVES

LEAHI-DD-FIRMWARE-LDT-2662-1 12 Nov 2025

updated to now change result to FALSE if we get a rr that is not NONE

LEAHI-APPLICATION-LDT-2727-1 13 Nov 2025

updated

LEAHI-TESTSUITES-LDT-3588-1 28 Apr 2026

For this one we do not want to create a whole new test case we want to update the existing ones with the update..
1. Update tst_edit_parameters (even though its still in review)

  • Treatment time confirm dialog


2. Update tst_solution_infusion test case make it pass changing the name to "fluid delivery"
3. Update tst_main_treatment

  • UF Paused the new tag on the main treatment screen showing the status.
    --add test in main treatmetn test case to cover when paused and complete


4. Pull staging and update End of treatment

  • UF edit button is now disabled in end of tx
LEAHI-TD-FIRMWARE-LDT-2240-1 05 May 2026

Want to stop air pump, not end air trap control.

LEAHI-DIALIN-LDT-3505-1 07 May 2026

Please remove for the above reasons.

LEAHI-DD-FIRMWARE-LDT-4001-1 11 Jun 2026

fixed thanks

LEAHI-TD-FIRMWARE-LDT-2240-1 05 May 2026

Shouldn't this be the pressure sensor normal setup state?

LEAHI-TD-FIRMWARE-LDT-4031-1 27 Jul 2026

Why is this on a separate line? Move after = above.

LEAHI-TD-FIRMWARE-LDT-4029-1 28 Jul 2026

Delete this row.

TD-LDT-1886-7 10 Nov 2025

Then put an #if 0 around this if and add a TODO comment to implement the test configuration.

LEAHI-TD-FIRMWARE-LDT-473-3 28 Apr 2026

???

LEAHI-TD-FIRMWARE-LDT-473-3 28 Apr 2026

Do we need a parameter for confirmation?

LEAHI-APPLICATION-LDT-4161-1 07 May 2026

BN Approves

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

updated to store in file sysetm

LEAHI-TD-FIRMWARE-LDT-4188-1 30 Apr 2026

comment still needed?

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

updated

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

is this a typo?

LEAHI-SW-PLUGINS-SIM-LDT-5246-1 28 Jul 2026

The CR is reviewed and approved.

LEAHI-DD-FIRMWARE-LDT-2662-1 13 Nov 2025

fixed. thanks

LEAHI-APPLICATION-LDT-2727-1 13 Nov 2025

added comment

LEAHI-TD-FIRMWARE-LDT-2240-1 03 May 2026

Why is this service prefixed with "Tx"?
Also, Praneeth and I agreed to put these state machine services into a sub-folder of Services. See how he did it and do the same.

LEAHI-TD-FIRMWARE-LDT-4188-1 03 May 2026

We should just have 1 of these. Let's have TD always working in mL and mL/min, and we'll just convert before sending to UI or after receiving from UI.

LEAHI-APPLICATION-LDT-2727-1 13 Nov 2025

the content for each page is now set to this container which will handle the margins for the container so all componenets using the SettingsBase will have the same margins and I do not have to specify them left, right, bottom in each of them.. I have done the same thing for other components that act as a container

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

Shouldn't it check the password from FS (Service.conf)?
If so, FS interaction is missing.

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

These two lines can be moved to the geteopochUTC.

LEAHI-DD-FIRMWARE-LDT-2004-1 12 Nov 2025

error count or reading temperature?

LEAHI-DD-FIRMWARE-LDT-2004-1 12 Nov 2025

UNINITIALIZED?