•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-TESTSUITES-LDT-2174-1 07 Jan 2026

After discussing with the team can we remove testing every item from min to max and only set from from inactiveto active (from – to a value). Only test Hep Dispensing Rate from Max to Min then to OFF.

Also keep the 4 scenarios that are I suggested as well

LEAHI-APPLICATION-LDT-2937-1 20 Jan 2026

Update sequence style to match Nico's.

BOOTLOADER-LEAH-1415-1 16 Jan 2026

This is still in use.

LEAHI-DD-FIRMWARE-LDT-2185-1 14 Jan 2026

Fixed

LEAHI-DD-FIRMWARE-LDT-2185-1 14 Jan 2026

Fixed

LEAHI-DD-FIRMWARE-LDT-2185-1 14 Jan 2026

Remove blank line.

LEAHI-DD-FIRMWARE-LDT-2185-1 14 Jan 2026

Remove extra blank line.

LEAHI-APPLICATION-LDT-2805-1 06 Jan 2026

Make value red if out of range.

LEAHI-APPLICATION-LDT-2805-1 06 Jan 2026

Remove unnecessary parameters.

LEAHI-DD-FIRMWARE-LDT-3103-1 14 Jan 2026

Shouldn't this kind of function be in the pump controller unit? Assuming such functions already exist in the controller, so why do we need these?

LEAHI-APPLICATION-LDT-2805-1 16 Jan 2026

Updated.

LEAHI-APPLICATION-LDT-2805-1 16 Jan 2026

Updated.

LEAHI-APPLICATION-LDT-2805-1 16 Jan 2026

Updated.

BOOTLOADER-LEAH-1415-1 16 Jan 2026

This was imported from Sunrise. At the moment it is not needed.

BOOTLOADER-LEAH-1415-1 16 Jan 2026

Done

BOOTLOADER-LEAH-1415-1 16 Jan 2026

Done

BOOTLOADER-LEAH-1415-1 16 Jan 2026

Test code is still used for debugging.

BOOTLOADER-LEAH-1415-1 16 Jan 2026

Done

BOOTLOADER-LEAH-1415-1 16 Jan 2026

In the new branch.

BOOTLOADER-LEAH-1415-1 16 Jan 2026

It will implemented in the new branch.

BOOTLOADER-LEAH-1415-1 16 Jan 2026

In the new branch.

BOOTLOADER-LEAH-1415-1 16 Jan 2026

Test code is still used for debugging.

BOOTLOADER-LEAH-1415-1 16 Jan 2026

Test code is still used for debugging.

BOOTLOADER-LEAH-1415-1 16 Jan 2026

Test code is still used for debugging.

BOOTLOADER-LEAH-1415-1 16 Jan 2026

This function does not need a state machine.

BOOTLOADER-LEAH-1415-1 16 Jan 2026

Done

BOOTLOADER-LEAH-1415-1 16 Jan 2026

Done

BOOTLOADER-LEAH-1415-1 17 Jan 2026

Done

BOOTLOADER-LEAH-1415-1 17 Jan 2026

Done

BOOTLOADER-LEAH-1415-1 17 Jan 2026

They are in common.h

BOOTLOADER-LEAH-1415-1 17 Jan 2026

Done

BOOTLOADER-LEAH-1415-1 17 Jan 2026

Done

BOOTLOADER-LEAH-1415-1 17 Jan 2026

I will implement the watchdog in the new branch.

BOOTLOADER-LEAH-1415-1 17 Jan 2026

I will implement the watchdog in the new branch.

BOOTLOADER-LEAH-1415-1 17 Jan 2026

Done

BOOTLOADER-LEAH-1415-1 17 Jan 2026

Added the return.

BOOTLOADER-LEAH-1415-1 17 Jan 2026

Removed the interrupt.

BOOTLOADER-LEAH-1415-1 17 Jan 2026

Done

BOOTLOADER-LEAH-1415-1 17 Jan 2026

Done

BOOTLOADER-LEAH-1415-1 17 Jan 2026

Added the return of a value.

BOOTLOADER-LEAH-1415-1 17 Jan 2026

The new update request is checked on top of the mode update exec function. If there is a new update, it will request a transition otherwise, this is a terminal state.

BOOTLOADER-LEAH-1415-1 17 Jan 2026

It is the update mode re-initialized. The initialization is done using other functions that have their own doxygen comments. Do I need to add more here?

BOOTLOADER-LEAH-1415-1 17 Jan 2026

Done

BOOTLOADER-LEAH-1415-1 17 Jan 2026

Removed the TODO.

BOOTLOADER-LEAH-1415-1 17 Jan 2026

Removed the variable.

BOOTLOADER-LEAH-1415-1 17 Jan 2026

Done

BOOTLOADER-LEAH-1415-1 17 Jan 2026

Done

BOOTLOADER-LEAH-1415-1 17 Jan 2026

Done

BOOTLOADER-LEAH-1415-1 17 Jan 2026

Done

BOOTLOADER-LEAH-1415-1 17 Jan 2026

It will be implemented in the new branch.