•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-TD-FIRMWARE-LDT-3126-1 09 Jan 2026

I believe this function only takes 1 param in Leahi.

LEAHI-TESTSUITES-LDT-2174-1 13 Jan 2026

only need to select one. We do not need to test pressing every selection.

LEAHI-DD-FIRMWARE-LDT-2801-1 06 Jan 2026

The first function: void setFPGAD79RinsePumpControl( U08 value ) is for ON/OFF only. Once PWM is implemented, it will be removed.

LEAHI-APPLICATION-LDT-2805-1 06 Jan 2026

Updated.

LEAHI-DD-FIRMWARE-LDT-2185-1 13 Jan 2026

Updated

LEAHI-DD-FIRMWARE-LDT-2185-1 09 Jan 2026

I think this should not be in test support functions

LEAHI-APPLICATION-LDT-2805-1 06 Jan 2026

This change clamps tValue between [min, max].
For example, given value=2, min=5, max=10, step=1 and increment is called, without this change value will be incremented to 3 (still outside [min, max]), with this change value will be incremented to 5, pulling it into the valid range.

More comments have been added for clarity.

LEAHI-APPLICATION-LDT-2805-1 05 Jan 2026

Switch all adjustment_ReasonText back to text().

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

done

LEAHI-DIALIN-LDT-2998-1 08 Jan 2026

Renamed

LEAHI-APPLICATION-LDT-2805-1 08 Jan 2026

Updated.

LEAHI-DD-FIRMWARE-LDT-2801-1 08 Jan 2026

Not what I mean. I mean lines 174 and 193 are identical copies.

LEAHI-APPLICATION-LDT-3139-1 09 Jan 2026

going to leave as is. Next story I make further updates to this

LEAHI-APPLICATION-LDT-3139-1 09 Jan 2026

updated

LEAHI-DD-FIRMWARE-LDT-2185-1 09 Jan 2026

Yes correct. I fixed it

LEAHI-DD-FIRMWARE-LDT-2185-1 09 Jan 2026

fixed it

LEAHI-DD-FIRMWARE-LDT-2185-1 14 Jan 2026

Added the missing messages

LEAHI-DD-FIRMWARE-LDT-2185-1 14 Jan 2026

need to mention the sensor name in the comment

LEAHI-DD-FIRMWARE-LDT-2185-1 14 Jan 2026

defeatured override missing

LEAHI-TD-FIRMWARE-LDT-3126-1 09 Jan 2026

Add a details line for Message Sent for the broadcast data message.

LEAHI-APPLICATION-LDT-2805-1 06 Jan 2026

Update dialog size to make it larger.

LEAHI-APPLICATION-LDT-3139-1 15 Jan 2026

updated

LEAHI-TD-FIRMWARE-LDT-3126-1 15 Jan 2026

Updated

LEAHI-TD-FIRMWARE-LDT-3126-1 15 Jan 2026

Just 2 messages here. See comment from MsgDefs.h.

LEAHI-TD-FIRMWARE-LDT-3126-1 09 Jan 2026

Change BloodPrime to StateTxBloodPrime here too.

LEAHI-DD-FIRMWARE-LDT-3103-1 14 Jan 2026

Is this an initial guess for pump control?

LEAHI-DD-FIRMWARE-LDT-2998-1 06 Jan 2026

I think 50 samples is the max, so this is fine. Please remove the TODO comment.

LEAHI-APPLICATION-LDT-2805-1 06 Jan 2026

Updated.

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

done

LEAHI-TESTSUITES-LDT-2278-1 07 Jan 2026

Updated the test report in jira

LEAHI-DD-FIRMWARE-LDT-2998-1 05 Jan 2026

A comment in filter function suggests this is not a fixed sample size for D4.

LEAHI-DD-FIRMWARE-LDT-2185-1 15 Jan 2026

removed

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

changed.

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

done.

LEAHI-DD-FIRMWARE-LDT-2185-1 09 Jan 2026

This is retained for future use. This function check two temperatures, whereas above function checkInletTemperature only check one temperature D1 or P10.

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

removed

LEAHI-APPLICATION-LDT-2805-1 07 Jan 2026

Computations for ranged values have been moved to RangedValues.qml so it can be reused in other places as well.

LEAHI-APPLICATION-LDT-2805-1 07 Jan 2026

Computations for ranged values have been moved to RangedValues.qml so it can be reused in other places as well.

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

General note: please remove the commented line after testing.

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

Remove the commented line.

LEAHI-DD-FIRMWARE-LDT-2801-1 08 Jan 2026

It is speed as pulse width modulation.

LEAHI-DIALIN-LDT-2998-1 08 Jan 2026

Merged FP into DD test configs

LEAHI-APPLICATION-LDT-2805-1 08 Jan 2026

Updated.

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

We should always include the s/w fault ID and a supporting data (in this case, maybe cmd) with s/w fault alarms.

LEAHI-DD-FIRMWARE-LDT-2185-1 09 Jan 2026

fixed

LEAHI-DD-FIRMWARE-LDT-2801-1 09 Jan 2026

Done

LEAHI-DD-FIRMWARE-LDT-2185-1 13 Jan 2026

Updated

LEAHI-DD-FIRMWARE-LDT-2185-1 13 Jan 2026

Reverted

LEAHI-DD-FIRMWARE-LDT-2185-1 09 Jan 2026

not temperatureM3 it's D1

LEAHI-DD-FIRMWARE-LDT-2185-1 13 Jan 2026

Needed in future