Comment Search

documentation error- is it transition start time ?

The public function name signalGoToInstallState is not sufficiently descriptive. Would renaming it to requestTubeSetInstall() be appropriate?

This doesn't seem to be correct. Persistence should start once fill complete pressure is achieved, not after D65 opening?

updated

updated to now change result to FALSE if we get a rr that is not NONE

Changed TD Opmode from Standy state to Treatment state

this method removed but updated elsewhere

remove this file and port anything needed into config.py for consistency just like we are doing in http://devapps.diality.us:8060/cru/LEAHI-TESTSUITES-LDT-1650-1

#ifdef

For signals and slots as we tlaked use blocks of

onSomething: {
   aFunctionCall()
}

Unless there are multiple similar calls that need alignment in one line.

Align '_', and '=' please.

Add the comments for coefficients. bring a top-level comment explaining the formula where these coefficients are being used.

I thought we made the 3000 timeout the default value and need to be set unless it is different.
Please correct me if that is fixed on another branch.

assigned 0.0F as per sameer's suggestion

Add rinsebackPublishTimerCtr to outputs

use uniform naming convention. All other places used conductivity

Separate models in separate classes headerbar and water sample

Is this defined elsewhere? We shouldn't define this in multiple places. I think it should be in one header file - maybe balancing chamber controller.

Why do we need to remove this?

please align imports.

add a space between message and )

I have deleted strings.py file from Bitbucket branch feature/LDT-1650-headerbar-information

updated

BN Appprvoes

BN Appprvoes