•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-3103-1 15 Jan 2026

changed the name to differentiate between driver level and controller level functions.

LEAHI-APPLICATION-LDT-2805-1 05 Jan 2026

Double check duration confirmation message length.

LEAHI-APPLICATION-LDT-2805-1 06 Jan 2026

Updated.

LEAHI-APPLICATION-LDT-2805-1 05 Jan 2026

Verify that both lines are required.
Add comment if they are.

LEAHI-TESTSUITES-LDT-2278-1 07 Jan 2026

Updated the test cases as per your suggestion

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

done

LEAHI-TESTSUITES-LDT-1454-1 09 Jan 2026

test report has been uploaded in Jira

LEAHI-TD-FIRMWARE-LDT-3126-1 05 Jan 2026

These are Denali valves. We need to set all Leahi TD actuators here as appropriate. This will eventually be specified by system arch document in JAMA if it's not already. If not yet, let's do the following:
H1 valve = position B
H19 valve = position B
H4 (blood pump) = On (ramping to target rate)
H12/H13/H20 = Auto Air Trap Level Control (done with call to startAirTrapControl() function).
H10 = Off
H5 (ejector) = off (retracted)

LEAHI-TD-FIRMWARE-LDT-3126-1 05 Jan 2026

These overrides need to be updated to Leahi style (returns BOOL, takes message as param, is called by message handler, new Dialin message ID needed for override message, set/reset are merged into single message handling function, etc...).

LEAHI-DD-FIRMWARE-LDT-2185-1 13 Jan 2026

is there two space required ?

LEAHI-DD-FIRMWARE-LDT-2185-1 13 Jan 2026

can we remove it ?

LEAHI-TESTSUITES-LDT-2278-1 14 Jan 2026

verify_vitals_pop_up_is_opened_automatically_after_an_interval need to be placed before checking the request in test.verify(waitFor("'vitalsrequest == True'", 1000), "UI Sending the request to FW")

LEAHI-APPLICATION-LDT-3139-1 15 Jan 2026

updated

LEAHI-DD-FIRMWARE-LDT-2185-1 14 Jan 2026

Calculated is mis-spelled.

LEAHI-DD-FIRMWARE-LDT-2185-1 14 Jan 2026

Message handling functions must take a message as parameter (i.e. prototype of function should look like BOOL funcName( MESSAGE_T *message );

LEAHI-TD-FIRMWARE-LDT-3126-1 15 Jan 2026

Added

LEAHI-TESTSUITES-LDT-2174-1 13 Jan 2026

can we change this to 120 to minimize time

LEAHI-TESTSUITES-LDT-2174-1 13 Jan 2026

change to 120

LEAHI-APPLICATION-LDT-3139-1 15 Jan 2026
  1. "Title" = <Title string>
LEAHI-DD-FIRMWARE-LDT-2185-1 15 Jan 2026

Added struct packing

LEAHI-DD-FIRMWARE-LDT-2185-1 15 Jan 2026

This structure is for message payload. There is nothing to pack in this specific structure, but I think we should be in the habit of packing ALL payload structures in case a future structure change does require packing.

LEAHI-APPLICATION-LDT-2805-1 05 Jan 2026

Add comment for change.

LEAHI-TD-FIRMWARE-LDT-3126-1 15 Jan 2026

Combine set/reset for the 2 override functions. And use the helper functions in TestSupport.h (like over override handling functions do). f32Override() for the prime volume override and u32BroadcastIntervalOverride() for the broadcast interval override.

LEAHI-APPLICATION-LDT-2805-1 05 Jan 2026

Change to use "-- --" from Variables.
Check if View is setting default value.

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

removed.

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

removed all.

LEAHI-DD-FIRMWARE-LDT-3103-1 15 Jan 2026

done.

LEAHI-APPLICATION-LDT-2805-1 06 Jan 2026

Put example in comment.

LEAHI-TD-FIRMWARE-LDT-3126-1 09 Jan 2026

Changed

LEAHI-TD-FIRMWARE-LDT-3126-1 05 Jan 2026

We do need to bring blood prime sub-mode into treatment mode (integrate). So signals that blood is primed and it's time to transition from blood prime to dialysis are needed.
Treatment mode needs to be updated to include blood prime as a state (the first) in the treatment mode state machine and that state needs to call the exec function in this BloodPrime unit.

LEAHI-DD-FIRMWARE-LDT-2185-1 09 Jan 2026

temperatureD1

LEAHI-DD-FIRMWARE-LDT-2185-1 14 Jan 2026

Added

LEAHI-DD-FIRMWARE-LDT-2185-1 14 Jan 2026

Moved

LEAHI-DD-FIRMWARE-LDT-2185-1 08 Jan 2026

Are we really allowed to skip pre-gen mode?

LEAHI-APPLICATION-LDT-3139-1 08 Jan 2026

update comments for new design

LEAHI-DIALIN-LDT-3214-1 12 Jan 2026

Why move this here? Seems like an odd placement so far away from D14.

LEAHI-DD-FIRMWARE-LDT-2801-1 09 Jan 2026

Ok they were declared twice. Done.

LEAHI-APPLICATION-LDT-2805-1 06 Jan 2026

This is correct. Comment has been updated to match code.

LEAHI-APPLICATION-LDT-2805-1 05 Jan 2026

Remove 'edit'

LEAHI-DD-FIRMWARE-LDT-2185-1 12 Jan 2026

Updated

LEAHI-DIALIN-LDT-3214-1 12 Jan 2026

Putting the aliases at the end makes them grouped up and in my opinion makes easier reading of the enum.

LEAHI-DD-FIRMWARE-LDT-2185-1 14 Jan 2026

Added

LEAHI-DIALIN-LDT-2998-1 08 Jan 2026

Vinayakam Mani What is the advantage of doing that?
If I go with Beta_1_9_HW, I will need to rename the flag when we start using Beta 2+. And rename it in all the scripts in different repository when starting with 2.0.
While I use a more generic flag, I won't need to do that. So just using a better name I am sparing myself hours of work in the future.

LEAHI-DIALIN-LDT-2998-1 08 Jan 2026

Added enum to FP and TD Configs.

LEAHI-DD-FIRMWARE-LDT-2185-1 14 Jan 2026

Fixed

LEAHI-DD-FIRMWARE-LDT-2801-1 08 Jan 2026

Then the FPGA get function seems mis-named. Pulse width is not really the same as speed. It is the inverse of frequency, which can be converted to speed.

LEAHI-DD-FIRMWARE-LDT-3103-1 15 Jan 2026

We handle it in the checkSpentFillComplete() mentioned in line 946.

LEAHI-DD-FIRMWARE-LDT-3103-1 14 Jan 2026

Add spaces before/after +=.

LEAHI-DD-FIRMWARE-LDT-3103-1 14 Jan 2026

Where is the closed loop control?

LEAHI-DD-FIRMWARE-LDT-3103-1 14 Jan 2026

Why are we adjusting/reducing the speed of D48 by a factor of 50%?