•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-TD-FIRMWARE-LDT-1886-2 05 May 2026

Add a detail for Message Sent for the broadcast data message.

LEAHI-TD-FIRMWARE-LDT-1886-2 06 May 2026

Treatment mode will also need one of these (later). Should we add PreTx to the function name to differentiate?

LEAHI-TD-FIRMWARE-LDT-2240-1 07 May 2026

Updated

LEAHI-TD-FIRMWARE-LDT-2240-1 07 May 2026

Added

LEAHI-TD-FIRMWARE-LDT-2240-1 07 May 2026

Removed

LEAHI-APPLICATION-LDT-3932-1 05 May 2026

remove commented out line

LEAHI-DIALIN-LDT-3505-1 07 May 2026

Please remove for the above reasons.

LEAHI-DD-FIRMWARE-LDT-3963-1 05 May 2026

Remove this condition to apply the speed for BC switch only as well.

LEAHI-DIALIN-LDT-3505-1 07 May 2026

please use the generic_override function from the common folder

LEAHI-TD-FIRMWARE-LDT-3970-1 06 May 2026

I think validated variable here should be L/Hr and assigned to response.ufRate so that when we get confirmation, we can compare rates with same units.

TD-LDT-1886-7 07 Nov 2025

Done

LEAHI-TESTSUITES-LDT-3153-1 28 Apr 2026

RESOLVED.

LEAHI-DD-FIRMWARE-LDT-3963-1 08 May 2026

We shouldn't require something to be defined to do the right thing. We should require something to be defined to do the wrong thing (i.e. this should say #ifndef _BAD_MSG_CRC_ALARM_DISABLED_)
And then, we don't need a TODO. These #defines are only possible in DEBUG builds. A RELEASE build will never allow thing build flags to disable things.

LEAHI-DD-FIRMWARE-LDT-2662-1 12 Nov 2025

Ok, but see my next comment below. Do we need to ACK with a result at all? Does TD require this?

LEAHI-DD-FIRMWARE-LDT-3980-1 29 Apr 2026

Initialize the 'dryBicartPersistantStartTime' back to zero after timeout done, for the next iterations.

LEAHI-APPLICATION-LDT-2727-1 13 Nov 2025

updated

LEAHI-APPLICATION-LDT-2727-1 13 Nov 2025

updated

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

Why did the logic change?
The order should be to fill in the first column, then go to the next, and it should not be by row.

LEAHI-DD-FIRMWARE-LDT-4188-1 30 Apr 2026

Idea is to have this in institutional records we implement it

LEAHI-DD-FIRMWARE-LDT-4188-1 30 Apr 2026

If this is const, how will user add conversions (after 3rd value)?

LEAHI-DD-FIRMWARE-LDT-3978-1 30 Apr 2026

Is this time out after D80 opening or D65 closing state? if it is D65 closed, you need to start the timer after D65 closing.

LEAHI-TD-FIRMWARE-LDT-4188-1 30 Apr 2026

This is not a Dialin message, so move up above all of these "test" functions.

LEAHI-APPLICATION-LDT-3932-1 06 May 2026

removed demo code

LEAHI-TD-FIRMWARE-LDT-1886-2 05 May 2026

create local Bool

LEAHI-TD-FIRMWARE-LDT-1886-2 05 May 2026

Add a detail for Message Sent for the broadcast data message.

LEAHI-TD-FIRMWARE-LDT-1886-2 05 May 2026

Change // to /// for doxygen to catch it.

LEAHI-TD-FIRMWARE-LDT-1886-2 03 May 2026

Should not change states in a signal function. Should set a request flag that gets looked at in dry self-tests state handler function which would return install state if the flag is set.

LEAHI-TD-FIRMWARE-LDT-1886-2 03 May 2026

Remove unnecessary spaces before =

LEAHI-TD-FIRMWARE-LDT-2240-1 07 May 2026

Added

LEAHI-TD-FIRMWARE-LDT-3970-1 11 May 2026

Delete extra line

LEAHI-TD-FIRMWARE-LDT-2240-1 05 May 2026

DrySelfTests

LEAHI-TD-FIRMWARE-LDT-2240-1 05 May 2026

Put this stuff in transition function for this state. Remove venousSetupStateEntered flag.

LEAHI-TD-FIRMWARE-LDT-2240-1 05 May 2026

Remove if statement. Always set valve to pos A.

LEAHI-APPLICATION-LDT-4161-1 07 May 2026

udpated

LEAHI-APPLICATION-LDT-3932-1 05 May 2026

remove

LEAHI-APPLICATION-LDT-3932-1 07 May 2026

BN APPROVES

LEAHI-APPLICATION-LDT-4161-1 05 May 2026

what is currently wtitten in the log

LEAHI-APPLICATION-LDT-4193-1 07 May 2026

add to Colors

LEAHI-APPLICATION-LDT-4193-1 07 May 2026

add to Colors

LEAHI-APPLICATION-LDT-4193-1 07 May 2026

Add RO loop updates!

LEAHI-TD-FIRMWARE-LDT-4149-1 27 Jul 2026

Move this to right before syringe pump controller below. Add comment "Execute pinch valve command state machine."

LEAHI-DD-FIRMWARE-LDT-3735-1 23 Jul 2026

If a retry goes wrong will you trigger an alarm?

LEAHI-DD-FIRMWARE-LDT-4410-3 27 Jul 2026

Is issue resolved? Can we revert now?

LEAHI-TD-FIRMWARE-LDT-4031-1 28 Jul 2026

should we replace current Pre-Treatment state with currentPreTreatmentState?

LEAHI-DD-FIRMWARE-LDT-4049-1 27 Jul 2026

I would recommend commenting the stopping D108 heater here, as there is no implementation yet at driver level. Add a TODO comment for now.

TD-LDT-1886-7 07 Nov 2025

Done

TD-LDT-1886-7 10 Nov 2025

Done

TD-LDT-1886-7 10 Nov 2025

Done

LEAHI-TD-FIRMWARE-LDT-1886-2 03 May 2026

Align =.

LEAHI-SW-SCRIPTS-LDT-2727-1 13 Nov 2025

added the checks and graceful exit