•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-2998-1 05 Jan 2026

Please introduce the test config for Beta1.9 changes across the files. This helps to continue work on Beta1.0 system without any issues.

LEAHI-APPLICATION-LDT-2805-1 05 Jan 2026

Correct comment for all Rsp messages.

LEAHI-APPLICATION-LDT-2805-1 05 Jan 2026

Make component a standalone file.

LEAHI-TESTSUITES-LDT-1454-1 07 Jan 2026

removed the object

LEAHI-DD-FIRMWARE-LDT-3159-1 15 Jan 2026

Fix return description. This function is not setting anything. Should be something like TRUE if request handled successfully.

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

changed.

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

done. changed.

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

Define the variable at the top of the function.

LEAHI-DIALIN-LDT-2998-1 07 Jan 2026

POS_FIELD_3??

LEAHI-APPLICATION-LDT-2805-1 08 Jan 2026

Updated.

LEAHI-APPLICATION-LDT-2805-1 08 Jan 2026

Updated.

LEAHI-DD-FIRMWARE-LDT-2030-2 11 Jan 2026

Well now you're using cmdSpec and I don't see where it's declared. Does this compile now?

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

Should only have one exit for a function at end of function (per our coding standards).

LEAHI-DD-FIRMWARE-LDT-2185-1 13 Jan 2026

Updated

LEAHI-DD-FIRMWARE-LDT-2185-1 09 Jan 2026

This has to be updated or removed

LEAHI-DD-FIRMWARE-LDT-2185-1 14 Jan 2026

Missing message param.

LEAHI-DD-FIRMWARE-LDT-2185-1 15 Jan 2026

added param and output

LEAHI-DD-FIRMWARE-LDT-3103-1 15 Jan 2026

Yes. will tune them based on the test results.

LEAHI-APPLICATION-LDT-2805-1 05 Jan 2026

Add comments why computation is being done.

LEAHI-APPLICATION-LDT-2805-1 15 Jan 2026

Update to TD.

LEAHI-TESTSUITES-LDT-2278-1 14 Jan 2026

this should be removed. We need to wait for UI to send the request. Here you are manually sending the request where the timer does not countdown to 0 to send it.

LEAHI-TD-FIRMWARE-LDT-3126-1 15 Jan 2026

Removed and updated

LEAHI-DD-FIRMWARE-LDT-2998-1 06 Jan 2026

Updated

LEAHI-TD-FIRMWARE-LDT-3126-1 09 Jan 2026

I don't see these override message handler functions being added to table in Messages.c. And I don't see new Dialin message IDs added to enum in MsgDefs.h.

LEAHI-DD-FIRMWARE-LDT-2998-1 06 Jan 2026

D99 has been updated using the same approach applied to the D4 temperature.

LEAHI-APPLICATION-LDT-2805-1 06 Jan 2026

Updated.

LEAHI-APPLICATION-LDT-2805-1 08 Jan 2026

Updated.

LEAHI-APPLICATION-LDT-2805-1 05 Jan 2026

Use new standalone component taken from Confirm.

LEAHI-APPLICATION-LDT-3139-1 08 Jan 2026

make a Variable for this

LEAHI-TD-FIRMWARE-LDT-3126-1 09 Jan 2026

Updated

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

Add blank line between declaration and code.

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

Keep 2 blank lines around test support banner.

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

Not a fan of statements in declarations section.

LEAHI-TESTSUITES-LDT-1454-1 06 Jan 2026

Ultrafiltration is one work same as in lines 127 and 133

LEAHI-TD-FIRMWARE-LDT-3126-1 14 Jan 2026

Changed

LEAHI-DD-FIRMWARE-LDT-2185-1 14 Jan 2026

Remove extra blank line.

LEAHI-APPLICATION-LDT-2805-1 06 Jan 2026

Fix numbering.

LEAHI-APPLICATION-LDT-3139-1 08 Jan 2026

comment explaining margin

LEAHI-TESTSUITES-LDT-2174-1 13 Jan 2026

Update for all the combo boxes to just select one

LEAHI-TESTSUITES-LDT-1454-1 06 Jan 2026

For rejection text when/if we do test with translations I do not think we should hard code the rejection in English. We can read the Rejections.conf and store the data in some sort of map to get the correct rejection string... In the config repository configurationjs > Alarms > Rejections.conf is the file we can read and store for later use for all other test cases as well.

LEAHI-APPLICATION-LDT-2805-1 05 Jan 2026

Use "-- --" from Variables.

LEAHI-DD-FIRMWARE-LDT-2185-1 13 Jan 2026

can we remove it ?

LEAHI-TESTSUITES-LDT-2174-1 09 Jan 2026

Removed the min and max values and kept only Heparin Dispensing Rate

LEAHI-DD-FIRMWARE-LDT-2185-1 09 Jan 2026

fixed it

LEAHI-TD-FIRMWARE-LDT-3126-1 09 Jan 2026

Updated

LEAHI-TD-FIRMWARE-LDT-3126-1 09 Jan 2026

Removed

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

Remove extra blank line.

LEAHI-TD-FIRMWARE-LDT-3126-1 14 Jan 2026

Updated

LEAHI-TD-FIRMWARE-LDT-3126-1 14 Jan 2026

Updated

LEAHI-TD-FIRMWARE-LDT-3126-1 14 Jan 2026

Added