•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-2185-1 13 Jan 2026

Used to match with prev naming convention and also low and high temperature limits are checked here

LEAHI-DD-FIRMWARE-LDT-2185-1 14 Jan 2026

Added

LEAHI-TD-FIRMWARE-LDT-3126-1 14 Jan 2026

Removed

LEAHI-DD-FIRMWARE-LDT-2185-1 14 Jan 2026

I don't see fix. I'm resolving this comment, but I added another comment that hopefully clarifies the issue.

LEAHI-APPLICATION-LDT-2805-1 15 Jan 2026

Move registration back to VView.h

LEAHI-DD-FIRMWARE-LDT-2185-1 15 Jan 2026

Update function header to include message param.

LEAHI-DD-FIRMWARE-LDT-3103-1 13 Jan 2026

Why are we checking only fresh side pressures and not spent side as well?

LEAHI-DD-FIRMWARE-LDT-3159-1 15 Jan 2026

Fix comment.

LEAHI-APPLICATION-LDT-3139-1 08 Jan 2026

make format for advanced in Vsettings

LEAHI-APPLICATION-LDT-3139-1 08 Jan 2026

coment with current resolution this make the screen look nice

LEAHI-TD-FIRMWARE-LDT-3126-1 15 Jan 2026

Added

LEAHI-TD-FIRMWARE-LDT-3126-1 15 Jan 2026

Remove reset override functions. Reset should be handled in the single (general) override command handler.

LEAHI-APPLICATION-LDT-2805-1 06 Jan 2026

do you need to also register the following that are imported in main.qml?

VTreatmentAdjustmentBolusVolume
VTreatmentAdjustmentDurationEdit
VTreatmentAdjustmentDurationConfirm
VTreatmentAdjustmentSetPoints
VTreatmentAdjustmentBloodFlowRate
VTreatmentAdjustmentDialysateFlowRate
VTreatmentAdjustmentDialysateTemperature

LEAHI-APPLICATION-LDT-2805-1 06 Jan 2026

Properties are being set to zero by default.

LEAHI-APPLICATION-LDT-2805-1 06 Jan 2026

Updated.

LEAHI-TESTSUITES-LDT-1454-1 07 Jan 2026

changed this Ultrafiltration in one line

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

done

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

followed the pattern.

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

If there are no messages from the BloodLeak.h then we should remove the include.

LEAHI-DIALIN-LDT-2998-1 08 Jan 2026

Fixed

LEAHI-TESTSUITES-LDT-1454-1 09 Jan 2026

Updated the test scripts as per the suggestion

LEAHI-APPLICATION-LDT-3139-1 09 Jan 2026

added comment

LEAHI-DD-FIRMWARE-LDT-2185-1 09 Jan 2026

fixed it

LEAHI-TD-FIRMWARE-LDT-3126-1 09 Jan 2026

Added

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

Add space between (( and )).

LEAHI-DD-FIRMWARE-LDT-2185-1 13 Jan 2026

Fixed

LEAHI-TESTSUITES-LDT-1454-1 06 Jan 2026

spelling error should be "title"

LEAHI-DD-FIRMWARE-LDT-3159-1 15 Jan 2026

Fixed

LEAHI-TESTSUITES-LDT-2174-1 16 Jan 2026

Updated the value to all combo boxes

LEAHI-TESTSUITES-LDT-2174-1 16 Jan 2026

Updated the value to 120

LEAHI-TD-FIRMWARE-LDT-3126-1 15 Jan 2026

Only need 2 message IDs here. In Leahi, we don't have separate messages for set vs. reset. Both set and reset are handled in the same message.

LEAHI-TD-FIRMWARE-LDT-3126-1 15 Jan 2026

Remove "Set" from override function names. These 2 override functions should handle both set and reset (from msg payload).

LEAHI-APPLICATION-LDT-2805-1 06 Jan 2026

View still exists, instance has been moved to main.qml

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

changed.

LEAHI-APPLICATION-LDT-2805-1 08 Jan 2026

Updated.

LEAHI-DD-FIRMWARE-LDT-2185-1 09 Jan 2026

fixed it

LEAHI-DD-FIRMWARE-LDT-2185-1 13 Jan 2026

Updated

LEAHI-DD-FIRMWARE-LDT-2185-1 14 Jan 2026

M3 or P10 ? need a good documentation

LEAHI-DD-FIRMWARE-LDT-2185-1 14 Jan 2026

sensor name required in comments

LEAHI-DD-FIRMWARE-LDT-2185-1 14 Jan 2026

If this function is only called from here, should we just move the function's code into this function (i.e. combine the functions)?

LEAHI-APPLICATION-LDT-2805-1 15 Jan 2026

Update to TD.

LEAHI-TESTSUITES-LDT-1802-1 13 Jan 2026

lets reduce this to 3. we do not need to test this many variations

LEAHI-TESTSUITES-LDT-1802-1 13 Jan 2026

reduce this to 3 variations as well

LEAHI-DD-FIRMWARE-LDT-3103-1 14 Jan 2026

I thought we were going to complete cycle when done (not based on time) and feed back error in cycle time to control D48 pump speed to reduce error going forward so we end up getting the target cycle time which will give us target flow rate.

LEAHI-TESTSUITES-LDT-2278-1 14 Jan 2026

can we change to just click the arrow button just once as we do not care about what is being set. We only care about the bp measurement parameter

LEAHI-DD-FIRMWARE-LDT-2998-1 05 Jan 2026

With exception of D4 temperature, is there any reason why all other temperatures shouldn't be filtered the same way?

BOOTLOADER-LEAH-1415-1 16 Jan 2026

This is still used. It will be removed in the new branch.

LEAHI-TD-FIRMWARE-LDT-3126-1 09 Jan 2026

It looks like it's still here.

LEAHI-DD-FIRMWARE-LDT-2185-1 09 Jan 2026

Is this line expected here?