•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-TD-FIRMWARE-LDT-4031-1 28 Jul 2026

break this line

LEAHI-TD-FIRMWARE-LDT-2240-1 12 May 2026

Updated

LEAHI-DIALIN-LDT-3505-1 07 May 2026

please use the generic_override function from the common folder

LEAHI-DIALIN-LDT-3505-1 07 May 2026

Please remove for the above reasons.

LEAHI-TD-FIRMWARE-LDT-2240-1 05 May 2026

move to a private publish function.

LEAHI-TD-FIRMWARE-LDT-4031-1 27 Jul 2026

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-4410-3 27 Jul 2026

updated

LEAHI-TD-FIRMWARE-LDT-4029-1 28 Jul 2026

Align all the function comments

LEAHI-TD-FIRMWARE-LDT-4029-1 28 Jul 2026

add an empty else block after the last else if block in these functions
handlePreTxHeparinPreloadState
handlePreTxHeparinAwaitSyringeLoadConfirmationState
handlePreTxHeparinSeekState
handlePreTxHeparinPrimeState
handlePreTxHeparinBolusState

TD-LDT-1886-7 08 Nov 2025

Done

TD-LDT-1886-7 10 Nov 2025

I don't see this input used in function.

LEAHI-DIALIN-LDT-3505-1 07 May 2026

please use the generic_override function from the common folder

LEAHI-DIALIN-LDT-3505-1 07 May 2026

This is a duplicate, the heparin_state can be accessed directly, there is no need for a wrapper function for it, so please remove.

LEAHI-TESTSUITES-LDT-1650-1 10 Nov 2025

​Now I have added all constants in config.py and removed import of strings.py

LEAHI-TD-FIRMWARE-LDT-2240-1 05 May 2026

Not a CAN msg to UI. It's a command to barcode reader via fpga. Not implement yet, so TODO comment.

LEAHI-TESTSUITES-LDT-2174-1 11 Nov 2025

Added function to test slider function

LEAHI-TESTSUITES-LDT-1650-1 06 Nov 2025

since this is not in line with the latest staging the utility.py is not in the test suite so please add

LEAHI-DD-FIRMWARE-LDT-3978-1 28 Apr 2026

Can we check payload.index is equal to D6_LEVL (instead of above comparision)?

LEAHI-APPLICATION-LDT-2712-1 12 Nov 2025

This CR is on an incorrectly created branch.
Will be continued on the LDT-2707

LEAHI-TD-FIRMWARE-LDT-1886-2 03 May 2026

Why are we doing this?
Having a return here is against our coding standards (it's like a goto).

LEAHI-TD-FIRMWARE-LDT-2240-1 05 May 2026

Needed?

LEAHI-TESTSUITES-LDT-2951-1 07 May 2026

what is this file for?

LEAHI-DD-FIRMWARE-LDT-2662-1 13 Nov 2025

I think so. the TD needs to know if we are successful in transitioning to PreGen for either the DD or the FP. Otherwise, TD is waiting for something else that'll never happen.

whether that should be a separate message response or ACK is up for discussion.

LEAHI-TESTSUITES-LDT-1078-1 11 Nov 2025

please update indentation

LEAHI-TD-FIRMWARE-LDT-2240-1 07 May 2026

Removed

LEAHI-APPLICATION-LDT-3932-1 07 May 2026

BN APPROVES

LEAHI-DIALIN-LDT-3505-1 07 May 2026

please use the generic_override function from the common folder

LEAHI-TD-FIRMWARE-LDT-4040-1 23 Jul 2026

Do we need the alarm?

LEAHI-TD-FIRMWARE-LDT-4040-1 23 Jul 2026

break this line

LEAHI-DD-FIRMWARE-LDT-4500-1 27 Jul 2026

keep a blank line between declaration(s) and code.

LEAHI-APPLICATION-LDT-5074-3 28 Jul 2026

add Ro water mode request data

LEAHI-DD-FIRMWARE-LDT-4410-3 27 Jul 2026

removed

LEAHI-DD-FIRMWARE-LDT-4410-3 27 Jul 2026

Remove leading space before void.

LEAHI-DIALIN-LDT-1886-1 08 Nov 2025

Done

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

😅 will add in the scripts repositor

LEAHI-TD-FIRMWARE-LDT-2240-1 05 May 2026

do 2 data with the p1 and p2 pressures.

LEAHI-TESTSUITES-LDT-3208-1 04 May 2026

In WaitForObjectExists we are not using any default timeout we are using it in different method

LEAHI-APPLICATION-LDT-4161-1 05 May 2026

make preceision last property

LEAHI-TESTSUITES-LDT-1078-1 12 Nov 2025

I have deleted strings.py file from Bitbucket branch feature/LDT-1078-Device-Settings-Information-Version

LEAHI-APPLICATION-LDT-2727-1 13 Nov 2025

This works. A few other qml files use this version of the import

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

IMPORTANT!!!
Please test this on the device.

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

Can you help me understand why we did not use the DeviceController attribute to call the datetime set script?
Or modify this function to use that design?

LEAHI-DD-FIRMWARE-LDT-2004-1 13 Nov 2025

Put in #ifdef.

LEAHI-TD-FIRMWARE-LDT-1886-2 03 May 2026

Why are we doing this?

LEAHI-TD-FIRMWARE-LDT-3970-1 06 May 2026

Same comment as duration confirmation. compare uf rate too.

LEAHI-DD-FIRMWARE-LDT-3978-1 30 Apr 2026

a time out for decaying D66 pressure to 3 PSI after D65 closed

LEAHI-APPLICATION-LDT-3932-1 05 May 2026

REOLVED

LEAHI-TD-FIRMWARE-LDT-4188-1 30 Apr 2026

I think DD (and TD) want mL/min and UI wants L/hr. TxParams should have already calculated this rate (in mL/min) and should probably have a get function you can call from here to access it. When sending UF rate to UI, we would convert back to L/hr first, but everywhere else we would work with mL/min.

LEAHI-TD-FIRMWARE-LDT-4188-1 30 Apr 2026

Are we assuming the sub mode return is pre-gen sub mode always?

LEAHI-APPLICATION-LDT-3932-1 06 May 2026

removed demo code