•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-3103-1 15 Jan 2026

Fixed it.

LEAHI-APPLICATION-LDT-2805-1 06 Jan 2026

Remove unnecessary parameters.

LEAHI-APPLICATION-LDT-2805-1 05 Jan 2026

Verify why the clamping is necessary.

LEAHI-APPLICATION-LDT-3139-1 08 Jan 2026

remove so we fit the exact image resoliution

LEAHI-TD-FIRMWARE-LDT-3126-1 15 Jan 2026

Removed and updated

LEAHI-APPLICATION-LDT-2805-1 06 Jan 2026

Updated.

LEAHI-APPLICATION-LDT-2805-1 05 Jan 2026

Verify what is being displayed for no value.

LEAHI-DD-FIRMWARE-LDT-2185-1 13 Jan 2026

We are not checking multiple temperatures here . Its only one temperature , eigther D1 or P10. in that case should remove the 's"

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

done

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

done.

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

Please follow the examples in the code like
if (cmd < num_cmd)

Unknown macro: { memcpy }

else

Unknown macro: { fault alarm }


We should make sure the command is valid and them memcpy next.

LEAHI-DIALIN-LDT-2998-1 07 Jan 2026

Please follow the same naming convention as firmware enums.

LEAHI-DIALIN-LDT-2998-1 07 Jan 2026

You may use the same test configs from DD here, to set the relevant test configs from FP Dialin.

LEAHI-APPLICATION-LDT-2805-1 08 Jan 2026

Updated.

LEAHI-DD-FIRMWARE-LDT-2801-1 09 Jan 2026

Done

LEAHI-TESTSUITES-LDT-2174-1 16 Jan 2026

Changed the value to 120

LEAHI-DD-FIRMWARE-LDT-2801-1 09 Jan 2026

It's Beta 1.9.

LEAHI-APPLICATION-LDT-3139-1 15 Jan 2026

add <> around placeholders

LEAHI-DD-FIRMWARE-LDT-2185-1 09 Jan 2026

This is a test support sub function.

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

Remove merge conflict line here.

LEAHI-DD-FIRMWARE-LDT-2185-1 09 Jan 2026

space after =

LEAHI-DD-FIRMWARE-LDT-2185-1 13 Jan 2026

can we remove it?

LEAHI-DD-FIRMWARE-LDT-2185-1 14 Jan 2026

Fixed

LEAHI-DD-FIRMWARE-LDT-2185-1 14 Jan 2026

Fixed

LEAHI-DD-FIRMWARE-LDT-2185-1 14 Jan 2026

Updated

LEAHI-DD-FIRMWARE-LDT-2185-1 14 Jan 2026

done

LEAHI-DD-FIRMWARE-LDT-2998-1 06 Jan 2026

Removed

LEAHI-APPLICATION-LDT-2805-1 05 Jan 2026

Check that View is renamed or removed.

LEAHI-APPLICATION-LDT-2805-1 08 Jan 2026

Updated.

LEAHI-APPLICATION-LDT-3139-1 09 Jan 2026

added comment

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

BloodLeakDriver

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

Remove blank line above this declaration and add a blank line below it.

LEAHI-DD-FIRMWARE-LDT-2030-2 12 Jan 2026

It is defined in line 937.

LEAHI-DD-FIRMWARE-LDT-2185-1 13 Jan 2026

Fixed

LEAHI-TD-FIRMWARE-LDT-3126-1 14 Jan 2026

Updated

LEAHI-TD-FIRMWARE-LDT-3126-1 14 Jan 2026

Added

LEAHI-TD-FIRMWARE-LDT-3126-1 09 Jan 2026

Function headers that we copy from Denali will not have some of the new formatting changes - make sure to update all of them to Leahi format (see from other units for example). In this case, there should be a \b before the type of details (Inputs and Outputs here) so they will be bold when documentation is generated.

LEAHI-DD-FIRMWARE-LDT-2998-1 06 Jan 2026

This should be before high, it feels wrong to have the order of 0,1,3,2 instead of 0,1,2,3 (Empty, Low, Medium, High)

LEAHI-TESTSUITES-LDT-1454-1 07 Jan 2026

change the spelling

LEAHI-TESTSUITES-LDT-2278-1 07 Jan 2026

Added as per the suggestion

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

done.

LEAHI-DD-FIRMWARE-LDT-2030-2 07 Jan 2026

changed

LEAHI-APPLICATION-LDT-3139-1 09 Jan 2026

added new comment

LEAHI-DD-FIRMWARE-LDT-2185-1 09 Jan 2026

Logic for this has to be updated

LEAHI-TESTSUITES-LDT-1454-1 06 Jan 2026

o_ultrafiltration_TittleText not being used.. remove

LEAHI-DD-FIRMWARE-LDT-2185-1 14 Jan 2026

I will move it

LEAHI-DD-FIRMWARE-LDT-2185-1 13 Jan 2026

This function seems to be a state specific function. in that case it should be handled in that file itself.

LEAHI-DD-FIRMWARE-LDT-3159-1 15 Jan 2026

Updated, Thanks

LEAHI-TD-FIRMWARE-LDT-3126-1 09 Jan 2026

This unit does not compile w/o errors - always build and check for errors before committing/pushing changes. At least one issue is that we need to include Valve3Way.h and I suspect other includes are missing as well (check bottom of compiler warnings list).