•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

Every time you use " * someValue ", please add a comment explaining why.
@100, @101, @102 as well.

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

Where in the design do you store the new password?

LEAHI-DD-FIRMWARE-LDT-2004-1 12 Nov 2025

Align the comments in fixed indentation throughout the file.

LEAHI-APPLICATION-LDT-3932-1 06 May 2026

removed demo code

LEAHI-TD-FIRMWARE-LDT-1886-2 05 May 2026

@details \b Inputs:

LEAHI-TD-FIRMWARE-LDT-1886-2 05 May 2026

Should go to your new complete state here.

LEAHI-APPLICATION-LDT-4161-1 07 May 2026

udpated

LEAHI-APPLICATION-LDT-3932-1 07 May 2026

BN APPROVES

LEAHI-APPLICATION-LDT-3932-1 07 May 2026

BN APPROVES

LEAHI-APPLICATION-LDT-3932-1 07 May 2026

BN APPROVES

LEAHI-APPLICATION-LDT-4161-1 07 May 2026

BN Appprvoes

LEAHI-APPLICATION-LDT-4161-1 07 May 2026

BN Appprvoes

LEAHI-TD-FIRMWARE-LDT-4149-1 27 Jul 2026

Comment these out again.

LEAHI-DD-FIRMWARE-LDT-4183-1 05 May 2026

Updates the comments for all new variables.

LEAHI-DIALIN-LDT-3505-1 07 May 2026

please use the generic_override function from the common folder

LEAHI-DIALIN-LDT-3505-1 07 May 2026

Please remove for the above reasons.

LEAHI-TD-FIRMWARE-LDT-2240-1 05 May 2026

don't need response to a response.

LEAHI-APPLICATION-LDT-4193-1 07 May 2026

lowercase ALL property names

LEAHI-TESTSUITES-LDT-3153-1 28 Apr 2026

Does Squish report the remaining tests as failed?
Also, it should stop all of the other tests too, because almost all the tests depend on the CANBus communication.

LEAHI-DD-FIRMWARE-LDT-4410-3 27 Jul 2026

No, it isn't. We are going to fault mode on that alarm and Vinay has asked me to comment it out as this needs further testing.

DIALIN-DENBUG-328-1 06 Nov 2025

I thought default was 5?

LEAHI-TESTSUITES-LDT-2174-1 07 Nov 2025

Removed all the objects which are not used in the treatment parameter and kept objects which are in staging

LEAHI-TESTSUITES-LDT-2174-1 07 Nov 2025

Removed the text properties in the object

TD-LDT-1886-7 08 Nov 2025

Done

LEAHI-APPLICATION-LDT-2727-1 10 Dec 2025

okay acknowledged

LEAHI-TD-FIRMWARE-LDT-4040-1 23 Jul 2026

Add fluidType to inputs

LEAHI-TD-FIRMWARE-LDT-4040-1 23 Jul 2026

break this line

LEAHI-DD-FIRMWARE-LDT-4049-1 27 Jul 2026

Align the indent. Replace RO to FP.

LEAHI-SW-SCRIPTS-LDT-2727-1 12 Nov 2025

Also, regarding the above format, each script needs to check whether a command fails and gracefully exit either way.

LEAHI-APPLICATION-LDT-2727-1 13 Nov 2025

changed to int

LEAHI-APPLICATION-LDT-2727-1 13 Nov 2025

updated logic so the grid view has an equal number of rows depending on the total number of visible items.

Before row count was hard coded to 6 so if there was ex. 8 items the left column would show 6 and the right 2.. Updated so the gridview will look as even as possible.

I hard coded the column to 2 columns since the design has 2 columns and added logic to the row count to make the 2 columns equal

LEAHI-APPLICATION-LDT-2727-1 13 Nov 2025

updated and added to fonts

LEAHI-DIALIN-LDT-3505-1 07 May 2026

Please remove for the above reasons.

LEAHI-SW-SCRIPTS-LDT-2727-1 13 Nov 2025

updated and checked and works. thank you

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

Fonts.qml

LEAHI-TD-FIRMWARE-LDT-2240-1 04 May 2026

Remove extra blank line.

LEAHI-TD-FIRMWARE-LDT-2240-1 07 May 2026

Yes, removed

LEAHI-APPLICATION-LDT-3932-1 07 May 2026

BN APPROVES

LEAHI-APPLICATION-LDT-3932-1 07 May 2026

BN APPROVES

LEAHI-APPLICATION-LDT-3932-1 07 May 2026

BN APPROVES

LEAHI-APPLICATION-LDT-3932-1 07 May 2026

BN APPROVES

LEAHI-TD-FIRMWARE-LDT-2240-1 05 May 2026

barcode scan request is made by TD to h/w via fpga. So not needed.

LEAHI-TD-FIRMWARE-LDT-2240-1 07 May 2026

Remove start state.

LEAHI-DD-FIRMWARE-LDT-3963-1 04 May 2026

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

LEAHI-TESTSUITES-LDT-3208-1 28 Apr 2026

The formatting should not be part of the text.
Nicholas Ramirez, please advise.

LEAHI-TD-FIRMWARE-LDT-4149-1 27 Jul 2026

Remove extra blank line.

LEAHI-APPLICATION-LDT-3932-1 06 May 2026

removed demo code

LEAHI-TESTSUITES-LDT-2174-1 07 Nov 2025

Removed the object Which is not being used

LEAHI-TESTSUITES-LDT-1650-1 10 Nov 2025

I have pushed utility.py file

LEAHI-APPLICATION-LDT-3932-1 06 May 2026

removed demo code