udpated
BN APPROVES
remove demo coe
move connection inside _postTreatmentDisconnectStack and remove function and just do
remove RO loop demo code
BN Appprvoes
Please remove for the above reasons.
please use the generic_override function from the common folder
don't need this if statement either and don't need what's inside the if.
& isInstrucitonbased
Please update the function name : testDDFloaterLevelStateOverride
The test configuration has not been imported yet. I commented it out as a placeholder.
Add fluidType to inputs
add rinsebackPublishTimerCtr to outputs
This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).
updated
750 now?
I mean, don't you think Sarina/Eliza still want this test config option? Why did you comment it out?
updated combobox to o_LogTypeComboBox.
Sean Nash the override functions other than the standard override functions, (e.g. broadcast interval) are implemented as per needed.
Updated.
It is ok for now, but from lines 11 to 19, there are still some object names that need to be refactored. Will be mentioned in later reviews,
Changed to U32
Do we have a return confirmation that the command is accepted by DD?
line 144 should have been removed as we discussed.
what is this file for? can we remove it
Keep 2 blank lines above the banner below.
Updated to use common height from Variables.qml
Do we need to shift CRC bits to lsb position?
set to 750 for all controlled flows.
Describe what kind of services are being provided.
Added comment block and uploaded test report onto Jira.
I guess, all these checks should be moved to FillEndState.
why "-3"? Please put a comment like line @58.
Why are we sending Teensy board a string command? I thought we changed Teensy interface to be binary.
Why string?
Add blank line between declarations and function code.
Add blank line before return statement.
Is sending of ACK msg needed here?
Why are we doing pre-increment instead of post-increment? I don't think it matters in for loop, but this looks non-standard to me.
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
