•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-3000-1 30 Dec 2025

removed

LEAHI-APPLICATION-LDT-3000-1 30 Dec 2025

fixed typo

LEAHI-APPLICATION-LDT-3000-1 30 Dec 2025

"for" bottom buttons

LEAHI-APPLICATION-LDT-3000-1 30 Dec 2025

remove for later

LEAHI-DD-FIRMWARE-LDT-2998-1 02 Jan 2026

Added

LEAHI-DD-FIRMWARE-LDT-2998-1 02 Jan 2026

Removed

LEAHI-DD-FIRMWARE-LDT-2998-1 02 Jan 2026

Yes, I updated

LEAHI-DD-FIRMWARE-LDT-2998-1 02 Jan 2026

I removed and confirmed with Noe

LEAHI-APPLICATION-LDT-2825-1 30 Dec 2025

added e prefix

LEAHI-APPLICATION-LDT-2825-1 30 Dec 2025

updated

LEAHI-APPLICATION-LDT-2825-1 30 Dec 2025

added comment

LEAHI-APPLICATION-LDT-2825-1 30 Dec 2025

fixed alignment

LEAHI-APPLICATION-LDT-2825-1 30 Dec 2025

align

LEAHI-APPLICATION-LDT-2825-1 30 Dec 2025

add comment to later remove qml enum and bind listview values to c++.

LEAHI-APPLICATION-LDT-2825-1 30 Dec 2025

User role + 1

LEAHI-APPLICATION-LDT-2825-1 30 Dec 2025

prefix all enums with 'e'

LEAHI-SW-PLUGINS-SIM-LDT-3000-1 30 Dec 2025

removed

LEAHI-SW-PLUGINS-SIM-LDT-3000-1 30 Dec 2025

remove

LEAHI-DD-FIRMWARE-LDT-2004-3 05 Jan 2026

Should be 2 blank lines before/after test support banner.

LEAHI-DD-FIRMWARE-LDT-2998-1 30 Dec 2025

Why are these items have been removed? If we no longer need these items then we should update the structure too.

LEAHI-DD-FIRMWARE-LDT-2998-1 02 Jan 2026

Yes, we need to update Dailin as well. I’ll make sure to update it there.

LEAHI-DD-FIRMWARE-LDT-2185-1 05 Jan 2026

Remove space(s) before }.

LEAHI-DD-FIRMWARE-LDT-2004-3 03 Jan 2026

Done.

LEAHI-DD-FIRMWARE-LDT-2998-1 02 Jan 2026

Currently, this function supports only D6 and P25. Separate functions have been implemented for D63 and D98.

LEAHI-DD-FIRMWARE-LDT-2004-3 05 Jan 2026

Updated to DryBicart group.

LEAHI-DD-FIRMWARE-LDT-2998-1 05 Jan 2026

Updated

LEAHI-DIALIN-LDT-2998-1 05 Jan 2026

Updated according to changes of LEAHI-DD-FIRMWARE-LDT-2998-1

LEAHI-DD-FIRMWARE-LDT-2185-1 05 Jan 2026

Should be 2 blank lines before/after test support banner.

LEAHI-DD-FIRMWARE-LDT-2185-1 05 Jan 2026

Is this really a "test" function? It does not have the correct Dialin prototype (returns BOOL and takes a message as param) and it does not appear to handle a request from or respond to Dialin.

LEAHI-DD-FIRMWARE-LDT-2185-1 05 Jan 2026

Remove comment? Looks like we have an alarm.

LEAHI-TD-FIRMWARE-LDT-3126-1 05 Jan 2026

I don't think we want this enum. There is already a VALVE_T in RotaryValve.h that lists the 2 pinch valves in TD. These are the 4 pinch valves in Denali HD.

LEAHI-DD-FIRMWARE-LDT-2004-3 05 Jan 2026

Comment does not really help me understand what this is. Can we be a little more descriptive?

LEAHI-DD-FIRMWARE-LDT-2004-3 05 Jan 2026

Align comments. Also, generally, don't need () for atomic values.

LEAHI-DD-FIRMWARE-LDT-2004-3 05 Jan 2026

.. function opens all of the balancing ...

LEAHI-DD-FIRMWARE-LDT-2998-1 02 Jan 2026

Use "getLevelStatus"

LEAHI-DIALIN-LDT-2998-1 05 Jan 2026

In f/w, the spares are numbered 3, 4, 5, and 7 (not 1..4).

LEAHI-DIALIN-LDT-2998-1 05 Jan 2026

Ok
(But feels weird to start the counting of existing items from 0 if that's the spare3 instead of 1. Calling the D79 the "zeroeth" spare valve instead of the first spare valve... Personally I think we should name them Spare1-8 instead of Spare 0-7)

LEAHI-DIALIN-LDT-2998-1 05 Jan 2026

Fixed Typo

LEAHI-DIALIN-LDT-2998-1 05 Jan 2026

interval?

LEAHI-DIALIN-LDT-2998-1 05 Jan 2026

Understand. In this case, the spare positions correspond to bit positions in the FPGA register and the new valves took the 1, 2, and 6 spots.

LEAHI-DD-FIRMWARE-LDT-2998-1 05 Jan 2026

Added

LEAHI-DD-FIRMWARE-LDT-2998-1 05 Jan 2026

Brief should mention function's name.

LEAHI-APPLICATION-LDT-2805-1 06 Jan 2026

Updated.

LEAHI-APPLICATION-LDT-2805-1 06 Jan 2026

Updated.

LEAHI-APPLICATION-LDT-2805-1 05 Jan 2026

Use "-- --" from Variables.

LEAHI-DD-FIRMWARE-LDT-2801-1 05 Jan 2026

These 2 functions seem redundant (with same prototypes above).

LEAHI-DD-FIRMWARE-LDT-2801-1 05 Jan 2026

Does this function return a speed or a pulse width?

LEAHI-TD-FIRMWARE-LDT-3126-1 05 Jan 2026

Align comment with variable comments below.

LEAHI-DD-FIRMWARE-LDT-2185-1 05 Jan 2026

Add blank line between functions.

LEAHI-DD-FIRMWARE-LDT-2004-3 05 Jan 2026

Align comment.