•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-TESTSUITES-LDT-2278-1 03 Dec 2025

moved to shared file and update to have the object as a parameter

LEAHI-TESTSUITES-LDT-2278-1 03 Dec 2025

remove as this is already in the config.py

LEAHI-TESTSUITES-LDT-2278-1 08 Dec 2025

Removed this function and using set_Object_Text() function

LEAHI-TESTSUITES-LDT-1802-1 08 Dec 2025

removed the outer startSection and uploaded the new test report

LEAHI-DD-FIRMWARE-LDT-2936-1 05 Dec 2025

I'm confused as to why the available alarm that this alarm replaced is in a different row within this table. That seems wrong.

LEAHI-DIALIN-LDT-2655-1 09 Dec 2025

Why do we have an "ro" and an "fp" folder? Is "ro" folder obsolete (replaced by "fp")?

LEAHI-TESTSUITES-LDT-2174-1 04 Dec 2025

The way we verify is that the o_PreTreatmentButton is only enabled when they are so testing that it is first enabled then mouse click the button then from fw send the td.td_Treatment_Parameters_Validation

LEAHI-TESTSUITES-LDT-1454-1 03 Dec 2025

this is a common method as well please move outside and update other respositories

LEAHI-APPLICATION-LDT-2957-1 10 Dec 2025

We should use "min" for minutes and not "mins".
Same for "hrs" => "hr".

LEAHI-TD-FIRMWARE-LDT-473-1 16 Dec 2025

It should no longer be called from OperationModes.c because we are deleted the TxParams mode (delete from enum and any switch statements in OperationModes.c).

LEAHI-APPLICATION-LDT-2957-1 10 Dec 2025

I believe any related view could have provided a timer since they are inherited from QObject.
That is fine for now but consider using our C++ view codes for such a thing.

LEAHI-DD-FIRMWARE-LDT-2004-2 16 Dec 2025

marking it as resolved since this is a temporary driver

LEAHI-APPLICATION-LDT-2707-1 16 Dec 2025

Could we use the ArrowButton.qml component? I think there is already one made that does just this

LEAHI-TD-FIRMWARE-LDT-473-1 09 Dec 2025

Need to delete this unit (ModeTxParams.c/.h). Also need to remove the mode from the modes enumeration and from OperationModes.c.

LEAHI-APPLICATION-LDT-2957-1 16 Dec 2025

fixed

LEAHI-TESTSUITES-LDT-1802-1 18 Dec 2025

EXPORT_LOG_TEXT constant belongs to Service Export Logs feature test script and may be needed to take after the translation by changing constant values

LEAHI-APPLICATION-LDT-3000-1 18 Dec 2025

done

LEAHI-DIALIN-LDT-2998-1 18 Dec 2025

D98 has been renamed

LEAHI-RO-FIRMWARE-LDT-2116-1 18 Dec 2025

Is this code for alpha or beta? getCurrentOperationMode() will only return DD modes in beta.

LEAHI-TD-FIRMWARE-LDT-1886-1 18 Dec 2025

These don't need to be initialized to zero.

LEAHI-TD-FIRMWARE-LDT-1886-1 05 Dec 2025

Should we comment this out before merging?

LEAHI-APPLICATION-LDT-2825-1 17 Dec 2025

move into VInstitutitonal and create model there and read config file inside and populate. Change VTreatmentranges to Vinstitutional and add origignal macro

LEAHI-DD-FIRMWARE-LDT-2185-1 16 Dec 2025

Add blank line between declarations and statements.

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

The view classes are QObject, and they already have an internal timer that you can start and use in the timer event.
Therefore, this block of code needs to be moved to the timerEvent.

I have created a story as an enhancement to the date and time for the following:

  1. Since the SW Board is the only reference for the clock, we now need to send the date and time to both the TD and DD every second as a broadcast message
    • That message should be on a general channel so both get it instead of two separate messages.
    • If SW won't update the TD every second, and with a different epoch, TD will raise an alarm
      • We only need to know, but SW does not need to do anything about it
      • The Alarm infrastructure will automatically handle it
      • If disconnected, TD will play the alarm sound and turn on the alarm light.
  2. While we are sending the epoch as broadcast every second, and TD will raise an alarm if we don't, we need to get rid of the two requests, response messages, and send that epoch every second broadcast.
  3. As has been mentioned above, we need to update the disabled date and time on NTP
    • When switched to NO NTP, stop updating.
  4. A timezone needs to be added to the Date and time screen, since we already have NTP, so that we can update by timezone.
  5. Another comment: don't the datetime conversion, 'toString' function is slow, and that we can pass integer values instead, since we are going to use it every second?


LDT-2909: Service - SW - 01 - Enhancement - FW epoch Broadcast, TimeZone - R&I
LDT-2923: Service - SW - 02 - Enhancement - FW epoch Broadcast, TimeZone - Q&R

LEAHI-DD-FIRMWARE-LDT-618-3 11 Dec 2025

We still need this if statement.

LEAHI-DD-FIRMWARE-LDT-2185-1 12 Dec 2025

removed

LEAHI-DD-FIRMWARE-LDT-2185-1 11 Dec 2025

Add a 1 second persistence on this alarm

LEAHI-TESTSUITES-LDT-2174-1 14 Dec 2025

Removed the duplicate

LEAHI-TESTSUITES-LDT-1802-1 18 Dec 2025

Now findObjectByText(parent_object, target_text): method is moved to configuration folder utility.py file

TEENSY-BOARD-LDT-2004-6 18 Dec 2025

fixed. thanks!

LEAHI-APPLICATION-LDT-3046-1 17 Dec 2025

HDF Visible:false

LEAHI-APPLICATION-LDT-3000-1 17 Dec 2025

switch buttons
Cancel: Stay on treatment
Confirm: End Treatment

LEAHI-DD-FIRMWARE-LDT-2185-1 16 Dec 2025

Add blank line between declarations and statements.

LEAHI-DIALIN-LDT-2998-1 18 Dec 2025

No reference of conductivity here. it should be a level sensor.

LEAHI-TESTSUITES-LDT-1454-1 16 Dec 2025

The test steps should reflect and match the sections on the generated report https://diality.atlassian.net/browse/LDT-1456. Please Update to align test outline with the sections to report and please upload a new report.

LEAHI-APPLICATION-LDT-3046-1 18 Dec 2025

updated

LEAHI-APPLICATION-LDT-3000-1 18 Dec 2025

added this back in

TEENSY-BOARD-LDT-2004-6 18 Dec 2025

fixed. thanks!

LEAHI-TESTSUITES-LDT-2278-1 19 Dec 2025

Test script is updated as per suggestion

LEAHI-APPLICATION-LDT-2825-1 17 Dec 2025

UPDATE INST GETTERS WITH

#define RANGEINSTSET()

RANGESET ()
READONLY( vTYPE , vVARIABLE##OrgMin, vDEFVALUE )
READONLY( vTYPE , vVARIABLE##OrgMax, vDEFVALUE )
READONLY( vTYPE , vVARIABLE##OrgDef, vDEFVALUE )

LEAHI-DD-FIRMWARE-LDT-2004-3 22 Dec 2025

Done.

LEAHI-DD-FIRMWARE-LDT-2004-3 22 Dec 2025

Done.

LEAHI-DD-FIRMWARE-LDT-2004-3 22 Dec 2025

Updated.

LEAHI-DD-FIRMWARE-LDT-2004-3 22 Dec 2025

Done.

LEAHI-DD-FIRMWARE-LDT-2004-3 22 Dec 2025

Done.

LEAHI-DD-FIRMWARE-LDT-2185-1 26 Dec 2025

0.0 is OK

LEAHI-FWCOMMON-LDT-2116-1 18 Dec 2025

That suggests that our coefficient(s) are too aggressive (in situations where it looks unstable). Not directly due to max step size, so we shouldn't reduce it for this reason. I believe 25 will negatively impact our responsiveness in situations where our error is larger than 25 mL/min.
So instability could be due to:
1) coefficient(s) are too strong or
2) may need more than one set of coefficients (e.g. coefficients need to change according to Qd or state or ... because the relationship between output and feedback changes)

LEAHI-DIALIN-LDT-2998-1 30 Dec 2025

Match with the firmware in LDT-2998.

LEAHI-DD-FIRMWARE-LDT-2998-1 30 Dec 2025

These are redundant information from level and pressure module, we may remove them.

LEAHI-DD-FIRMWARE-LDT-2004-3 22 Dec 2025

Done.