•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-RO-FIRMWARE-LDT-2116-1 28 Oct 2025

TargetDutyCycle is F32 override

TD-LDT-1886-7 03 Nov 2025

Make 10000 a #define.

LEAHI-DD-FIRMWARE-LDT-2004-1 04 Nov 2025

Add a Private Definitions banner between includes and private definitions.

LEAHI-APPLICATION-LDT-2707-1 15 Apr 2026

moved to other slot

LEAHI-APPLICATION-LDT-2707-1 15 Apr 2026

removed and tested

LEAHI-DD-FIRMWARE-LDT-2004-9 14 Apr 2026

You may use getF32OverrideValue for consistency (across the file).

LEAHI-TD-FIRMWARE-LDT-1886-2 22 Apr 2026

Need function header above function.

LEAHI-APPLICATION-LDT-3757-1 17 Apr 2026

RESOLVED.

LEAHI-APPLICATION-LDT-3800-1 17 Apr 2026

added

LEAHI-APPLICATION-LDT-3855-1 15 Apr 2026

match logic to stop state

LEAHI-APPLICATION-LDT-3800-1 17 Apr 2026

add comment for HEX to NOT add '0x'

LEAHI-TD-FIRMWARE-LDT-1886-2 22 Apr 2026

Set the fault property for this alarm to TRUE and then you don't need to request to go to fault mode - the alarm will do it for you. You should never have to request fault mode like this.

LEAHI-DD-FIRMWARE-LDT-3978-1 30 Apr 2026

can we get 'runPIController' inside deadband control check?

LEAHI-TESTSUITES-LDT-3153-1 17 Apr 2026

this is a good test for each test main function, but needs to be one time t the top of the main function.
And I believe if that fails you need to exit and do not continue to the rest of the test.

make a checkblock and return if fails.

LEAHI-TD-FIRMWARE-LDT-1886-2 26 Apr 2026

Move this transition function call to the transitionToPostTreatmentMode function below.

LEAHI-DD-FIRMWARE-LDT-3980-1 28 Apr 2026

Add comment.

LEAHI-TD-FIRMWARE-LDT-4188-1 01 May 2026

Updated to ml/min, except for broadcast in treatment mode

LEAHI-TD-FIRMWARE-LDT-2240-1 03 May 2026

Calling signal function here seems circular (that's how we got here in the first place).
Shouldn't we set state to the install state here instead?

LEAHI-TD-FIRMWARE-LDT-3970-1 29 Apr 2026

No longer needed?

LEAHI-TD-FIRMWARE-LDT-3970-1 29 Apr 2026

Not sure why you are making changes to this function.
This function handles message from UI to pause or resume ultrafiltration.
This is not a treatment parameter edit message, so I don't think it's part of your assignment.

LEAHI-TD-FIRMWARE-LDT-1886-2 03 May 2026

Describe what kind of services being provided.

LEAHI-TESTSUITES-LDT-3208-1 04 May 2026

In Utility file we are using squish. to Improve the reliability by handling timing and synchronization issues.

LEAHI-TESTSUITES-LDT-3208-1 04 May 2026

In latest build it is not required currently i am working on New design create Rx we will update the method

TD-LDT-1886-7 10 Nov 2025

None?

LEAHI-TD-FIRMWARE-LDT-2240-1 03 May 2026

I think Praneeth created a function for this. Make sure they're identical.

LEAHI-TD-FIRMWARE-LDT-2240-1 05 May 2026

dry self-tests

LEAHI-DD-FIRMWARE-LDT-3963-1 03 May 2026

Looks like we need a TODO comment to restore these checks later.

LEAHI-TD-FIRMWARE-LDT-2240-1 03 May 2026

DrySelfTests unit.

LEAHI-TD-FIRMWARE-LDT-3970-1 30 Apr 2026

I don't think you want stored (old) value here. You want value from first message before confirmation.

LEAHI-TD-FIRMWARE-LDT-1886-2 05 May 2026

There should be a \b before the type of details (Inputs and Outputs here) for doxygen update for all

LEAHI-TD-FIRMWARE-LDT-1886-2 05 May 2026

currentAutoEjectState should be input?

LEAHI-TD-FIRMWARE-LDT-1886-2 05 May 2026

add autoEjectTimerCounter to outputs

LEAHI-DD-FIRMWARE-LDT-4183-1 05 May 2026

Remove blank line

LEAHI-APPLICATION-LDT-2686-1 28 Oct 2025

RESOLVED

LEAHI-TESTSUITES-LDT-1057-1 29 Oct 2025

updated all objects names started with o_.

LEAHI-DD-FIRMWARE-LDT-4188-1 30 Apr 2026

Can we add sodium and bicarb overrides now, so that we don't want to come back again for this change?
Also, please get the dialin updated to reflect the new parameters additions in tdproxy and let system team be in loop to update the required system scripts?

LEAHI-TESTSUITES-LDT-1057-1 29 Oct 2025

removed the line "app_context = None".

LEAHI-APPLICATION-LDT-2666-1 28 Oct 2025

Update objectName.

LEAHI-RO-FIRMWARE-LDT-2116-1 03 Nov 2025

fixed. Thanks!

LEAHI-DIALIN-LDT-3984-1 28 Apr 2026

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines?
I think the second lvl_sen is not needed, the one without the offset.

LEAHI-RO-FIRMWARE-LDT-2116-1 03 Nov 2025

temporary. Reverted back to original publishing data.

LEAHI-DD-FIRMWARE-LDT-3980-1 28 Apr 2026

Do we need to check if bicarb chamber level is high, ignore opening D80?

LEAHI-DD-FIRMWARE-LDT-3978-1 30 Apr 2026

if we are not checking level, this can be removed and function name also can be updated accordingly.

LEAHI-TD-FIRMWARE-LDT-4188-1 30 Apr 2026

Other existing set functions in TD is using UF in liter and rate in L/hr

Shall I change all of them? Which might impact how systems is sending this info(L/hr or ml/min) in their scripts

LEAHI-TD-FIRMWARE-LDT-4188-1 30 Apr 2026

Remove extra space before function name.

LEAHI-TD-FIRMWARE-LDT-4188-1 30 Apr 2026

Remove extra blank line.

LEAHI-TD-FIRMWARE-LDT-4188-1 30 Apr 2026

Is the UF rate unit in ml/min (instead of hr.)?

LEAHI-TD-FIRMWARE-LDT-2240-1 03 May 2026

.. handles dry self-tests execution for pre-treatment and treatment modes.

LEAHI-TD-FIRMWARE-LDT-2240-1 05 May 2026

Still need cmd to barcode reader to scan.

LEAHI-TD-FIRMWARE-LDT-1886-2 05 May 2026

As per MISRA 15.7, All if, else if constructs shall be terminated with an else statement.