•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-TD-FIRMWARE-LDT-473-1 16 Dec 2025

Updated.

LEAHI-DD-FIRMWARE-LDT-2185-1 12 Dec 2025

No need to initialize these to zero.

LEAHI-APPLICATION-LDT-3000-1 17 Dec 2025

only run when visible

LEAHI-APPLICATION-LDT-2825-1 17 Dec 2025

loook into font size of settings screen and pretreatment. Fix insititual labelunit container font sizes too

LEAHI-DD-FIRMWARE-LDT-2004-3 15 Dec 2025

This function has an output.

LEAHI-TESTSUITES-LDT-1454-1 03 Dec 2025

can we make this a more general method and put in a shared file and update throughout.. update to something like

def setObjectText(obj, text):
    obj["text"] = text
    return obj:
LEAHI-DD-FIRMWARE-LDT-2185-1 18 Dec 2025

FPFilterFlushDefeatured.

LEAHI-RO-FIRMWARE-LDT-2116-1 18 Dec 2025

roRejectionRatioTankFill is an input.

LEAHI-RO-FIRMWARE-LDT-2116-1 18 Dec 2025

Update inputs/outputs.

LEAHI-DD-FIRMWARE-LDT-2936-1 02 Dec 2025

Fixed.

LEAHI-TD-FIRMWARE-LDT-473-1 02 Dec 2025

No need to initialize here as it is initialized in init function. Also, need to add a doxygen comment to the right of this line.

LEAHI-TESTSUITES-LDT-2278-1 11 Dec 2025

This never happens because the interval doesnt hit 0 in the test.. I would suggest settings timeout to 5 min and waiting listening in a loop for 5 min to get the request.. look into can_interface.register_receiving_publication_function() to listen for a message from UI

LEAHI-TD-FIRMWARE-LDT-473-1 16 Dec 2025

Yes, we need to

LEAHI-DD-FIRMWARE-LDT-2185-1 12 Dec 2025

fixed it

LEAHI-DD-FIRMWARE-LDT-2936-1 02 Dec 2025

as a practice , we need to add a pragma pack for all structure irrespective of the size as per Sean.

LEAHI-DD-FIRMWARE-LDT-618-2 04 Dec 2025

Removed

LEAHI-TD-FIRMWARE-LDT-473-1 08 Dec 2025

Updated

LEAHI-TESTSUITES-LDT-1036-1 05 Dec 2025

Now findChildByText(parent_object, target_text): method is moved to configuration folder utility.py file

LEAHI-TD-FIRMWARE-LDT-473-1 02 Dec 2025

Remove extra blank line.

LEAHI-TD-FIRMWARE-LDT-473-1 02 Dec 2025

We probably want to go to patient connection state (or whatever the next state is) eventually, but we haven't implemented any other states in pre-treatment yet.
Comment this line out with a TODO comment to restore when the state is implemented. And, for now, add a call to request treatment mode.

LEAHI-TESTSUITES-LDT-2174-1 02 Dec 2025

reduce timeout to 1000

LEAHI-TESTSUITES-LDT-2174-1 02 Dec 2025

we also want to verify the right arrow is not editable telling us this is the make hjep stop time can go

LEAHI-DD-FIRMWARE-LDT-2004-3 08 Dec 2025

Done

LEAHI-DD-FIRMWARE-LDT-2004-3 08 Dec 2025

Let public function on top

LEAHI-TD-FIRMWARE-LDT-473-1 08 Dec 2025

I don't see an isTreatmentParamInRange function. I think we need to copy from the ModeTxParams.c.

LEAHI-DD-FIRMWARE-LDT-2185-1 11 Dec 2025

Add space between if and (.

LEAHI-DIALIN-LDT-598-2 10 Dec 2025

Why was this changed?

LEAHI-TESTSUITES-LDT-2174-1 02 Dec 2025

#3. Change Heparin Dispensising Rate from OFF to 0.2 -> Verify Heparin Stop Time "active" property is set to off

verify the proeprty "isActive" property of o_PreTreatmentCreate_heparinStopTimeControl_ValueAdjuster is set to False isntead

LEAHI-TESTSUITES-LDT-2174-1 02 Dec 2025

#2. Change Heparin Dispensising Rate from 0.2 to OFF -> Verify Heparing Stop Time is set to OFF
1. First give a value to duration, hep bolus value, and dispensing rate, and hep stop time. (none should be set to OFF)
2. Set Dispensing Rate to off
3. Verify hepstop time is set to off

LEAHI-TESTSUITES-LDT-1454-1 05 Dec 2025

Please add the test case to the suite.conf

LEAHI-DD-FIRMWARE-LDT-2185-1 16 Dec 2025

Removed

LEAHI-DD-FIRMWARE-LDT-1773-1 08 Dec 2025

Remove extra blank line.

LEAHI-TESTSUITES-LDT-2174-1 11 Dec 2025

remove and add delay i waitForObjectExists if needed

LEAHI-TESTSUITES-LDT-2174-1 11 Dec 2025

used setObjectText() instead

LEAHI-DD-FIRMWARE-LDT-2004-2 16 Dec 2025

I am marking it as resolved since it is temporary driver

LEAHI-TD-FIRMWARE-LDT-1886-1 16 Dec 2025

Done

LEAHI-DD-FIRMWARE-LDT-2004-2 16 Dec 2025

marking it as resolved since it is temporary driver

LEAHI-TD-FIRMWARE-LDT-473-1 16 Dec 2025

Removed

LEAHI-DD-FIRMWARE-LDT-2185-1 12 Dec 2025

Remove extra blank line.

LEAHI-TD-FIRMWARE-LDT-1886-1 16 Dec 2025

Done.

LEAHI-APPLICATION-LDT-2957-1 12 Dec 2025

It is a little bit concerning:
Could you please test/describe the following scenarios:

  • What if we have more than one Heparin type supported?
  • What if none (incorrectly) has been defined in the configuration (do we get an index out of bounds)?
LEAHI-DD-FIRMWARE-LDT-2185-1 17 Dec 2025

Plan is for 4 wire and currently there is no data for both 2 wire and 4 wire . So its TODO list and hence mark it as resolved

LEAHI-TD-FIRMWARE-LDT-1886-1 17 Dec 2025

Done

LEAHI-APPLICATION-LDT-2825-1 17 Dec 2025

add visible only in service

LEAHI-TD-FIRMWARE-LDT-1886-1 17 Dec 2025

Done

LEAHI-APPLICATION-LDT-3000-1 17 Dec 2025

revert this

LEAHI-APPLICATION-LDT-2825-1 17 Dec 2025

make a String Property in SettingsBase to share with advanced

LEAHI-DD-FIRMWARE-LDT-2004-3 08 Dec 2025

comment should start with capital letter

LEAHI-APPLICATION-LDT-3000-1 18 Dec 2025

updated

TEENSY-BOARD-LDT-2004-6 18 Dec 2025

fixed. thanks!