•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-4500-1 24 Jul 2026

At end of transition, do you want to initialize the totalSpentChamberFill reset to zero?

LEAHI-DD-FIRMWARE-LDT-2004-9 14 Apr 2026

Removing it now. will introduce it later if required

LEAHI-DD-FIRMWARE-LDT-2004-9 14 Apr 2026

Remove extra blank lines.

LEAHI-DD-FIRMWARE-LDT-2004-9 14 Apr 2026

Why do we need this?

LEAHI-DIALIN-LDT-2658-2 04 Nov 2025

Dara Navaei I only see this override function for "filtered" temperatures, but according to function name, it only applies to temperatures coming from pressure sensors. Why only pressure based temperatures?

LEAHI-DD-FIRMWARE-LDT-2004-1 04 Nov 2025

Do we need to include Teensy driver here?

LEAHI-DD-FIRMWARE-LDT-2004-9 14 Apr 2026

I think we can remove the balancing chamber fill in progress check for Opening D80 valve, as this does not impact the balancing chamber fill process.

LEAHI-APPLICATION-LDT-2686-1 28 Oct 2025

RESOLVED

LEAHI-APPLICATION-LDT-2686-1 28 Oct 2025

RESOLVED

LEAHI-DD-FIRMWARE-LDT-3218-4 15 Apr 2026

fixed

LEAHI-TESTSUITES-LDT-1057-1 29 Oct 2025

Updated the object names as suggested.

LEAHI-TESTSUITES-LDT-1057-1 27 Oct 2025

Please use more meaningful names.
The combobox is too general.

LEAHI-TESTSUITES-LDT-1057-1 27 Oct 2025

Same here.
And all the other same instances.

  • Please add the container/use case in the name if the object is not generally unique.
  • Add the type at the end if it is not redundant.


Example:

  • o_SettigsExportLogs_ProgressRect
LEAHI-DD-FIRMWARE-LDT-3218-4 15 Apr 2026

by the end of S27 we will know if we need to keep this module. If so, then we can integrate it into PIControllers.c

LEAHI-TESTSUITES-LDT-1057-1 03 Nov 2025

Updated as per the suggestion.

LEAHI-APPLICATION-LDT-3757-1 16 Apr 2026

updated

LEAHI-TESTSUITES-LDT-1218-1 27 Oct 2025

Seems there is a missing test.startSection() , test.endSection() for the Pressures here

LEAHI-APPLICATION-LDT-3757-1 16 Apr 2026

removed

LEAHI-APPLICATION-LDT-3757-1 17 Apr 2026

RESOLVED.

LEAHI-APPLICATION-LDT-3800-1 17 Apr 2026

updated

LEAHI-APPLICATION-LDT-3800-1 17 Apr 2026

RESOLVED

LEAHI-APPLICATION-LDT-3800-1 17 Apr 2026

set to true

LEAHI-TD-FIRMWARE-LDT-1886-2 22 Apr 2026

This command should be given once on way out of prior state instead of every 50ms while in this state.
We also need to zero the timer counter at same time so the timeout check below works.

LEAHI-TD-FIRMWARE-LDT-2240-1 26 Apr 2026

It looks like you deleted it instead of fixing it.

LEAHI-TD-FIRMWARE-LDT-1886-2 20 Apr 2026

Should be in Ejector.c

LEAHI-TD-FIRMWARE-LDT-4149-1 27 Jul 2026

Add a TODO comment to restore this when Noe fixes FPGA

LEAHI-TD-FIRMWARE-LDT-1886-2 05 May 2026

Put it back

LEAHI-DD-FIRMWARE-LDT-2936-1 02 Dec 2025

Fixed.

LEAHI-SW-PLUGINS-SIM-LDT-5246-1 28 Jul 2026

Reviewed on VM with BN

LEAHI-TD-FIRMWARE-LDT-4505-1 27 Jul 2026

Fix comment. Should say "in mL/min."

LEAHI-DD-FIRMWARE-LDT-2004-9 14 Apr 2026

Remove blank line.

LEAHI-APPLICATION-LDT-3459-1 15 Apr 2026

Updated.

LEAHI-APPLICATION-LDT-2666-1 30 Oct 2025

Updated.

LEAHI-APPLICATION-LDT-2666-1 30 Oct 2025

Updated.

LEAHI-TESTSUITES-LDT-1057-1 27 Oct 2025

Please use consistent object names, all starting with o_, to make them easier to identify in the code and debug messages.

LEAHI-DD-FIRMWARE-LDT-3904-1 15 Apr 2026

COMM_BUFFER_OUT_CAN_FP_BROADCAST

sendEvent check the event ID. if it is an FP event, FP event will be sent on COMM_BUFFER_OUT_CAN_FP_BROADCAST

LEAHI-TD-FIRMWARE-LDT-4149-1 27 Jul 2026

If we don't need this code, remove it.

LEAHI-TD-FIRMWARE-LDT-4149-1 27 Jul 2026

Remove extra blank lines and comment.

LEAHI-APPLICATION-LDT-3757-1 16 Apr 2026

updated

LEAHI-APPLICATION-LDT-3656-1 17 Apr 2026

removed confirm

LEAHI-SIMULATOR-LDT-2707-1 17 Apr 2026

the branch is empty with no update.

LEAHI-APPLICATION-LDT-3757-1 15 Apr 2026

Group all button options

LEAHI-APPLICATION-LDT-3757-1 17 Apr 2026

RESOLVED.

LEAHI-APPLICATION-LDT-3757-1 17 Apr 2026

RESOLVED.

LEAHI-APPLICATION-LDT-3656-1 17 Apr 2026

RESOLVED.

LEAHI-APPLICATION-LDT-3656-1 15 Apr 2026

test Q_ENUM or Q_ENUMS and test the fail case. REmoving enum in c++ and trying to acces it in qml

— OR –

separate function to setHDFHeaderVisible and setHeparinHeaderVisible.

LEAHI-TD-FIRMWARE-LDT-3959-1 21 Apr 2026

updated.

LEAHI-TESTSUITES-LDT-2741-1 13 Feb 2026

Multiple lines of the texts here are translatable.
I think we need to create a separate Python file for text-only content, so we can load different versions of it depending on the language we set before each test.
Additionally, another idea is to separate any text verification into a translation test case for the entire application using the Python file I mentioned above.
Nicholas Ramirez What are your thoughts on that?

LEAHI-TD-FIRMWARE-LDT-3959-1 21 Apr 2026

Refactor this function to have only one return statement.

LEAHI-DD-FIRMWARE-LDT-3735-1 27 Jul 2026

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.