•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-TESTSUITES-LDT-1454-1 16 Dec 2025

the method name we have been using is setObjectText.. please update for consistancy. Test is failing due to this. please test first before committing code

LEAHI-DD-FIRMWARE-LDT-2936-1 02 Dec 2025

Fixed.

LEAHI-DD-FIRMWARE-LDT-2936-1 02 Dec 2025

Fixed.

LEAHI-DD-FIRMWARE-LDT-2185-1 12 Dec 2025

added

LEAHI-TD-FIRMWARE-LDT-473-1 02 Dec 2025

Remove this blank line.

LEAHI-TESTSUITES-LDT-2174-1 03 Dec 2025

Updated the object name

LEAHI-TESTSUITES-LDT-2174-1 03 Dec 2025

To check slider functionality it required some wait time so added waitForGUI method

LEAHI-TD-FIRMWARE-LDT-473-1 02 Dec 2025

treatParamsConfirmed is an input.

LEAHI-TESTSUITES-LDT-1802-1 02 Dec 2025

Please update the report and all test cases to match this workflow.

LEAHI-TESTSUITES-LDT-2174-1 03 Dec 2025

This is a common method used in another test case please move outside in a common shared file

LEAHI-TESTSUITES-LDT-2174-1 02 Dec 2025

can you help explain what this method does exactly? This takes a very long time. Can we simply just test the min and max with arrows then min and max with slider. This seems to go back and forth for each item.

LEAHI-DD-FIRMWARE-LDT-618-2 04 Dec 2025

Please use getU32override function and then typecast it.

LEAHI-DD-FIRMWARE-LDT-618-2 03 Dec 2025

Add a space between if and (.

LEAHI-DD-FIRMWARE-LDT-618-2 04 Dec 2025

Updated

LEAHI-TESTSUITES-LDT-1550-1 05 Dec 2025

Now using setText(obj, text) method and moved to configuration folder utility.py file

LEAHI-DD-FIRMWARE-LDT-618-2 04 Dec 2025

These are treatment parameters that happen to be overrideable. Change comment to "Initialize treatment parameters from TD."

LEAHI-TESTSUITES-LDT-2278-1 08 Dec 2025

Added the test case name in suite Conf file

LEAHI-TESTSUITES-LDT-1454-1 09 Dec 2025

Moved this into utility.py file

LEAHI-TD-FIRMWARE-LDT-473-1 08 Dec 2025

Add one more blank line above test support banner.

LEAHI-DD-FIRMWARE-LDT-2936-1 09 Dec 2025

I don't see fix

LEAHI-TD-FIRMWARE-LDT-473-1 15 Dec 2025

Added.

LEAHI-DD-FIRMWARE-LDT-2329-2 08 Dec 2025

comments should start with capital letter

LEAHI-TESTSUITES-LDT-1454-1 03 Dec 2025

ive noticed this common method being used in other test cases. If its a general method that is used throughout please move outside in a shared file and call from there. Please update other repositories that use this as well.

LEAHI-APPLICATION-LDT-2957-1 10 Dec 2025

Thank you .

LEAHI-APPLICATION-LDT-2957-1 10 Dec 2025

We should add the qsTr()

LEAHI-DD-FIRMWARE-LDT-2030-2 10 Dec 2025

is it merge issue ?

LEAHI-APPLICATION-LDT-2825-1 17 Dec 2025

Is this import needed?

LEAHI-TD-FIRMWARE-LDT-473-1 15 Dec 2025

Yes, this is called in OperationModes.c

LEAHI-TD-FIRMWARE-LDT-1886-1 16 Dec 2025

Done

LEAHI-APPLICATION-LDT-3000-1 18 Dec 2025

updated

LEAHI-APPLICATION-LDT-3000-1 18 Dec 2025

updated logic

LEAHI-APPLICATION-LDT-3000-1 18 Dec 2025

updated

LEAHI-APPLICATION-LDT-2825-1 17 Dec 2025

Delete commented out lines?

LEAHI-APPLICATION-LDT-2825-1 17 Dec 2025

revert to use ranges and add actionReceive on insititutailan and advanced institutitional views

LEAHI-TESTSUITES-LDT-1802-1 12 Dec 2025

Since this is being used everywhere, I would recommend defining a global variable(s) so that we can later be flexible to adjust that for all the mouse clicks or watforobject functions

LEAHI-RO-FIRMWARE-LDT-2116-1 18 Dec 2025

Update inputs/outputs.

LEAHI-RO-FIRMWARE-LDT-2116-1 18 Dec 2025

We have an alarm in this function. Should note it in function header.

LEAHI-DD-FIRMWARE-LDT-2004-3 08 Dec 2025

Suggestive comment => can we make it as a run time configuration option so that we don't need to change the code ?

LEAHI-DD-FIRMWARE-LDT-2936-1 02 Dec 2025

Fixed.

LEAHI-TESTSUITES-LDT-2278-1 11 Dec 2025

Update:

1. You need a test to wait for the timer to countdown all the way and confirm FW is receiving the request. I suggest setting the inerval to 5 min and add a way to wait 5 min max until we receive the Request from UI..
e.g. To listen for a UI message look into can_interface.register_receiving_publication_function().. example in Solution infusion.
2. I would like a test during the timer running to change the interval time and verify the count down updates per the new interval.
e.g. set 30 min and verify the count down is going down to the nearest 30 min interval, Open the vitals interval popup and change to 5 min and confirm then test the countdown udpates to countdown to the nearest 5 min mark

LEAHI-DD-FIRMWARE-LDT-2936-1 02 Dec 2025

Fixed.

LEAHI-DD-FIRMWARE-LDT-2936-1 09 Dec 2025

Resolved

LEAHI-TESTSUITES-LDT-2174-1 03 Dec 2025

The steps have been modified as per suggestion

LEAHI-TESTSUITES-LDT-2174-1 03 Dec 2025

The steps have been modified as per suggestion

LEAHI-TD-FIRMWARE-LDT-1886-1 02 Dec 2025

Align =

LEAHI-DD-FIRMWARE-LDT-2329-2 09 Dec 2025

Done

LEAHI-TESTSUITES-LDT-2174-1 02 Dec 2025

type o_PreTreatmentButton

LEAHI-DD-FIRMWARE-LDT-2936-1 04 Dec 2025

I don't think the number of samples is what you want as 3rd parameter. You want number of bytes so 4 x number of samples so you should pass "sizeof( roRRSamples )".

LEAHI-DD-FIRMWARE-LDT-618-2 04 Dec 2025

Done.

LEAHI-DD-FIRMWARE-LDT-618-2 04 Dec 2025

Changed