•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-TD-FIRMWARE-LDT-473-1 09 Dec 2025

I don't see these Lower/Upper Range Limit functions declared in the header file.

LEAHI-DD-FIRMWARE-LDT-2004-2 16 Dec 2025

Its like we need to compile the safe library and include it. But if we are using only memcpy and memset, memcmp and static code analyzer check the destination buffer size , I am marking it as resolved

LEAHI-APPLICATION-LDT-2825-1 17 Dec 2025

add method and macros for this and advaned into VTreatmentranges and update only Rx paraemettes

LEAHI-APPLICATION-LDT-3000-1 18 Dec 2025

done

TEENSY-BOARD-LDT-2004-6 18 Dec 2025

fixed. thanks!

TEENSY-BOARD-LDT-2004-6 18 Dec 2025

added. thanks!

LEAHI-TD-FIRMWARE-LDT-1886-1 16 Dec 2025

Is this temporary?

LEAHI-DIALIN-LDT-2998-1 18 Dec 2025

Moved

LEAHI-RO-FIRMWARE-LDT-2116-1 18 Dec 2025

roRRAvg is an input.

LEAHI-DIALIN-LDT-1886-2 18 Dec 2025

Oh, ok, I thought 'i' only covers 8 bit not 32

LEAHI-TESTSUITES-LDT-2278-1 19 Dec 2025

Test script is updated as per suggestion

LEAHI-RO-FIRMWARE-LDT-2116-1 19 Dec 2025

This is for alpha

LEAHI-APPLICATION-LDT-3000-1 17 Dec 2025

make this a bool and update internally

LEAHI-DD-FIRMWARE-LDT-2936-1 02 Dec 2025

Fixed.

LEAHI-TESTSUITES-LDT-2174-1 02 Dec 2025

please upload new report to view changes

LEAHI-DD-FIRMWARE-LDT-618-2 04 Dec 2025

You don't need the if statement. The override function will check it automatically.

LEAHI-DD-FIRMWARE-LDT-618-2 04 Dec 2025

Please use getU32override function and then typecast it.

LEAHI-DD-FIRMWARE-LDT-618-2 03 Dec 2025

Should use existing override payload structure (the one with the index) located in TestSupport.h.
Add an enum in this unit for the 5 DD treatment parameters so you can interpret the index field of the message payload to find the specific parameter that is being overridden.

LEAHI-TESTSUITES-LDT-2174-1 03 Dec 2025

The value will be updated based on the target value provided by the user.
To adjust the minimum and maximum values, use the left and right arrows to update them accordingly.

LEAHI-DD-FIRMWARE-LDT-618-2 04 Dec 2025

Changed the comments

LEAHI-TD-FIRMWARE-LDT-473-1 02 Dec 2025

TDDefs.h is already included in ModePreTreat.h. There is no "TD_Defs.h". Remove this line.

LEAHI-DD-FIRMWARE-LDT-2936-1 03 Dec 2025

publish filter flush status , add other important data , inlet pressure etc

LEAHI-TESTSUITES-LDT-2174-1 04 Dec 2025

Common method is moved to Utility.py file

LEAHI-DD-FIRMWARE-LDT-2936-1 04 Dec 2025

Fixed.

LEAHI-TD-FIRMWARE-LDT-473-1 02 Dec 2025

Remove extra blank line.

LEAHI-TD-FIRMWARE-LDT-473-1 02 Dec 2025

I don't see this function resetting Tx params. Probably a good idea to do that, so add call to reset.

LEAHI-TD-FIRMWARE-LDT-473-1 02 Dec 2025

What is this condition here for?

LEAHI-TESTSUITES-LDT-1650-1 03 Dec 2025

can we make this a more general method and put in a shared file and update throughout.. updatet to something like

def setText(obj, text):
    obj["text"] = text
    return obj:
LEAHI-TD-FIRMWARE-LDT-473-1 15 Dec 2025

Thanks for the clarification. This handler already follows the single-parameter MESSAGE_T *message pattern, and the message ID is already defined and registered in Messaging.c. I’ll keep using the existing ID, ensure payload length is validated, and parse the param/value from the payload as expected.

LEAHI-DD-FIRMWARE-LDT-2030-2 09 Dec 2025

Dara Navaei, this is not a CAN message payload, but it does look like a sensor serial message payload. I'm assuming this code works, so sensor does not expect a packed structure?

LEAHI-TD-FIRMWARE-LDT-473-1 08 Dec 2025

Added

LEAHI-TESTSUITES-LDT-2174-1 05 Dec 2025

another mouseClick(waitForObject(confirmButton)) after fw validates parameter is needed

LEAHI-DD-FIRMWARE-LDT-2004-3 08 Dec 2025

These set of valves defined as per system architecture (to make sure all valves initialized as expected).

LEAHI-TESTSUITES-LDT-1802-1 08 Dec 2025

Add tst_general_alarm_requirements_instruction to suite.conf file

LEAHI-APPLICATION-LDT-2957-1 10 Dec 2025

moved

LEAHI-APPLICATION-LDT-2957-1 10 Dec 2025

statusColor is so general, but is bound to the heparinStatusColor.
Please either change the status color to be heparin only or change the heparinStatus Color name to be more general.
The latter is better.

LEAHI-TESTSUITES-LDT-2278-1 11 Dec 2025

Renamed the function setObjectText

LEAHI-DD-FIRMWARE-LDT-2185-1 12 Dec 2025

fixed it

LEAHI-TESTSUITES-LDT-2174-1 11 Dec 2025

remove and add delay i waitForObjectExists if needed

LEAHI-DD-FIRMWARE-LDT-2185-1 11 Dec 2025

Add blank line before return statement

LEAHI-DD-FIRMWARE-LDT-2185-1 11 Dec 2025

Need to remove this handler

LEAHI-TD-FIRMWARE-LDT-1886-1 15 Dec 2025

Not sure how Doxygen will handle this comment between the /// and the const. I think we should remove it.

LEAHI-TD-FIRMWARE-LDT-1886-1 11 Dec 2025

let public function on top

LEAHI-APPLICATION-LDT-3046-1 18 Dec 2025

updated

TEENSY-BOARD-LDT-2004-6 18 Dec 2025

fixed. thanks!

LEAHI-APPLICATION-LDT-3000-1 18 Dec 2025

updated

LEAHI-DIALIN-LDT-2998-1 18 Dec 2025

Fixed

LEAHI-APPLICATION-LDT-3000-1 17 Dec 2025

keep lock button enabled and update logic

LEAHI-APPLICATION-LDT-3000-1 17 Dec 2025

revert cancel button to older design

LEAHI-APPLICATION-LDT-2825-1 17 Dec 2025

revert