•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-2004-9 14 Apr 2026

Remove blank line.

LEAHI-APPLICATION-LDT-2686-1 28 Oct 2025

RESOLVED

LEAHI-APPLICATION-LDT-2686-1 28 Oct 2025

RESOLVED

LEAHI-TESTSUITES-LDT-1057-1 29 Oct 2025

We're using this method specifically in this file, so for now it will remain in test.py

LEAHI-APPLICATION-LDT-3656-1 17 Apr 2026

updated

LEAHI-APPLICATION-LDT-2707-1 15 Apr 2026

Remove this and register with others.

LEAHI-RO-FIRMWARE-LDT-2116-1 28 Oct 2025

Align comments spacing

LEAHI-TESTSUITES-LDT-1057-1 29 Oct 2025
  • startApplication method is moved to def main() function.
  • '-l' is removed and added '-q'
LEAHI-TESTSUITES-LDT-1057-1 27 Oct 2025

I would move this in the application_init.py

LEAHI-APPLICATION-LDT-3757-1 17 Apr 2026

RESOLVED.

LEAHI-TESTSUITES-LDT-1218-1 27 Oct 2025

It was a good idea to create the get_object_from_names function as a wrapper for the waitForObjectExists.
If it is created as a wrapper for this function call, shouldn't we use that?
If you do not plan to use it (or have any issues), please remove the get_object_from_names function.

LEAHI-APPLICATION-LDT-3800-1 17 Apr 2026

RESOLVED

LEAHI-DD-FIRMWARE-LDT-2004-1 04 Nov 2025

We typically initialize variables in the init function and not in declaration.

LEAHI-TD-FIRMWARE-LDT-3959-1 21 Apr 2026

I think minimum samples would be for max rate (500 mL/min), so 3 secs at 20 Hz = 60 samples.

LEAHI-TD-FIRMWARE-LDT-4149-1 27 Jul 2026

The driver is already included in Valves.h, so we don't need it here.

LEAHI-TD-FIRMWARE-LDT-2240-1 20 Apr 2026

Alphabetize

LEAHI-TD-FIRMWARE-LDT-2240-1 20 Apr 2026

Don't need reason. Need modality.

LEAHI-TD-FIRMWARE-LDT-1886-2 26 Apr 2026

Remove blank line.

LEAHI-TD-FIRMWARE-LDT-4149-1 27 Jul 2026

Use a /// comment so doxygen sees it.

LEAHI-TD-FIRMWARE-LDT-4149-1 27 Jul 2026

Missing /// comment.

LEAHI-TD-FIRMWARE-LDT-4149-1 27 Jul 2026

Move this to right after valves controller exec below.

LEAHI-DD-FIRMWARE-LDT-4410-3 27 Jul 2026

updated in staging

LEAHI-TD-FIRMWARE-LDT-4040-1 23 Jul 2026

break this line

LEAHI-TD-FIRMWARE-LDT-4040-1 23 Jul 2026

Initialize in init.

LEAHI-DD-FIRMWARE-LDT-4049-1 27 Jul 2026

you need to bring in the new set of valves here as well.

LEAHI-DD-FIRMWARE-LDT-4500-1 24 Jul 2026

Could you use SpentChamberLevel here, instead calling the getLevelStatus function again? Same for next conditions check as well ( line:889)

LEAHI-DD-FIRMWARE-LDT-2004-9 14 Apr 2026

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-3218-4 15 Apr 2026

nope. removed.

LEAHI-APPLICATION-LDT-3757-1 15 Apr 2026

remove =0

LEAHI-APPLICATION-LDT-3800-1 17 Apr 2026

not needed since i set it on the outside

LEAHI-APPLICATION-LDT-3800-1 17 Apr 2026

RESOLVED

LEAHI-DD-FIRMWARE-LDT-3984-1 20 Apr 2026

fixed

LEAHI-TD-FIRMWARE-LDT-3959-1 21 Apr 2026

noted.

LEAHI-APPLICATION-LDT-2666-1 28 Oct 2025

Remove binding, translation requires a system reset.

LEAHI-TESTSUITES-LDT-1057-1 03 Nov 2025

Updated as suggested.

LEAHI-TESTSUITES-LDT-1057-1 29 Oct 2025

lets try and avoid using the occurrence property and instead get the parent object which should be a TouchGrid qml component then find the children and find the object in the grid by testing theText property of the child object "Export Logs"

LEAHI-TD-FIRMWARE-LDT-1886-2 22 Apr 2026

give BP home command and zero timer counter here.

LEAHI-TD-FIRMWARE-LDT-1886-2 22 Apr 2026

Better to home BP on your way out of previous state so you don't have to use a cmd issued flag.
Ejector should already be retracted, so I see no reason to home the ejector here.
You should also zero the autoEjectTimerCounter too.

LEAHI-RO-FIRMWARE-LDT-2116-1 28 Oct 2025

Safe to define a const and used it here instead of passing 700

HD-DENBUG-326-1 03 Nov 2025

RESOLVED IN CODE WALKTHROUGH.

LEAHI-TESTSUITES-LDT-1218-1 27 Oct 2025

The application should be called by -q switch; otherwise, if you don't pet it (ACK), it will display alarm 100.
How did you overcome that issue?

LEAHI-RO-FIRMWARE-LDT-2116-1 03 Nov 2025

Consider doing this manual control in a function and call it from here.

LEAHI-TD-FIRMWARE-LDT-4505-1 27 Jul 2026

Add a blank line between declarations and code.

LEAHI-DD-FIRMWARE-LDT-3978-1 27 Apr 2026

looks you are already checking this state in a line above.

LEAHI-TD-FIRMWARE-LDT-2240-1 26 Apr 2026

start state function has same description as wait for door close state function. We shouldn't need 2 states to ensure door is closed.

LEAHI-TD-FIRMWARE-LDT-4149-1 27 Jul 2026

Remove blank line.

LEAHI-DD-FIRMWARE-LDT-3735-1 27 Jul 2026

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

LEAHI-TESTSUITES-LDT-3447-1 28 Jul 2026

Report is attached in jira

LEAHI-TD-FIRMWARE-LDT-4063-1 28 Jul 2026

Updated to remove the return from the middle of the function. The function now sets newID and returns only once at the end. Retested successfully.

LEAHI-TD-FIRMWARE-LDT-4063-1 24 Jul 2026

Can't return in middle of function code.