•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-TD-FIRMWARE-LDT-1886-1 17 Dec 2025

Done

TEENSY-BOARD-LDT-2004-6 18 Dec 2025

fixed. thanks!

LEAHI-APPLICATION-LDT-3046-1 17 Dec 2025

Feature Configurations to match system.conf

LEAHI-DD-FIRMWARE-LDT-2004-3 15 Dec 2025

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-2004-3 11 Dec 2025

Remove extra spaces between { and msg name.

LEAHI-DD-FIRMWARE-LDT-2004-3 04 Dec 2025

Why FP? I don't see FP prefixed s/w faults in the enum.

LEAHI-DD-FIRMWARE-LDT-2004-3 04 Dec 2025

Remove extra blank line.

LEAHI-DIALIN-LDT-2998-1 18 Dec 2025

like D63 level sensor, please add D98 level sensor throughout the units. Keep naming as D98_LEVEL ( instead of D98_COND)

LEAHI-DD-FIRMWARE-LDT-2936-1 02 Dec 2025

Fixed.

LEAHI-DD-FIRMWARE-LDT-2936-1 02 Dec 2025

Fixed.

LEAHI-DD-FIRMWARE-LDT-618-2 04 Dec 2025

Noted.

LEAHI-DD-FIRMWARE-LDT-618-2 04 Dec 2025

( TRUE == isTestingActivated() ) && ( ovType != OVERRIDE_INVALID ) && ( ovType < NUM_OF_OVERRIDE_TYPES ) conditions are not needed because the override functions check them already.

LEAHI-DD-FIRMWARE-LDT-2185-1 12 Dec 2025

fixed it

LEAHI-TESTSUITES-LDT-2278-1 05 Dec 2025

Removed all the waits

LEAHI-DD-FIRMWARE-LDT-618-2 04 Dec 2025

Typically we name this last one starting with "NUM_OF_" to help differentiate from the real enums (i.e. this one is just a count).

LEAHI-DD-FIRMWARE-LDT-618-2 04 Dec 2025

In comments, we don't need to call attention to the fact that these can be overridden. Their primary purpose is to be the TD supplied treatment parameters. The fact that they can be overridden by Dialin is just an extra. Just write a normal comment.

LEAHI-TESTSUITES-LDT-1036-1 03 Dec 2025

move this method outside to a shared functions file

LEAHI-TESTSUITES-LDT-2278-1 03 Dec 2025

remove waits

LEAHI-DD-FIRMWARE-LDT-2004-3 08 Dec 2025

Done.

LEAHI-DIALIN-LDT-618-1 08 Dec 2025

Updated.

LEAHI-DD-FIRMWARE-LDT-2185-1 12 Dec 2025

removed

LEAHI-SW-SCRIPTS-LDT-2727-1 10 Dec 2025

This does not entirely follow the standard.
But it is fine since we do not have the Bluetooth feature implemented yet.
Standard format example

LEAHI-APPLICATION-LDT-2957-1 10 Dec 2025

pop(null) will unwind the stack and go back to main treatment. I tested and added a comment in code as well

LEAHI-APPLICATION-LDT-3000-1 18 Dec 2025

done

LEAHI-TESTSUITES-LDT-2278-1 10 Dec 2025

In stagin the function name is setObjectText please update to avoid conflicts

LEAHI-DD-FIRMWARE-LDT-2185-1 12 Dec 2025

added

LEAHI-APPLICATION-LDT-2727-1 10 Dec 2025

No Action For Now:
Please always use mError, since it is local to the script function, to be consistent with the rest.
Also, usually it is a number, not a bool.

It is fine for now, but later we should create a decorator to cover these types of similarities.

LEAHI-DD-FIRMWARE-LDT-2185-1 12 Dec 2025

added comments

LEAHI-DD-FIRMWARE-LDT-2185-1 11 Dec 2025

Add space before ).

LEAHI-RO-FIRMWARE-LDT-2116-1 18 Dec 2025

Update inputs/outputs.

LEAHI-DD-FIRMWARE-LDT-2185-1 16 Dec 2025

Fixed

LEAHI-TD-FIRMWARE-LDT-1886-1 16 Dec 2025

No. It is permanent, I would like to know the value for the homing.

LEAHI-DD-FIRMWARE-LDT-2185-1 12 Dec 2025

implement an API in RinsePump and call that API.

LEAHI-DIALIN-LDT-1886-2 18 Dec 2025

Aren't these fields are for 4 byte range? The integer is just 1 byte

LEAHI-APPLICATION-LDT-3046-1 17 Dec 2025

change title to "Feature Configurations" and put items below all plus RO

LEAHI-APPLICATION-LDT-3000-1 17 Dec 2025

same as above

LEAHI-APPLICATION-LDT-2825-1 17 Dec 2025

Use PROPERTY

LEAHI-APPLICATION-LDT-2825-1 17 Dec 2025

add "..." for ocntinuatoin

LEAHI-TESTSUITES-LDT-2278-1 11 Dec 2025

responses are only after requests. Manually entering vitals is not a request so a response from FW will never hapen. This test is invalid.

Please Update to request first then reject when popup is open and that will satisfy https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2278-1#c25754

LEAHI-RO-FIRMWARE-LDT-2116-1 18 Dec 2025

roRejectionRatio is an input.

LEAHI-DD-FIRMWARE-LDT-2936-1 02 Dec 2025

Fixed.

LEAHI-TESTSUITES-LDT-1454-1 09 Dec 2025

Added the test case in suite.conf

LEAHI-TD-FIRMWARE-LDT-473-1 02 Dec 2025

We don't need an else here. We already set state to Rx state in declaration above.

LEAHI-TESTSUITES-LDT-1078-1 03 Dec 2025

move outside as its used in another test case and update other test case

LEAHI-TESTSUITES-LDT-2174-1 03 Dec 2025

Added the step to check right arrow is disabled

LEAHI-DD-FIRMWARE-LDT-2936-1 03 Dec 2025

Done in individual units publish functions.

LEAHI-TD-FIRMWARE-LDT-473-1 05 Dec 2025

Removed and Updated

LEAHI-TD-FIRMWARE-LDT-473-1 08 Dec 2025

Add a blank line between declaration and if statement.

LEAHI-TESTSUITES-LDT-2174-1 04 Dec 2025

Method is moved to utility.py file

LEAHI-DD-FIRMWARE-LDT-2936-1 04 Dec 2025

Fixed. Thanks