•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-3757-1 16 Apr 2026

updated

LEAHI-APPLICATION-LDT-2707-1 17 Apr 2026

RESOLVED.

LEAHI-APPLICATION-LDT-3757-1 15 Apr 2026

remove comment

LEAHI-APPLICATION-LDT-3757-1 15 Apr 2026

remove commented

LEAHI-TESTSUITES-LDT-1057-1 29 Oct 2025

Updated as suggested.

LEAHI-DIALIN-LDT-2658-2 27 Oct 2025

Dara Navaei please advise

LEAHI-TESTSUITES-LDT-1218-1 28 Oct 2025

Added test.startSection() and test.endSection() for the Pressures.

LEAHI-APPLICATION-LDT-2686-1 28 Oct 2025

RESOLVED

LEAHI-APPLICATION-LDT-2686-1 28 Oct 2025

RESOLVED

LEAHI-APPLICATION-LDT-2686-1 28 Oct 2025

RESOLVED

LEAHI-TD-FIRMWARE-LDT-2240-1 26 Apr 2026

I meant that you should move this function up, not init function down.

LEAHI-APPLICATION-LDT-2686-1 28 Oct 2025

RESOLVED

LEAHI-APPLICATION-LDT-2686-1 28 Oct 2025

RESOLVED

LEAHI-APPLICATION-LDT-2666-1 30 Oct 2025

Updated.

LEAHI-APPLICATION-LDT-4979-8 20 Jul 2026

RESOLVED

LEAHI-TESTSUITES-LDT-2174-1 05 Nov 2025

Please remove all object that are not used for treatment parameters

LEAHI-TESTSUITES-LDT-1057-1 27 Oct 2025

Shouldn't it be better defined in utility.py, or application_init.py?

LEAHI-TESTSUITES-LDT-1057-1 27 Oct 2025

why is this line here?

LEAHI-TESTSUITES-LDT-1057-1 27 Oct 2025

Could you remind me what the difference is between this one, "exportLogsText", and the one in line 29, "settingsHomeExportLogs".

LEAHI-TESTSUITES-LDT-1057-1 27 Oct 2025

Do not use "text" to identify the object; once translated, it cannot be found anymore.

TD-LDT-1886-7 08 Nov 2025

Done

LEAHI-TD-FIRMWARE-LDT-4040-1 23 Jul 2026

add rinsebackPublishTimerCtr to outputs

LEAHI-TD-FIRMWARE-LDT-4040-1 23 Jul 2026

break this line : one variable per line will be easy to read.

LEAHI-DD-FIRMWARE-LDT-4500-1 27 Jul 2026

Add blank line before banner.

LEAHI-DD-FIRMWARE-LDT-4500-1 24 Jul 2026

Remove empty lines

LEAHI-APPLICATION-LDT-2666-1 28 Oct 2025

Fix objectName.

DG-DENBUG-327-1 30 Oct 2025

Done

LEAHI-RO-FIRMWARE-LDT-2116-1 03 Nov 2025

fixed. Thanks!

LEAHI-TESTSUITES-LDT-1057-1 29 Oct 2025

The Objects have been updated for clarity:

exportLogsText → o_ExportLogsPageTitleText (refers to the Export Log page title)

settingsHomeExportLogs → o_DeviceSettingsTitleText (refers to the Export Log text on the Device Settings page)

LEAHI-RO-FIRMWARE-LDT-2116-1 03 Nov 2025

fixed. thanks!

LEAHI-DD-FIRMWARE-LDT-2004-1 04 Nov 2025

Do we need to add any functions to Comm.c?

LEAHI-RO-FIRMWARE-LDT-2116-1 29 Oct 2025

Space between if and (.

LEAHI-TESTSUITES-LDT-1218-1 27 Oct 2025

It is so important that the simulator should never run in parallel with your tests.

LEAHI-DD-FIRMWARE-LDT-4410-3 20 Jul 2026

Remove the TODO comment.

LEAHI-TD-FIRMWARE-LDT-4063-1 21 Jul 2026

output is none

LEAHI-DD-FIRMWARE-LDT-2004-1 04 Nov 2025

Should this be in the Teensy driver? Why is it here?

LEAHI-TD-FIRMWARE-LDT-4049-1 20 Jul 2026

Remove

LEAHI-TD-FIRMWARE-LDT-4149-1 27 Jul 2026

Remove extra blank line.

LEAHI-TD-FIRMWARE-LDT-4149-1 27 Jul 2026

Remove extra blank line.

LEAHI-TD-FIRMWARE-LDT-4149-1 27 Jul 2026

Remove this comment?

LEAHI-DD-FIRMWARE-LDT-4410-3 27 Jul 2026

defined as suggested

LEAHI-DD-FIRMWARE-LDT-4410-3 26 Jul 2026

This is a problem, when lower cart pressure, D80 closes and if it is not reached upper cart pressure, it won't open D80

LEAHI-DIALIN-LDT-5246-1 28 Jul 2026

reviewed on Vm with BN

LEAHI-DD-FIRMWARE-LDT-4500-1 24 Jul 2026

Remove extra paranthesis.

LEAHI-TESTSUITES-LDT-1218-1 23 Oct 2025

For this lets not get 2 of the same object. For this if the "text" property that is going to be tested get the parent object instead and use that to test..

try:

 treatmentTimeNotificationBarSmall = {"container": mainTreatmentScreen, "objectName": "notification", "type": "NotificationBarSmall"} 


then use that "text" property of that parent object to test

LEAHI-TESTSUITES-LDT-1057-1 30 Oct 2025

That is fine for now, but please think ahead and move it as soon as you have used it elsewhere.
Also, by moving it to a more general place, others will notice and use it, instead of duplicating.

LEAHI-APPLICATION-LDT-2666-1 28 Oct 2025

Add '_' to objectName.

LEAHI-APPLICATION-LDT-2666-1 30 Oct 2025

Updated.

LEAHI-RO-FIRMWARE-LDT-2116-1 29 Oct 2025

Keep blank line between functions.

LEAHI-DD-FIRMWARE-LDT-2004-9 14 Apr 2026

Not clear what GENMASK is doing. What do h and l refer to. This doesn't look like a simple bit mask.