Even though we are giving the type a name at the bottom of the enum, we typically still want to give the enum a name up top here. See other enums throughout code for examples.
when I get the version with python3 version.py it will show the correct branch and commit version instead of just 1.0.0, which tells nothing. I use this when they ask what version of dialin I have, as I know the branch, but not the commit version, and it's faster with this then asking git around.
Is this always needed or is it only needed in one or more specific modes (i.e. gen dialysate mode)? If only needed in specific modes, I think this should be called from those modes (similar to BC exec).
Thanks for catching that. Yes, this was an accidental change on my part. I’ll revert it and proceed with deleting ModeTxParams.c and the related header files as suggested.
ive noticed this common method being used in other test cases. If its a general method that is used throughout please move outside in a shared file and call from there. Please update other repositories that use this as well.