•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-3978-1 26 Apr 2026

Remove blank line.

LEAHI-TD-FIRMWARE-LDT-2240-1 26 Apr 2026

Leahi doesn't have occlusion sensor, so don't need this if statement. Not sure we need this start state. Maybe we can start in the wait for door close state.

LEAHI-DD-FIRMWARE-LDT-4500-1 27 Jul 2026

We are checking level status 3 times in same function. So Vinay suggested to use local variable to avoid the inconsistent states across the function.

LEAHI-DD-FIRMWARE-LDT-4410-3 27 Jul 2026

the variable was renamed and the new ones have 0.0F

LEAHI-DD-FIRMWARE-LDT-4410-3 27 Jul 2026

We made an implementation in such a way that when D65 is opened, D80 needs to be closed. Same way D80 is opened, D65 to be closed.

LEAHI-TD-FIRMWARE-LDT-4031-1 28 Jul 2026

Add @Message

LEAHI-TESTSUITES-LDT-3447-1 24 Jul 2026

remove file

LEAHI-DD-FIRMWARE-LDT-2004-9 14 Apr 2026

Add a blank line after declarations.

LEAHI-APPLICATION-LDT-2707-1 15 Apr 2026

updated

LEAHI-APPLICATION-LDT-3656-1 17 Apr 2026

updated

LEAHI-TESTSUITES-LDT-1218-1 28 Oct 2025

Added -q switch for startApplication method as requested, but we never faced any alarm issue.

LEAHI-APPLICATION-LDT-3757-1 15 Apr 2026

add todo comment to check during integration

LEAHI-TESTSUITES-LDT-1057-1 29 Oct 2025

moved to application_init.py

LEAHI-APPLICATION-LDT-2666-1 30 Oct 2025

Updated.

LEAHI-TESTSUITES-LDT-1057-1 27 Oct 2025

All the object names shall start with '_'.
Please update when fixed on the SW.
Nicholas Ramirez, as we talked, that should be updated when we have a chance, thanks.
It is fine if we address this later.

LEAHI-APPLICATION-LDT-2666-1 28 Oct 2025

Do not worry about getting responses out of order.
Just clear text if accepted, otherwise assign text.

LEAHI-RO-FIRMWARE-LDT-2116-1 03 Nov 2025

fixed. Thanks!

LEAHI-RO-FIRMWARE-LDT-2116-1 03 Nov 2025

fixed. Thanks!

LEAHI-RO-FIRMWARE-LDT-1773-1 03 Nov 2025

fixed. thanks!

LEAHI-DD-FIRMWARE-LDT-3980-1 21 Apr 2026

This code looks very similar to bicarb code above. Do we really need separate handling?

LEAHI-DIALIN-LDT-3984-1 28 Apr 2026

LEVEL_OFFSET?

LEAHI-TD-FIRMWARE-LDT-1886-2 22 Apr 2026

Does this message need a BOOL? Will UI ever send this message with a FALSE? Check with Nico on this.

LEAHI-TD-FIRMWARE-LDT-3959-1 21 Apr 2026

removed and used default value as they are the same.

LEAHI-TD-FIRMWARE-LDT-4040-1 23 Jul 2026

break this line

LEAHI-DD-FIRMWARE-LDT-4049-1 27 Jul 2026

We don't have a specific DD permeate sample mode implementation yet. We need to align with Michael on this. Looks FP may need a mode to handle permeate request (if FP was not in gen permeate mode by TD request already).

LEAHI-TD-FIRMWARE-LDT-3959-1 21 Apr 2026

PRODUCT should probably come before FILTER_SAMPLES above so that it can be used in that definition.
Show derivation again. i.e. (500 * 3) indicating we want 3 seconds of filter duration for 500 mL/min rate and duration grows as rate is reduced.

LEAHI-DD-FIRMWARE-LDT-3978-1 27 Apr 2026

Remove space after 'Supply'.

LEAHI-DD-FIRMWARE-LDT-2004-1 04 Nov 2025

Where are we including the conductivity driver? Expecting a build switch (#ifdef) that selects which driver we are including.

LEAHI-RO-FIRMWARE-LDT-2116-1 03 Nov 2025

Remove blank line.

LEAHI-DD-FIRMWARE-LDT-2004-1 04 Nov 2025

Is the "readConductivitySensors()" call above for the FPGA based driver we will have later? Should we only do one or the other based on build switch?

LEAHI-DD-FIRMWARE-LDT-2004-1 04 Nov 2025

Put these 2 cases in a #ifdef USE_TEENSY_CONDUCTIVITY build switch so only included in build if we're using the Teensy board.

LEAHI-TD-FIRMWARE-LDT-3970-1 03 May 2026

I don't think we should change this.

LEAHI-DD-FIRMWARE-LDT-3978-1 26 Apr 2026

Remove blank line.

LEAHI-DIALIN-LDT-3505-1 07 May 2026

please use the generic_override function from the common folder

LEAHI-APPLICATION-LDT-3932-1 06 May 2026

removed demo code

LEAHI-TD-FIRMWARE-LDT-3970-1 05 May 2026

use response.duration.

LEAHI-TD-FIRMWARE-LDT-3970-1 05 May 2026

use response.x for these.

LEAHI-TD-FIRMWARE-LDT-2240-1 05 May 2026

use separate time than stability (even if same right now).

LEAHI-TD-FIRMWARE-LDT-2240-1 05 May 2026

Don't want to start air trap control. Want to turn on the air pump at max power (100.0%)

LEAHI-TD-FIRMWARE-LDT-2240-1 26 Apr 2026

Need to request syringe pump to start a seek before we go to seek state. It's not implemented yet, so just put a TODO comment for now.

LEAHI-DD-FIRMWARE-LDT-3963-1 05 May 2026

Check the else portion and do the required changes.

LEAHI-TESTSUITES-LDT-3447-1 24 Jul 2026

the update to this file should be part of this branch

https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-3670-1

LEAHI-TD-FIRMWARE-LDT-4149-1 27 Jul 2026

I think we should have handle functions that return next state for each of these cases (just like mode state machines).

LEAHI-TD-FIRMWARE-LDT-4149-1 27 Jul 2026

Restore this.

LEAHI-TD-FIRMWARE-LDT-4149-1 27 Jul 2026

Why is home command commented out?

LEAHI-TD-FIRMWARE-LDT-4031-1 27 Jul 2026

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-4410-3 27 Jul 2026

updated

LEAHI-DD-FIRMWARE-LDT-2004-9 14 Apr 2026

Remove this blank line.

LEAHI-TESTSUITES-LDT-1218-1 28 Oct 2025

Updated get_object_from_names function as a wrapper for the waitForObjectExists.

LEAHI-APPLICATION-LDT-2686-1 28 Oct 2025

RESOLVED