•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-618-2 04 Dec 2025

Even though we are giving the type a name at the bottom of the enum, we typically still want to give the enum a name up top here. See other enums throughout code for examples.

LEAHI-TD-FIRMWARE-LDT-473-1 02 Dec 2025

Get function for rejected is not needed?

LEAHI-TESTSUITES-LDT-2174-1 08 Dec 2025

Verify the active property of heprain stop time

LEAHI-TESTSUITES-LDT-2174-1 08 Dec 2025

Check the QR code visible property

LEAHI-DD-FIRMWARE-LDT-2936-1 03 Dec 2025

Small letter used

LEAHI-DD-FIRMWARE-LDT-2004-3 08 Dec 2025

Done.

LEAHI-TESTSUITES-LDT-2278-1 11 Dec 2025

reason

LEAHI-DIALIN-LDT-598-2 10 Dec 2025

when I get the version with python3 version.py it will show the correct branch and commit version instead of just 1.0.0, which tells nothing.
I use this when they ask what version of dialin I have, as I know the branch, but not the commit version, and it's faster with this then asking git around.

LEAHI-TESTSUITES-LDT-2174-1 05 Dec 2025

test the active property test.compare(heprain_Stop_time.isActive,False, "Heprain stop time active property is set to False")

LEAHI-APPLICATION-LDT-2957-1 10 Dec 2025

done

LEAHI-TESTSUITES-LDT-1454-1 11 Dec 2025

Renamed the function has setObjectText

LEAHI-DD-FIRMWARE-LDT-2030-2 11 Dec 2025

I think you are seeing previous commit. It is not there in the present code.

LEAHI-RO-FIRMWARE-LDT-2116-1 08 Dec 2025

comments should start with capital letter

LEAHI-TESTSUITES-LDT-1802-1 12 Dec 2025

Shouldn't this function be defined in a more general location/file?
And same comment here to be aware of the translation flexibility for later.

LEAHI-DD-FIRMWARE-LDT-2185-1 11 Dec 2025

Call this in both Pre Gen: Verify Water and Gen Permeate

LEAHI-TD-FIRMWARE-LDT-473-1 16 Dec 2025

Deleted.

LEAHI-DD-FIRMWARE-LDT-2185-1 12 Dec 2025

Something like this
( QUADRATIC_COEFFICIENT * ( pressureP13 * pressureP13 ) ) - ( LINEAR_COEFFICIENT * ( pressureP13 ) ) + CONSTANT_TERM;

LEAHI-DD-FIRMWARE-LDT-2185-1 15 Dec 2025

it can be directly initialized

LEAHI-DD-FIRMWARE-LDT-2185-1 16 Dec 2025

Updated

LEAHI-DD-FIRMWARE-LDT-2185-1 16 Dec 2025

Removed

LEAHI-DD-FIRMWARE-LDT-2185-1 12 Dec 2025

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-2185-1 18 Dec 2025

Can we remove this code?

LEAHI-APPLICATION-LDT-3046-1 18 Dec 2025

updated to false

LEAHI-APPLICATION-LDT-3000-1 18 Dec 2025

updated logic

LEAHI-TD-FIRMWARE-LDT-1886-1 16 Dec 2025

This if should have an else where we zero .valveOpsStartTime (in case it briefly got set but then failed this if before timeout).

LEAHI-DD-FIRMWARE-LDT-2004-3 11 Dec 2025

Is this temporary? If so, put a TODO to remove later.

LEAHI-TESTSUITES-LDT-2278-1 19 Dec 2025

updated

LEAHI-APPLICATION-LDT-3000-1 17 Dec 2025

enable lock icon

LEAHI-APPLICATION-LDT-3000-1 17 Dec 2025

add comment

LEAHI-DD-FIRMWARE-LDT-2004-3 11 Dec 2025

Is this always needed or is it only needed in one or more specific modes (i.e. gen dialysate mode)? If only needed in specific modes, I think this should be called from those modes (similar to BC exec).

LEAHI-TESTSUITES-LDT-1454-1 10 Dec 2025

in staging the function name is setObjectText() please be consistant

LEAHI-DD-FIRMWARE-LDT-2936-1 02 Dec 2025

Fixed.

LEAHI-DD-FIRMWARE-LDT-2936-1 02 Dec 2025

Fixed.

LEAHI-TD-FIRMWARE-LDT-473-1 02 Dec 2025

Thanks for catching that. Yes, this was an accidental change on my part. I’ll revert it and proceed with deleting ModeTxParams.c and the related header files as suggested.

LEAHI-DD-FIRMWARE-LDT-618-2 04 Dec 2025

Yeah, I removed this.

LEAHI-TESTSUITES-LDT-2278-1 05 Dec 2025

Moved this function into utility.py file

LEAHI-TESTSUITES-LDT-2278-1 05 Dec 2025

removed the waits as per suggestion

LEAHI-TESTSUITES-LDT-1078-1 03 Dec 2025

ive noticed this common method being used in other test cases. If its a general method that is used throughout please move outside in a shared file and call from there. Please update other repositories that use this as well.

LEAHI-TESTSUITES-LDT-2174-1 02 Dec 2025

why 10 second wait? We shouldnt need any additional delays. If you need a delay or wait for an object we should better be using waitForObject()

LEAHI-TD-FIRMWARE-LDT-473-1 05 Dec 2025

Updated

LEAHI-TD-FIRMWARE-LDT-473-1 05 Dec 2025

Updated

LEAHI-TESTSUITES-LDT-2174-1 07 Dec 2025

Comment block is added to all the functions

LEAHI-APPLICATION-LDT-2957-1 10 Dec 2025

updated to statusColor

LEAHI-TESTSUITES-LDT-1802-1 10 Dec 2025

all the test cases need ot be listed here. Only add on your new test case and do not remove the others

LEAHI-TESTSUITES-LDT-2174-1 11 Dec 2025

Removed the commented lines

LEAHI-DD-FIRMWARE-LDT-2185-1 11 Dec 2025

What are these coefficients for? At least describe in comments, if not the names.

LEAHI-DD-FIRMWARE-LDT-2185-1 11 Dec 2025

Update FP_Pre_GenP_Def_Mode_States enum in FPDefs.h

LEAHI-TESTSUITES-LDT-2278-1 11 Dec 2025

instead of wait wait for o_vitalCountdown_Text property to be visible

LEAHI-DD-FIRMWARE-LDT-2004-2 16 Dec 2025

As per Sean's comment mark it as resolved

LEAHI-APPLICATION-LDT-2707-1 16 Dec 2025

whats this condition for?