•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-2666-1 28 Oct 2025

Same as above.
Update text only.

LEAHI-DD-FIRMWARE-LDT-2004-9 14 Apr 2026

nr means short form of bit 'number', unsigned long is portable, 32bit for 32-bit cpu and 64 bits for 64bit cpu whereas unsigned int is always 32 bits regardless of architecture.

TD-LDT-1886-7 29 Sep 2025

Add a posD.

LEAHI-RO-FIRMWARE-LDT-2116-1 03 Nov 2025

Add blank line between declarations and rest of code.

LEAHI-TESTSUITES-LDT-3153-1 30 Apr 2026

Added test.fail as per comment

LEAHI-TESTSUITES-LDT-2951-1 28 Apr 2026

you need to go to Treatment mode then change the treatmetn state

LEAHI-APPLICATION-LDT-3757-1 16 Apr 2026

updated

LEAHI-APPLICATION-LDT-2707-1 15 Apr 2026

Remove and test to ensure model is not garbage collected in QML.

LEAHI-APPLICATION-LDT-2707-1 15 Apr 2026

Switch back to signals.

LEAHI-APPLICATION-LDT-3757-1 17 Apr 2026

RESOLVED.

LEAHI-APPLICATION-LDT-3800-1 17 Apr 2026

RESOLVED

LEAHI-DD-FIRMWARE-LDT-3749-2 21 Apr 2026

Updated

LEAHI-TESTSUITES-LDT-2741-1 21 Apr 2026

RESOLVED.

LEAHI-TD-FIRMWARE-LDT-473-3 15 Apr 2026

DO we need bicarb conversion factor as well?

LEAHI-APPLICATION-LDT-3932-1 22 Apr 2026

updated

LEAHI-TD-FIRMWARE-LDT-3959-1 21 Apr 2026

Are we filtering at zero set rate? I guess we should, so then the duration would be 1 sec then?

LEAHI-APPLICATION-LDT-3932-1 05 May 2026

remove demo code

LEAHI-DIALIN-LDT-3984-1 28 Apr 2026

Why increment the number when you didn't add a new sensor?

LEAHI-DD-FIRMWARE-LDT-4183-1 05 May 2026

There should be a \b before the type of details (Inputs and Outputs here) for documentation
Inputs: None?

LEAHI-TD-FIRMWARE-LDT-4188-1 30 Apr 2026

we are sending a message ack as response in the handler of this message request

LEAHI-TD-FIRMWARE-LDT-4188-1 30 Apr 2026

Why is this in TDCommon? It should probably be in MessagePayloads.h or DDDefs.h so both DD and TD f/w can share this payload structure. And the common definitions should be added to appropriate doxygen group.

LEAHI-TD-FIRMWARE-LDT-4188-1 30 Apr 2026

What TD does with UF rate is mostly to tell DD what rate we want. DD wants mL/min. TD can keep L/hr and convert to mL/min every time it needs to send DD a message or it can keep mL/min and convert to L/hr every time it needs to send UI a message. Either way works for me.

TD-LDT-1886-7 07 Nov 2025

Done

LEAHI-TD-FIRMWARE-LDT-4040-1 23 Jul 2026

recircPublishTimerCtr is an output

LEAHI-TD-FIRMWARE-LDT-4040-1 23 Jul 2026

Add @Alarms

LEAHI-TD-FIRMWARE-LDT-1886-2 03 May 2026

We don't have to align =, but if you're going to have all of these spaces before the =, you should align.

LEAHI-TD-FIRMWARE-LDT-1886-2 03 May 2026

Align =

LEAHI-TD-FIRMWARE-LDT-1886-2 03 May 2026

Consider separating the wait for door close to another state.

LEAHI-TD-FIRMWARE-LDT-4188-1 02 May 2026

we don't need pragma alignment on enums, could you exclude it ?

LEAHI-TD-FIRMWARE-LDT-1886-2 05 May 2026

I prefer you create a local BOOL result so you can have a simpler return statement.

LEAHI-TD-FIRMWARE-LDT-1886-2 05 May 2026

@details \b Outputs:
Please make sure to update all of them to Leahi format In this case, there should be a \b before the type of details (Inputs and Outputs here) so they will be bold when doxygen documentation is generated.

LEAHI-TD-FIRMWARE-LDT-1886-2 05 May 2026

change to ///< Tubing set install state

LEAHI-TD-FIRMWARE-LDT-2240-1 03 May 2026

Put before TxParams.

LEAHI-DD-FIRMWARE-LDT-3963-1 03 May 2026

Why are we removing this TODO comment? It looks like we should keep it.

LEAHI-TD-FIRMWARE-LDT-1886-2 05 May 2026

currentAutoEjectState should be input?

LEAHI-TD-FIRMWARE-LDT-2240-1 26 Apr 2026

Remove extra l at end of flag name (mis-spelled). And why are we sending this flag with scan event? Seems like the Received flag is what you want here.

LEAHI-DD-FIRMWARE-LDT-3963-1 05 May 2026

Remove this code.

LEAHI-TD-FIRMWARE-LDT-2240-1 03 May 2026

Should be in "", not <>. And should be placed alphabetically down before TxParams.h.

LEAHI-TD-FIRMWARE-LDT-2240-1 03 May 2026

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-3963-1 03 May 2026

Do we need TODO comments to restore these alarms later?

LEAHI-DD-FIRMWARE-LDT-2004-9 14 Apr 2026

a macro used to create a contiguous bitmask starting at bit position l (low) and ending at bit position h

LEAHI-TESTSUITES-LDT-1218-1 28 Oct 2025

We ensured that simulator was closed while executing the script.

LEAHI-APPLICATION-LDT-2686-1 28 Oct 2025

RESOLVED

LEAHI-APPLICATION-LDT-2686-1 28 Oct 2025

RESOLVED

LEAHI-APPLICATION-LDT-2666-1 30 Oct 2025

Updated.

LEAHI-DD-FIRMWARE-LDT-3218-4 15 Apr 2026

fixed

LEAHI-APPLICATION-LDT-2666-1 30 Oct 2025

Updated.

LEAHI-TESTSUITES-LDT-1057-1 27 Oct 2025

I would move these navigations into a py file like navigation.py to ve used in other places.

LEAHI-APPLICATION-LDT-3459-1 15 Apr 2026

Comment out, do not remove.

LEAHI-RO-FIRMWARE-LDT-2116-1 29 Oct 2025

Space between if and (.