•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-TD-FIRMWARE-LDT-4149-1 27 Jul 2026

Why commented out?

LEAHI-DD-FIRMWARE-LDT-3735-1 27 Jul 2026

Not needed because the retry mechanism is going to be deleted in the next ticket.

LEAHI-DD-FIRMWARE-LDT-3735-1 27 Jul 2026

Added but crucible is not showing this change. Please check bitbucket.

LEAHI-DD-FIRMWARE-LDT-3735-1 22 Jul 2026

Why commented out?

LEAHI-DD-FIRMWARE-LDT-4011-1 28 Jul 2026

updated with latest staging implementation.

LEAHI-DD-FIRMWARE-LDT-4011-1 28 Jul 2026

renamed

LEAHI-DD-FIRMWARE-LDT-3735-1 23 Jul 2026

Same question as above: should we alarm if the retries failed?

LEAHI-DD-FIRMWARE-LDT-4500-1 24 Jul 2026

Update the comment for Spent chamber fill, max dialysate flow rate (Qd:600) used for fast filling.

LEAHI-TD-FIRMWARE-LDT-4505-1 27 Jul 2026

Remove extra blank line.

LEAHI-TD-FIRMWARE-LDT-1886-2 22 Apr 2026

You should send response regardless of success - so I think this should be moved to the very end of the function, outside of any if statements so that it always responds. You should set accept flag and reject reason codes in these if statements so the response that gets sent will have the correct payload.

LEAHI-APPLICATION-LDT-3757-1 15 Apr 2026

=1 (Run state)

LEAHI-TD-FIRMWARE-LDT-4040-1 23 Jul 2026

outputs is none.

LEAHI-TD-FIRMWARE-LDT-4040-1 23 Jul 2026

break into two lines

LEAHI-TD-FIRMWARE-LDT-4040-1 23 Jul 2026

Update input - output list.

LEAHI-TD-FIRMWARE-LDT-4040-1 23 Jul 2026

please add a TODO or remove commented code.

LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

if ( enableBPCuff ) then only _root.open ()

LEAHI-APPLICATION-LDT-2666-1 24 Oct 2025

Use showUnit.

LEAHI-TESTSUITES-LDT-1057-1 24 Oct 2025

1. Please add the comment block as discussed
2. Upload the test results onto https://diality.atlassian.net/browse/LDT-1059

LEAHI-DD-FIRMWARE-LDT-3218-4 14 Apr 2026

Add blank line before return.

LEAHI-DD-FIRMWARE-LDT-2004-9 15 Apr 2026

0.0F is made by Sean.

LEAHI-APPLICATION-LDT-2707-1 17 Apr 2026

RESOLVED.

LEAHI-APPLICATION-LDT-2707-1 15 Apr 2026

Create new function and leave this one alone.
Name: trendsAlarmTitlle.

LEAHI-APPLICATION-LDT-3757-1 15 Apr 2026

Match with UI title

LEAHI-APPLICATION-LDT-3656-1 15 Apr 2026

no more confirm remove text

LEAHI-DD-FIRMWARE-LDT-3735-1 22 Jul 2026

We generally don't add { } to switch cases unless they require local variable declarations.

LEAHI-DD-FIRMWARE-LDT-3984-1 17 Apr 2026

Align the comments.

LEAHI-TD-FIRMWARE-LDT-3959-1 21 Apr 2026

600 will take a lot of memory (600 x 4 bytes = 2.4K). Ok for now, but if memory gets scarce, we will have to consider sampling less frequently to reduce the size of the moving average array.

Also, show derivation of this number so it's clear what it means and how we got to 600.
i.e. ((PRODUCT / 50) * (MS_PER_SECOND / TASK_GENERAL_INTERVAL)) indicating how many samples we need to buffer for worst case which is lowest flow rate (50) requiring max duration (30 sec) at 20 Hz sample rate.

LEAHI-TESTSUITES-LDT-3153-1 24 Apr 2026

updated code as per comment

LEAHI-TD-FIRMWARE-LDT-3970-1 26 Apr 2026

Change 1 to TRUE

LEAHI-APPLICATION-LDT-3932-1 23 Apr 2026

check if we can use start() instead

LEAHI-DD-FIRMWARE-LDT-4410-3 20 Jul 2026

Vendor - TEL - Sameer PoyilWhat's the value you are recommending for?

LEAHI-DD-FIRMWARE-LDT-4410-3 26 Jul 2026

bicarbChamberLevel is a local variable and not an input

LEAHI-TD-FIRMWARE-LDT-4063-1 21 Jul 2026

add a space before and after 0

LEAHI-TD-FIRMWARE-LDT-4063-1 21 Jul 2026

this line is too long, please break it into two or more lines, if needed.

LEAHI-TD-FIRMWARE-LDT-4063-1 21 Jul 2026

macro should be before ==

LEAHI-TD-FIRMWARE-LDT-4063-1 21 Jul 2026

please add a space before and after 0 in payload[0]

LEAHI-TD-FIRMWARE-LDT-4049-1 22 Jul 2026

I think these if statements should be looking for valve state == VALVE_STATE_IDLE, not <

LEAHI-DD-FIRMWARE-LDT-3735-1 22 Jul 2026

If we're not including a timestamp, can we just remove this line of code?

LEAHI-TD-FIRMWARE-LDT-4049-1 20 Jul 2026

Why is this commented out?

LEAHI-TD-FIRMWARE-LDT-4049-1 22 Jul 2026

Why is UF volume being added here? If we add it, we need to change DD f/w too. But it is not clear to me why DD f/w needs to know the UF volume.

LEAHI-DD-FIRMWARE-LDT-4410-3 27 Jul 2026

It was changed by Vinay as part of the Conductivity spikes issue.

LEAHI-TD-FIRMWARE-LDT-4149-1 27 Jul 2026

Remove extra blank line.

LEAHI-TD-FIRMWARE-LDT-4149-1 27 Jul 2026

Remove extra blank lines.

LEAHI-TD-FIRMWARE-LDT-4149-1 27 Jul 2026

We should initialize your new driver here.

LEAHI-TD-FIRMWARE-LDT-4149-1 27 Jul 2026

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-4410-3 27 Jul 2026

That's the worst-case timeout decided by team.

LEAHI-DD-FIRMWARE-LDT-3735-1 22 Jul 2026

Remove extra blank line.

LEAHI-TD-FIRMWARE-LDT-4031-1 28 Jul 2026

break this line

LEAHI-DD-FIRMWARE-LDT-4410-3 27 Jul 2026

added accordingly

LEAHI-DD-FIRMWARE-LDT-4410-3 21 Jul 2026

0.0F(float type).