•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-4500-1 20 Jul 2026

Add a comment here to wait for BC switching to go Idle state and transition to spent chamber fill state. Also, add a space after (). Apply the same comment in the next Dialysate delivery state as well.

LEAHI-TD-FIRMWARE-LDT-4049-1 20 Jul 2026

Remove for now.

LEAHI-TD-FIRMWARE-LDT-4049-1 20 Jul 2026

Don't need this yet.

LEAHI-TD-FIRMWARE-LDT-4049-1 22 Jul 2026

Why are these added? And why commented out. H13 and H20 are not rotary valves - they are 3 way valves. They do not belong here.

LEAHI-DD-FIRMWARE-LDT-4410-3 20 Jul 2026

Can we rename this IsDryBicartChamberFillWindowOpen? ( removing BalChamber)

LEAHI-DD-FIRMWARE-LDT-4410-3 20 Jul 2026

Supply state (instead of drain). Updates Inputs and outputs across the file.

LEAHI-TESTSUITES-LDT-3946-1 15 Jul 2026

do you need to add global patientDisconnectConfirmRequest before this line?

LEAHI-DD-FIRMWARE-LDT-4500-1 20 Jul 2026

Remove blank spaces after =.

LEAHI-APPLICATION-LDT-3656-1 15 Apr 2026

update comments

LEAHI-APPLICATION-LDT-3800-1 17 Apr 2026

move into treatmenthome

LEAHI-TD-FIRMWARE-LDT-473-3 14 Apr 2026

Add blank line after declarations.

LEAHI-DD-FIRMWARE-LDT-2004-9 14 Apr 2026

removed

LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

fix icon to show no whitespace

LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

revert this and make consistant with all other labelunitcontrainers

LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

group slots at the bottom

LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

add comment for why

LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

Change to start in treatment only

LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

TRIGGER( bool , adjustment , 0 )
instead

TD-LDT-1886-7 23 Oct 2025

I think most of what's happening in this state should be done in a function in RotaryValve.c that we call from here (since it's doing very low level things that the driver should be doing).

LEAHI-DD-FIRMWARE-LDT-2004-9 14 Apr 2026

dryBicartState is top level state machine which is different data type. removed dryBicartSubstate

LEAHI-TD-FIRMWARE-LDT-3959-1 21 Apr 2026

updated and used as suggested.

LEAHI-DD-FIRMWARE-LDT-3978-1 23 Apr 2026

Remove empty line

LEAHI-DD-FIRMWARE-LDT-3777-1 14 Apr 2026

Add blank line before return.

LEAHI-DD-FIRMWARE-LDT-3777-1 14 Apr 2026

Add blank line before return.

LEAHI-DD-FIRMWARE-LDT-2004-9 14 Apr 2026

Do we need to add another else statement and address an alarm if wrong mixId is passed? or Keep only else part instead of else if ( ACID_MIX_ID == mixID) check?? this change may be needed across the file.

LEAHI-DD-FIRMWARE-LDT-3978-1 23 Apr 2026

Space before LVL_STATE_LOW

LEAHI-APPLICATION-LDT-3800-1 17 Apr 2026

updated

LEAHI-TESTSUITES-LDT-3153-1 17 Apr 2026

please just add test case to the end and not remove all the prior ones

LEAHI-TD-FIRMWARE-LDT-1886-2 22 Apr 2026

Again, ejector should have been retracted way back in pre-treatment mode. We shouldn't need to do it again.

LEAHI-TD-FIRMWARE-LDT-1886-2 20 Apr 2026

Need unique s/w malf id.

LEAHI-TD-FIRMWARE-LDT-2240-1 23 Apr 2026

Added

LEAHI-TD-FIRMWARE-LDT-1886-2 22 Apr 2026

I don't think this if statement is necessary. We wouldn't be in this state if the ejector didn't extend already.
I think we just want to see if BP is home again (completed 1 revolution) so we know when to stop and go to next state.

LEAHI-TD-FIRMWARE-LDT-1886-2 22 Apr 2026

Not necessary if you give retract command on way out of prior state.

LEAHI-TD-FIRMWARE-LDT-1886-2 22 Apr 2026

rejectionReason should be set to none (zero) here too.

LEAHI-TD-FIRMWARE-LDT-3970-1 26 Apr 2026

These are already in TxParams I believe.

LEAHI-TD-FIRMWARE-LDT-2240-1 26 Apr 2026

No occlusion sensor in Leahi. Delete variable and references to it.

LEAHI-APPLICATION-LDT-3932-1 23 Apr 2026

ScrollBarVH

LEAHI-DD-FIRMWARE-LDT-4410-3 20 Jul 2026

Update comment. remove TODO if no more applicable.

LEAHI-TD-FIRMWARE-LDT-4029-1 21 Jul 2026

I think ( setTxDur - preStop ) should be changed to ( preStop ).
Also, I think preStop should be renamed to hepDurMin.

LEAHI-APPLICATION-LDT-4979-8 20 Jul 2026

Remove M.Box column?

LEAHI-TD-FIRMWARE-LDT-4072-2 21 Jul 2026

Library includes should come first and they should be in <>. Also add comment listing math functions you're using in this unit.

LEAHI-TD-FIRMWARE-LDT-4063-1 20 Jul 2026

Need to put if condition back.

LEAHI-DD-FIRMWARE-LDT-4410-3 20 Jul 2026

I guess we should have some minimum speed as well as like max speed. Please work with Abhijit on worst case min speed.

LEAHI-DD-FIRMWARE-LDT-4410-3 20 Jul 2026

When the BC fill completed and allow opening D65 for Chamber F fill?

LEAHI-DD-FIRMWARE-LDT-4410-3 20 Jul 2026

remove all commented code.

LEAHI-TD-FIRMWARE-LDT-4063-1 20 Jul 2026

Should use GENERIC_CONFIRMATION_REQUEST_T which already exists in OperationModes.h. This should be removed.

LEAHI-TD-FIRMWARE-LDT-4063-1 21 Jul 2026

add offRequestAwaitingUserConfirmation and offRequestPendingTimer to outputs

LEAHI-TD-FIRMWARE-LDT-4063-1 21 Jul 2026

add a space before and after index 'i'

LEAHI-TD-FIRMWARE-LDT-4063-1 21 Jul 2026

Vendor - TEL - Arpita Srivastava
please add a space before and after in sizeof(U32) in [sizeof(U32)]

LEAHI-TD-FIRMWARE-LDT-4049-1 20 Jul 2026

Missing a comment.