for this do not hard code as it will only work with this specific build. Use"./leahi --version" to get the version then test that with what we display in GUI
this will not work and fail. This is build specific and will only work with the current leahi build.. Please get the version using "./leahi --version" and use that
Should we be calling a get function in Conductivity.c (monitor) instead of driver? Monitor would give a filtered value and driver would give a raw value. I would think only the monitor would want the raw value.
I think this is ok as is. We do want includes in alphabetical order, but in groups: 1) library header files, 2) HAL header files, and 3) our header files.
I don't see support for that with our compiler. Author of code must ensure destination buffer is large enough to hold the specified number of bytes being copied. Code reviewer should verify this.
bicart? Can we spell this out since this will be main description of this unit in SDD? Assuming bicart = dry bicarbonate cartridge? Also, this unit appears to control bicarb chamber - not just cartridge - so we should mention that here.
