Comment Search

change to _vitalCountdown

When are we planning to remove this?

control interval is different. Control interval must be separated else we don't get finer control on bicarb conductivity. also the dead band is different. need to figure out whether we can combine or not

Shouldn't we be assigning dryBicartState instead of dryBicartSubstate in all of these cases?

Should these be moved to Services\TxParams?

Lower case x

Say OpoMode -> Post Treatment

RESOLVED.

add liine to also check value

Door is probably not required to be closed in standby. Change to FALSE.

Not needed if you do this on way out of prior state.

We shouldn't need to do this door check if you've required door be closed for the state.
Call the doorClosedRequired( TRUE ) function on transition into a state that requires the door to be closed and call with ( FALSE ) on transition into a state that doesn't require door to be closed. When required = TRUE, the switch monitor will trigger the door open alarm for you.

Ok, but then I think the valves controller should be calling a function in this driver to accomplish this kind of thing since it's a driver level activity.

Remove Latch from name. No latch in Leahi.

1. Please add the comment block as discussed
2. Upload the test results onto https://diality.atlassian.net/browse/LDT-1220

Are we only doing DD messages?
And since these could be coming from UI now, these shouldn't be considered "Dialin" messages anymore and should be moved up to section before 0x8000 IDs where normal system messages are defined.

reverted

Can this be reused from ConcentratePumps.h?

instead of 0, we can use the level Enum 'LVL_STATE_EMPTY'?

=5 (txRecircState)

set default to true

RESOLVED>

Is this right?

Remove extra blank line.

Give ejector retract command and zero timer counter here too.