•  

Comment Results

Review Name Created Custom Fields Content
TD-LDT-1886-7 08 Nov 2025

Done

TD-LDT-1886-7 10 Nov 2025

Done

LEAHI-TESTSUITES-LDT-1650-1 06 Nov 2025

is this import needed? Import any needed items to this repo

LEAHI-DD-FIRMWARE-LDT-2004-2 12 Nov 2025

#ifdef

LEAHI-DD-FIRMWARE-LDT-2662-1 06 Nov 2025

Is it appropriate to call for mode transition here? Better to signal the gen permeate unit (featured or de-featured) and let its state machine handle the transition back to standby mode.

LEAHI-DD-FIRMWARE-LDT-2662-1 06 Nov 2025

"codes" should not be plural.

LEAHI-DD-FIRMWARE-LDT-2662-1 06 Nov 2025

Should we reject start request if we are not in standby mode?
And is it appropriate to call for mode transition here? Better to signal Standby mode and let its state machine handle the transition.

LEAHI-DD-FIRMWARE-LDT-2662-1 06 Nov 2025

We shouldn't need to specify the return type in description here. Rephrase to something like "TRUE if FP device is de-featured, FALSE if not".

LEAHI-DD-FIRMWARE-LDT-2662-1 06 Nov 2025

If we're not sending ACK here, let's remove this code and replace with a comment stating we are only ACKing Dialin messages.

LEAHI-DD-FIRMWARE-LDT-2662-1 06 Nov 2025

What are we doing with fpReason?

LEAHI-DD-FIRMWARE-LDT-2662-1 06 Nov 2025

Is this necessary,?

LEAHI-DD-FIRMWARE-LDT-2004-2 20 Nov 2025

Agree, but this is a temporary driver so I don't want to spend too much time making this unit perfect.

LEAHI-DD-FIRMWARE-LDT-2004-2 20 Nov 2025

Should be calling get function in monitor (not driver).

LEAHI-DD-FIRMWARE-LDT-2004-1 04 Nov 2025

No need to pop here if there are more structures below to pack. Put all packed structures between a single set of pragma pack push/pop.

LEAHI-DD-FIRMWARE-LDT-2004-1 05 Nov 2025

Why string and I don't see string being sent anywhere.

LEAHI-DD-FIRMWARE-LDT-2004-1 05 Nov 2025

Why string and I don't see this string being sent anywhere.

LEAHI-DD-FIRMWARE-LDT-2662-1 12 Nov 2025

fixed. thanks!

TD-LDT-1886-7 07 Nov 2025

Done

TD-LDT-1886-7 07 Nov 2025

The test configuration has not been imported yet. I commented it out as a placeholder.

DIALIN-DENBUG-328-1 07 Nov 2025

RESOLVED.

TD-LDT-1886-7 08 Nov 2025

Done

TD-LDT-1886-7 08 Nov 2025

Done

LEAHI-DIALIN-LDT-1886-1 08 Nov 2025

Done

LEAHI-DD-FIRMWARE-LDT-2662-1 12 Nov 2025

reworked to use the request stop functions in their respective op modes.

LEAHI-TESTSUITES-LDT-2174-1 11 Nov 2025

Added the test cases as per suggestion

LEAHI-TESTSUITES-LDT-2174-1 11 Nov 2025

Added mouseclick action before validating from FW

LEAHI-TESTSUITES-LDT-2174-1 06 Nov 2025

o_PreTreatmentCreate_bicarbonateConcentrateComboBox_BaseComboBox is not being used

LEAHI-TESTSUITES-LDT-2174-1 06 Nov 2025

before validating from FW. Add mouse click of the button then do the FW action. Same when confirming mouse click the button then press the confirm button

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

i do not remember why i commented this out.. but added back in

LEAHI-DD-FIRMWARE-LDT-2662-1 13 Nov 2025

fixed. thanks

LEAHI-APPLICATION-LDT-2727-1 13 Nov 2025

added

LEAHI-APPLICATION-LDT-2727-1 13 Nov 2025

updated

LEAHI-DD-FIRMWARE-LDT-2004-2 12 Nov 2025

Why?

LEAHI-TESTSUITES-LDT-2174-1 06 Nov 2025

Also test the slider functionality as well as the left and right arrows

LEAHI-TESTSUITES-LDT-2174-1 06 Nov 2025

Add test when all parameters are filled:
1. Change Duration -> Verify Heparin Stop Time "active" property is set to off
2. Change Heparin Dispensising Rate from 0.2 to OFF -> Verify Heparing Stop Time is set to OFF
3. Change Heparin Dispensising Rate from OFF to 0.2 -> Verify Heparin Stop Time "active" property is set to off
4. When Duration is set to a value -> Verify the max Heparin Stop Time is the Duration value that is set

LEAHI-TESTSUITES-LDT-2174-1 06 Nov 2025

remove text properties in all object and get the text programmatically then test

LEAHI-SW-SCRIPTS-LDT-2727-1 12 Nov 2025

All the script files need to follow the same format as the wifi_scan.sh.
/sa this link

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

Please define in Fonts.qml or top of this qml if only used here.
Also @55, @78, @90, .... .

TD-LDT-1886-7 07 Nov 2025

Done

LEAHI-DD-FIRMWARE-LDT-2662-1 12 Nov 2025

Ok, but see my next comment below. Do we need to ACK with a result at all? Does TD require this?

LEAHI-APPLICATION-LDT-2727-1 13 Nov 2025

updated

LEAHI-APPLICATION-LDT-2727-1 13 Nov 2025

updated

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

Why did the logic change?
The order should be to fill in the first column, then go to the next, and it should not be by row.

TD-LDT-1886-7 07 Nov 2025

Done

TD-LDT-1886-7 10 Nov 2025

Done

TD-LDT-1886-7 10 Nov 2025

Done

LEAHI-SW-SCRIPTS-LDT-2727-1 13 Nov 2025

added the checks and graceful exit

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

Every time you use " * someValue ", please add a comment explaining why.
@100, @101, @102 as well.

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

Where in the design do you store the new password?

LEAHI-DD-FIRMWARE-LDT-2004-1 12 Nov 2025

Align the comments in fixed indentation throughout the file.