•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-TESTSUITES-LDT-1218-1 20 Oct 2025

can we add 2 tests.. One when treatment is paused to test the message showing "Treatment Paused" and test when timer is finished to test "Treatment Complete" message

LEAHI-TESTSUITES-LDT-1057-1 20 Oct 2025

after the mouse click and before the exporty_log_status line is the only place we need utils.waitForGUI(1) as we need to wait for the progress message to appear

LEAHI-TESTSUITES-LDT-1057-1 20 Oct 2025

This need a wait to find the object.. , timeout_ms=1000

LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

add braces for slots

TD-LDT-1886-7 23 Oct 2025

The valves are initialized in the valves driver in the first state.

TD-LDT-1886-7 23 Oct 2025

They are initialized in the valves driver.

TD-LDT-1886-7 23 Oct 2025

1760 is a nominal value. The driver will keep adding steps if 1760 worked for the first time. These values are suggested by the hardware team.

TD-LDT-1886-7 23 Oct 2025

Done

LEAHI-DD-FIRMWARE-LDT-2662-1 23 Oct 2025

Removed. Thanks

LEAHI-RO-FIRMWARE-LDT-2116-1 21 Oct 2025

Are these just temporarily being published for tuning?

LEAHI-DD-FIRMWARE-LDT-3749-2 08 Apr 2026

Should default be TRUE? If we are being asked to validate an jump to an invalid state, shouldn't we return FALSE?

LEAHI-DD-FIRMWARE-LDT-4614-1 02 Jul 2026

Add comments.

LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

-5

LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

expand brances

LEAHI-TD-FIRMWARE-LDT-4040-1 14 Jul 2026

Remove extra blank line.

LEAHI-TD-FIRMWARE-LDT-4049-1 14 Jul 2026

Delete this. No treatment params mode in Leahi.

LEAHI-DD-FIRMWARE-LDT-3735-1 14 Jul 2026

Remove blank line.

LEAHI-DD-FIRMWARE-LDT-3735-1 14 Jul 2026

Indent looks too deep here.

LEAHI-DD-FIRMWARE-LDT-3735-1 14 Jul 2026

Indent too deep here.

LEAHI-DD-FIRMWARE-LDT-3735-1 14 Jul 2026

Add blank line before return statement.

LEAHI-APPLICATION-LDT-4919-1 09 Jul 2026

look into the stackItem page() method

LEAHI-TD-FIRMWARE-LDT-4049-1 14 Jul 2026

Use structure instead of U32.

LEAHI-TD-FIRMWARE-LDT-4049-1 14 Jul 2026

Fix reject reason name (not filter temperature?)

LEAHI-TD-FIRMWARE-LDT-4049-1 14 Jul 2026

Change reason to FP_BUSY

LEAHI-TD-FIRMWARE-LDT-4049-1 14 Jul 2026

Remove this line. There is no syringe detection.

LEAHI-DD-FIRMWARE-LDT-3735-1 14 Jul 2026

Add a blank line after private defs banner.

LEAHI-DD-FIRMWARE-LDT-3735-1 14 Jul 2026

Remove blank line.

LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

hard code 50. try and only use icon size

LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

not aligned

LEAHI-TESTSUITES-LDT-1057-1 23 Oct 2025

Please update to add in the real way to get to the settings screen
1. Start up application
2. Change opmode to standby
3. Select Settings
4. Select Export logs.

Please Update on every time applications opens

LEAHI-DD-FIRMWARE-LDT-3735-1 14 Jul 2026

These don't look like UI alarms. Comment suggests we already know what to call these. Why aren't we just using the names we want?

LEAHI-TD-FIRMWARE-LDT-4029-1 13 Jul 2026

This is at end of enum list above. So it should be at end of table here.

LEAHI-DD-FIRMWARE-LDT-3735-1 14 Jul 2026

Remove blank line.

LEAHI-TD-FIRMWARE-LDT-4029-1 13 Jul 2026

Use ternary operation to assign TRUE or FALSE explicitly.

LEAHI-TD-FIRMWARE-LDT-4029-1 14 Jul 2026

I don't see any change here. How does this function get called? I don't see the function being used anywhere - nobody is calling it. I think it should be called by Messaging.c when a UI confirmation msg is received.

LEAHI-APPLICATION-LDT-4919-1 09 Jul 2026

fix indent

LEAHI-DD-FIRMWARE-LDT-4410-3 11 Jul 2026

right now pre and post are same. make a TODO to update post later

LEAHI-DD-FIRMWARE-LDT-4410-3 10 Jul 2026

could you document th math behind the calculation also

LEAHI-DD-FIRMWARE-LDT-2008-1 14 Apr 2026

fixed

LEAHI-DD-FIRMWARE-LDT-3777-1 14 Apr 2026

good catch. This needed to be reverted back to normal publishing.

LEAHI-DD-FIRMWARE-LDT-3735-1 14 Jul 2026

Add blank line between declarations and rest of function code.

LEAHI-DD-FIRMWARE-LDT-3735-1 14 Jul 2026

This is a common unit - could be built into DD or TD f/w. Need #ifdef to see if _DD_ or _TD_ build so you know which messaging and records to initialize.

LEAHI-DD-FIRMWARE-LDT-2662-1 23 Oct 2025

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-2008-1 14 Apr 2026

per formatting for the test support function header. it is format used across many files

LEAHI-DD-FIRMWARE-LDT-3777-1 14 Apr 2026

fixed

LEAHI-DD-FIRMWARE-LDT-2004-9 14 Apr 2026

So I think this compiler will give you 64 bit if you ask for long. Did you intend it to be 64 bit? If not, you can just use the BIT_BY_POS macro above.

LEAHI-DD-FIRMWARE-LDT-2004-9 14 Apr 2026

Put () around each of the 2 conditions being ANDed.

LEAHI-APPLICATION-LDT-3757-1 16 Apr 2026

removed

LEAHI-APPLICATION-LDT-3656-1 16 Apr 2026

updatred name

LEAHI-DD-FIRMWARE-LDT-2004-9 14 Apr 2026

Please update this value with high resolution ( for example, 0.67 to 0.666666667 and 1.15 to 1.146666667? ).