•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-2686-1 28 Oct 2025

RESOLVED

LEAHI-TESTSUITES-LDT-1057-1 29 Oct 2025

We're using this method specifically in this file, so for now it will remain in test.py

LEAHI-RO-FIRMWARE-LDT-2116-1 28 Oct 2025

Align comments spacing

LEAHI-TESTSUITES-LDT-1057-1 29 Oct 2025
  • startApplication method is moved to def main() function.
  • '-l' is removed and added '-q'
LEAHI-TESTSUITES-LDT-1057-1 27 Oct 2025

I would move this in the application_init.py

LEAHI-TESTSUITES-LDT-1218-1 27 Oct 2025

It was a good idea to create the get_object_from_names function as a wrapper for the waitForObjectExists.
If it is created as a wrapper for this function call, shouldn't we use that?
If you do not plan to use it (or have any issues), please remove the get_object_from_names function.

LEAHI-DD-FIRMWARE-LDT-2004-1 04 Nov 2025

We typically initialize variables in the init function and not in declaration.

LEAHI-APPLICATION-LDT-2666-1 28 Oct 2025

Remove binding, translation requires a system reset.

LEAHI-TESTSUITES-LDT-1057-1 03 Nov 2025

Updated as suggested.

LEAHI-TESTSUITES-LDT-1057-1 29 Oct 2025

lets try and avoid using the occurrence property and instead get the parent object which should be a TouchGrid qml component then find the children and find the object in the grid by testing theText property of the child object "Export Logs"

LEAHI-RO-FIRMWARE-LDT-2116-1 28 Oct 2025

Safe to define a const and used it here instead of passing 700

HD-DENBUG-326-1 03 Nov 2025

RESOLVED IN CODE WALKTHROUGH.

LEAHI-TESTSUITES-LDT-1218-1 27 Oct 2025

The application should be called by -q switch; otherwise, if you don't pet it (ACK), it will display alarm 100.
How did you overcome that issue?

LEAHI-RO-FIRMWARE-LDT-2116-1 03 Nov 2025

Consider doing this manual control in a function and call it from here.

LEAHI-DIALIN-LDT-2658-2 04 Nov 2025

Dara Navaei I only see this override function for "filtered" temperatures, but according to function name, it only applies to temperatures coming from pressure sensors. Why only pressure based temperatures?

LEAHI-DD-FIRMWARE-LDT-2004-1 04 Nov 2025

Do we need to include Teensy driver here?

LEAHI-APPLICATION-LDT-2686-1 28 Oct 2025

RESOLVED

LEAHI-APPLICATION-LDT-2686-1 28 Oct 2025

RESOLVED

LEAHI-TESTSUITES-LDT-1057-1 29 Oct 2025

Updated the object names as suggested.

LEAHI-TESTSUITES-LDT-1057-1 27 Oct 2025

Please use more meaningful names.
The combobox is too general.

LEAHI-TESTSUITES-LDT-1057-1 27 Oct 2025

Same here.
And all the other same instances.

  • Please add the container/use case in the name if the object is not generally unique.
  • Add the type at the end if it is not redundant.


Example:

  • o_SettigsExportLogs_ProgressRect
LEAHI-TESTSUITES-LDT-1057-1 03 Nov 2025

Updated as per the suggestion.

LEAHI-TESTSUITES-LDT-1218-1 27 Oct 2025

Seems there is a missing test.startSection() , test.endSection() for the Pressures here

LEAHI-APPLICATION-LDT-2666-1 30 Oct 2025

Updated.

LEAHI-APPLICATION-LDT-2666-1 30 Oct 2025

Updated.

LEAHI-TESTSUITES-LDT-1057-1 27 Oct 2025

Please use consistent object names, all starting with o_, to make them easier to identify in the code and debug messages.

LEAHI-TESTSUITES-LDT-1218-1 28 Oct 2025

Added -q switch for startApplication method as requested, but we never faced any alarm issue.

LEAHI-TESTSUITES-LDT-1057-1 29 Oct 2025

moved to application_init.py

LEAHI-APPLICATION-LDT-2666-1 30 Oct 2025

Updated.

LEAHI-TESTSUITES-LDT-1057-1 27 Oct 2025

All the object names shall start with '_'.
Please update when fixed on the SW.
Nicholas Ramirez, as we talked, that should be updated when we have a chance, thanks.
It is fine if we address this later.

LEAHI-APPLICATION-LDT-2666-1 28 Oct 2025

Do not worry about getting responses out of order.
Just clear text if accepted, otherwise assign text.

LEAHI-RO-FIRMWARE-LDT-2116-1 03 Nov 2025

fixed. Thanks!

LEAHI-RO-FIRMWARE-LDT-2116-1 03 Nov 2025

fixed. Thanks!

LEAHI-RO-FIRMWARE-LDT-1773-1 03 Nov 2025

fixed. thanks!

LEAHI-DD-FIRMWARE-LDT-2004-1 04 Nov 2025

Where are we including the conductivity driver? Expecting a build switch (#ifdef) that selects which driver we are including.

LEAHI-RO-FIRMWARE-LDT-2116-1 03 Nov 2025

Remove blank line.

LEAHI-DD-FIRMWARE-LDT-2004-1 04 Nov 2025

Is the "readConductivitySensors()" call above for the FPGA based driver we will have later? Should we only do one or the other based on build switch?

LEAHI-DD-FIRMWARE-LDT-2004-1 04 Nov 2025

Put these 2 cases in a #ifdef USE_TEENSY_CONDUCTIVITY build switch so only included in build if we're using the Teensy board.

LEAHI-TESTSUITES-LDT-1218-1 28 Oct 2025

Updated get_object_from_names function as a wrapper for the waitForObjectExists.

LEAHI-APPLICATION-LDT-2686-1 28 Oct 2025

RESOLVED

LEAHI-APPLICATION-LDT-2686-1 28 Oct 2025

RESOLVED

LEAHI-APPLICATION-LDT-2686-1 28 Oct 2025

RESOLVED

LEAHI-APPLICATION-LDT-2686-1 28 Oct 2025

RESOLVED

LEAHI-APPLICATION-LDT-2686-1 28 Oct 2025

RESOLVED

LEAHI-APPLICATION-LDT-2666-1 28 Oct 2025

Add to Variables.qml.

LEAHI-TESTSUITES-LDT-1057-1 29 Oct 2025

removed the "text" as suggested.

LEAHI-TESTSUITES-LDT-1057-1 29 Oct 2025

updated all objects names started with o_.

LEAHI-APPLICATION-LDT-2666-1 30 Oct 2025

Updated.

LEAHI-APPLICATION-LDT-2666-1 30 Oct 2025

Updated.

LEAHI-APPLICATION-LDT-2666-1 28 Oct 2025

Wrap in expanded block.