Comment Search

Remove commented out lines?

updated comment.

Removed all the unused objects.

Aligned

Fixed

They were added while debugging fp_test_configs and why it's never being updated.
Removed.

I think these functions (validate and signal) should be "test" functions and moved down to Dialin test functions section below - for all modes.

please do not use complicated statement in if condition. take out this logic before if condition and use BOOL variable.

remove source from all responses

Input is d78TempAvgC

to recirculate.

Now that we go with pressure slope detection logic, we don't want to use pressure-based detection for Low Qd. correct?

Why the order is important here ? please document it

Algin "=" to be consistent with those below.

This is called from preload state. Not needed here I think.

removed the unused import

done

Should be before ModeStandby.

removed

Update the deadband timing in the comments.

Not sure that publish function is the best place to do this, but it's where you're calculating timeout and countdown times which are local - but we need to alarm (warning) when countdown reaches 1 minute (60 secs) and we need to alarm more severely when countdown reaches 0 secs.

If you make the 2 times static (not local here), you can call a monitor function from exec and do the calculations for the times and trigger alarms in the monitor function. Then, here in publish function, you would just publish the static times (no need to calculate because it's already done all the time).

'genPermeateState' in the outputs. please update across the files as needed.

Same comment.

Maybe this should be handled in OperationModes exec since it applies to all confirmations (not just alarm related ones).

Let's remove this for now.