•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DIALIN-LDT-3629-1 12 Mar 2026

They were added while debugging fp_test_configs and why it's never being updated.
Removed.

LEAHI-APPLICATION-LDT-3433-1 12 Mar 2026

enhancement BN APPROVES

LEAHI-DD-FIRMWARE-LDT-3603-1 11 Mar 2026

I think these functions (validate and signal) should be "test" functions and moved down to Dialin test functions section below - for all modes.

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

corrected.

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

please do not use complicated statement in if condition. take out this logic before if condition and use BOOL variable.

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

Add comment

LEAHI-APPLICATION-LDT-3516-1 12 Mar 2026

remove source from all responses

LEAHI-APPLICATION-LDT-3574-1 12 Mar 2026

_statusItem

LEAHI-TD-FIRMWARE-LDT-3126-2 16 Mar 2026

Add a blank line after declaration.

LEAHI-APPLICATION-LDT-3698-1 16 Mar 2026

to recirculate.

LEAHI-DD-FIRMWARE-LDT-2004-9 18 Mar 2026

These seem more like concentrate doses, not dialysate doses. Consider renaming.

LEAHI-DD-FIRMWARE-LDT-2004-9 01 Apr 2026

Algin "=" to be consistent with those below.

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

removed the unused import

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

removed

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

done

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

done

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

Should be before ModeStandby.

LEAHI-DD-FIRMWARE-LDT-3603-1 11 Mar 2026

Add comment that all of these states require no special handling.

LEAHI-APPLICATION-LDT-3413-1 13 Mar 2026

removed

LEAHI-APPLICATION-LDT-3574-1 13 Mar 2026

updated

LEAHI-TD-FIRMWARE-LDT-3126-2 13 Mar 2026

Not sure that publish function is the best place to do this, but it's where you're calculating timeout and countdown times which are local - but we need to alarm (warning) when countdown reaches 1 minute (60 secs) and we need to alarm more severely when countdown reaches 0 secs.

If you make the 2 times static (not local here), you can call a monitor function from exec and do the calculations for the times and trigger alarms in the monitor function. Then, here in publish function, you would just publish the static times (no need to calculate because it's already done all the time).

LEAHI-TD-FIRMWARE-LDT-3215-1 17 Mar 2026

Added

LEAHI-DD-FIRMWARE-LDT-3603-2 30 Mar 2026

'genPermeateState' in the outputs. please update across the files as needed.

LEAHI-DD-FIRMWARE-LDT-3103-3 02 Apr 2026

updated.

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

removed the unused import

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

Aligned

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

changed and updated all the other places.

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

Should assign a local variable to this equation and then return the variable.
Can this equation result in a negative number? If so, we should handle that first before converting to unsigned int.
Also, do we want to do any rounding when converting float to integer?

LEAHI-DD-FIRMWARE-LDT-3603-1 11 Mar 2026

Remove comment.

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

done

LEAHI-TD-FIRMWARE-LDT-3126-2 16 Mar 2026

Added

LEAHI-DD-FIRMWARE-LDT-3628-1 17 Mar 2026

updated.

LEAHI-APPLICATION-LDT-3698-1 17 Mar 2026

BN Approves

LEAHI-APPLICATION-LDT-3698-1 17 Mar 2026

SQ APPROVES

LEAHI-APPLICATION-LDT-3698-1 17 Mar 2026

SQ APPROVE

LEAHI-DD-FIRMWARE-LDT-3628-1 17 Mar 2026

Remove typecast.

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

removed the unused variables.

LEAHI-TESTSUITES-LDT-1057-1 20 Oct 2025

The test suite is missing an update to the suite.conf file that adds your test case to the test suite. Please push the file with the addition of your test case

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

deleted

LEAHI-APPLICATION-LDT-3433-1 12 Mar 2026

BN APPROVES

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

Why did this move? It needs to be in the nth row of the table (n = enum #) so that the enum will index to it in this table.

LEAHI-APPLICATION-LDT-3574-1 13 Mar 2026

removed

LEAHI-TD-FIRMWARE-LDT-3126-2 13 Mar 2026

Align with others (after U32).

LEAHI-DIALIN-LDT-2662-1 20 Oct 2025

done - reordered list to match current FP implementation

LEAHI-APPLICATION-LDT-3698-1 17 Mar 2026

added

LEAHI-DIALIN-LDT-2662-1 20 Oct 2025

done - reordered list to match current FP implementation

LEAHI-TD-FIRMWARE-LDT-1903-9 11 Mar 2026

Add space between if and (

TD-LDT-1886-7 20 Oct 2025

Done

TD-LDT-1886-7 20 Oct 2025

Done

TD-LDT-1886-7 20 Oct 2025

Done