•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-TD-FIRMWARE-LDT-1903-9 17 Mar 2026

reverted back

LEAHI-DIALIN-LDT-2264-1 10 Oct 2025

fixed

LEAHI-APPLICATION-LDT-1440-1 10 Oct 2025

RESOLVED

LEAHI-APPLICATION-LDT-1440-1 06 Oct 2025

This value should come from configuration.

LEAHI-DD-FIRMWARE-LDT-2004-9 18 Mar 2026

I don't think these coefficient access functions need to be public. Consider making them private.

LEAHI-DIALIN-LDT-1440-1 10 Oct 2025

fix the comment (x67).

LEAHI-TESTSUITES-LDT-2278-1 31 Mar 2026

Added before the pre treatment page

LEAHI-TESTSUITES-LDT-2278-1 31 Mar 2026

corrected the invalid syntax and added the space between the function

LEAHI-DD-FIRMWARE-LDT-3603-2 31 Mar 2026

Add a comment:
result already FALSE - do nothing more for modes that do not support jump to sub-mode.

LEAHI-DD-FIRMWARE-LDT-2004-9 18 Mar 2026

Are these coming back? If so, add TODO comment to restore later. If not, delete them.

LEAHI-DD-FIRMWARE-LDT-2004-9 01 Apr 2026

Remove this.

LEAHI-DD-FIRMWARE-LDT-2004-9 01 Apr 2026

Add blank line after declarations.

LEAHI-DD-FIRMWARE-LDT-3103-3 02 Apr 2026

updated.

LEAHI-DD-FIRMWARE-LDT-3352-1 02 Apr 2026

Done.

LEAHI-DD-FIRMWARE-LDT-3352-1 02 Apr 2026

Just following the current style of code implementation to keep it uniform. These defines are temporary and will be removed.

LEAHI-DD-FIRMWARE-LDT-3352-1 02 Apr 2026

Done.

LEAHI-APPLICATION-LDT-1440-1 07 Oct 2025

Updated.

LEAHI-DD-FIRMWARE-LDT-1195-2 11 Mar 2026

I believe we will want BC control during ISO UF state.

LEAHI-APPLICATION-LDT-1440-1 08 Oct 2025

This will be implemented in a subsequent story.

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

Align "="

LEAHI-APPLICATION-LDT-1440-1 08 Oct 2025

Verified that placement is correct.

LEAHI-TESTSUITES-LDT-1218-1 15 Oct 2025

added existing objects to names.py file.

LEAHI-APPLICATION-LDT-3574-1 13 Mar 2026

Nicholas Ramirez
Could you please recheck, I don't see the updated change.

LEAHI-APPLICATION-LDT-2264-1 09 Oct 2025

updated

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

Remove blank line.

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

are we using this variable, if not, can we remove across the file?

LEAHI-APPLICATION-LDT-2264-1 10 Oct 2025

RESOLVED.

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

Fix alignment of "=".

LEAHI-APPLICATION-LDT-1440-1 10 Oct 2025

RESOLVED

LEAHI-APPLICATION-LDT-1440-1 06 Oct 2025

Close start on confirm to go back to main treatment.

LEAHI-DD-FIRMWARE-LDT-3352-1 13 Mar 2026

Should min and max be properties of the controller instead of global (assumes all controllers will want same min/max)?
Controller properties already include a min and max field - can we use those?

LEAHI-TESTSUITES-LDT-1218-1 15 Oct 2025

RESOLVED

LEAHI-TD-FIRMWARE-LDT-1394-1 13 Mar 2026

done.

LEAHI-TD-FIRMWARE-LDT-3126-2 16 Mar 2026

Added

LEAHI-TD-FIRMWARE-LDT-3126-2 16 Mar 2026

I think we should just have == here so that we only warn them once.

LEAHI-TD-FIRMWARE-LDT-3126-2 16 Mar 2026

Name in brief doesn't match function name.

LEAHI-TESTSUITES-LDT-1057-1 15 Oct 2025

The configuration is from Denali. Please lets port in what we are using into a new one as part of this test suite

LEAHI-DD-FIRMWARE-LDT-2004-9 18 Mar 2026

This is a structure, not an enumeration.

LEAHI-TESTSUITES-LDT-1218-1 15 Oct 2025

The configuration is from Denali. Please lets port in what we are using into a new one as part of this test suite

LEAHI-TESTSUITES-LDT-1218-1 14 Oct 2025

is this a python lib or is this made by us?

LEAHI-DD-FIRMWARE-LDT-2004-9 01 Apr 2026

Remove spaces before "=" or align "=".

LEAHI-TESTSUITES-LDT-1218-1 15 Oct 2025

Added new configuration file utility.py for Leahi.

LEAHI-TESTSUITES-LDT-1218-1 14 Oct 2025

Please make keep all existing object as they are required for the other test cases.

LEAHI-TESTSUITES-LDT-1218-1 15 Oct 2025

align each parameter as well please

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

remove duplicate import

LEAHI-TESTSUITES-LDT-1218-1 15 Oct 2025

RESOLVED

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

Remove this import as its not being used

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

update all temp -> tmp and Temperature - > Trancememberance

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

Remove this import as its not being used

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

in_range_color and out_of_range_color are not being used so please remove