•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DIALIN-LDT-696-1 26 Mar 2026

Add a TODO comment to change the message once implemented in FW

LEAHI-DD-FIRMWARE-LDT-3628-1 26 Mar 2026

just needed it for develop branch. removed and restored.

LEAHI-DD-FIRMWARE-LDT-2004-9 21 Mar 2026

I do not see TD use case in any of the PI controller functions. so do we need TD here ?

LEAHI-DD-FIRMWARE-LDT-2004-9 27 Mar 2026

No, its deleted

LEAHI-DD-FIRMWARE-LDT-2004-9 30 Mar 2026

This "s" looks out of place.

LEAHI-DD-FIRMWARE-LDT-2004-9 30 Mar 2026

But this is a f/w shared unit (so both TD and DD f/w include this unit in their build) and we may add a case later. Because it's a common unit, we should design it to work for both f/w builds.

LEAHI-TESTSUITES-LDT-3188-1 30 Mar 2026

no need to test post treatment only pre treatment .. remove all post treatmetn steps

LEAHI-TESTSUITES-LDT-3120-1 30 Mar 2026

just add to the end please

LEAHI-TESTSUITES-LDT-3188-1 30 Mar 2026

will this affect other test cases that have the parameters in the previous order? If so leave as is to avoid that

LEAHI-TESTSUITES-LDT-3120-1 31 Mar 2026

updated as per comment

LEAHI-TESTSUITES-LDT-3120-1 31 Mar 2026

updated as per comment

LEAHI-DD-FIRMWARE-LDT-2004-9 01 Apr 2026

Are we going to restore this or not?

LEAHI-DD-FIRMWARE-LDT-3603-2 30 Mar 2026

Validates the requested sub mode change is acceptable or not?

LEAHI-DD-FIRMWARE-LDT-1477-1 02 Apr 2026

Done.

LEAHI-TD-FIRMWARE-LDT-473-3 06 Apr 2026

Can we just remove the old enum now?

LEAHI-DD-FIRMWARE-LDT-3777-1 08 Apr 2026

Why are we switching sensors around?

LEAHI-DD-FIRMWARE-LDT-3103-3 24 Mar 2026

done

LEAHI-APPLICATION-LDT-1440-1 30 Sep 2025

These files don't exist in my branch and these lines will be added in when this branch is merged.

LEAHI-APPLICATION-LDT-1440-1 08 Oct 2025

Updated.

LEAHI-APPLICATION-LDT-1440-1 08 Oct 2025

Updated.

LEAHI-APPLICATION-LDT-1440-1 09 Oct 2025

Updated.

LEAHI-APPLICATION-LDT-3433-1 11 Mar 2026

added checks

LEAHI-SW-PLUGINS-SIM-LDT-2264-1 10 Oct 2025

RESOLVED

LEAHI-TD-FIRMWARE-LDT-3215-1 17 Mar 2026

If you change this line to "if ( ++airPumpStallCounter >= AIR_PUMP_STALL_PERSISTENCE )", you can remove the if statement above.

LEAHI-APPLICATION-LDT-1440-1 10 Oct 2025

RESOLVED

LEAHI-APPLICATION-LDT-1440-1 10 Oct 2025

RESOLVED

LEAHI-APPLICATION-LDT-1440-1 10 Oct 2025

RESOLVED

LEAHI-APPLICATION-LDT-1440-1 01 Oct 2025

Change enums to actual value.

LEAHI-APPLICATION-LDT-1440-1 01 Oct 2025

Ask Caryn/Nick if it is possible to leave UF adjustment with UF paused or user must resume before closing dialog.

LEAHI-SW-PLUGINS-SIM-LDT-1440-1 10 Oct 2025

Will be addressed later.

TD-LDT-1886-7 29 Sep 2025

Should we set hasValveBeenReset to FALSE here?

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

Add a param line in this header.

LEAHI-APPLICATION-LDT-3433-1 10 Mar 2026

ask fw where to get this

LEAHI-APPLICATION-LDT-3413-1 13 Mar 2026

updated

LEAHI-APPLICATION-LDT-3433-1 12 Mar 2026

BN APPROVES

LEAHI-APPLICATION-LDT-3433-1 12 Mar 2026

BN APPROVES

LEAHI-DD-FIRMWARE-LDT-3603-1 11 Mar 2026

I think these 2 functions are in support of Dialin only, so should be prefixed with "test" as well.

LEAHI-DD-FIRMWARE-LDT-3603-1 11 Mar 2026

We have 1 param (and probably should have 2 params - requested mode and submode).

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

done

LEAHI-TD-FIRMWARE-LDT-1394-1 10 Mar 2026

If we don't think we need this, let's just delete it. If we think it's coming back, let's keep it and just set the max count to something really high (e.g. 1,000,000).

LEAHI-TD-FIRMWARE-LDT-3126-2 13 Mar 2026

I think we can initialize to zero here. We haven't paused yet.

LEAHI-TD-FIRMWARE-LDT-3126-2 17 Mar 2026

I'll drop by and we can set properties together.

LEAHI-APPLICATION-LDT-3698-1 17 Mar 2026

BN APPROVES

LEAHI-APPLICATION-LDT-3678-1 17 Mar 2026

remove

LEAHI-TD-FIRMWARE-LDT-3215-1 19 Mar 2026

Updated

LEAHI-DIALIN-LDT-696-1 20 Mar 2026

ROPump is repeated

LEAHI-DD-FIRMWARE-LDT-3603-2 31 Mar 2026

Updated

LEAHI-TESTSUITES-LDT-2278-1 30 Mar 2026

gettting an error for invalid syntax here.. please add space between function and remove the 'f' inside the parenthesis

LEAHI-TESTSUITES-LDT-2839-1 30 Mar 2026

please only add test case to the end