•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-SW-SCRIPTS-LDT-2727-1 24 Nov 2025

updated

LEAHI-TESTSUITES-LDT-2174-1 24 Nov 2025

Aligned the parameters

LEAHI-TESTSUITES-LDT-1078-1 26 Nov 2025

Now I am getting AUT path using aut_path = currentApplicationContext().cwd in test script

LEAHI-DD-FIRMWARE-LDT-2030-2 25 Nov 2025

Remove extra blank line.

LEAHI-DIALIN-LDT-2004-1 21 Nov 2025

Remove extra blank lines.

TEENSY-BOARD-LDT-2004-6 24 Nov 2025

Fix indent.

LEAHI-RO-FIRMWARE-LDT-2116-1 22 Nov 2025

Fixed. Thanks

LEAHI-RO-FIRMWARE-LDT-2116-1 18 Nov 2025

comment start with capital letter. check all other places.

LEAHI-DD-FIRMWARE-LDT-2030-2 26 Nov 2025

Moved the enums to driver header file. Fixed it.

LEAHI-DD-FIRMWARE-LDT-2030-2 24 Nov 2025

copy right missing

LEAHI-DD-FIRMWARE-LDT-2004-3 21 Nov 2025

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-2030-2 24 Nov 2025

copy right missing

LEAHI-DD-FIRMWARE-LDT-2004-1 21 Nov 2025

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-2004-1 21 Nov 2025

No overrides?

LEAHI-TD-FIRMWARE-LDT-1886-1 25 Nov 2025

According to the HDD, it is a '1' when inactive and becomes a '0' when active. It becomes active when it reaches the position.

LEAHI-TD-FIRMWARE-LDT-1886-1 25 Nov 2025

Should this be an enum at driver level? Driver get would return enum so controller doesn't have to figure out what it means.

LEAHI-DD-FIRMWARE-LDT-2004-1 21 Nov 2025

If no parameters, just don't have any param lines (don't say none).

LEAHI-DD-FIRMWARE-LDT-2004-1 21 Nov 2025

Use a #define instead of 1000.

LEAHI-DD-FIRMWARE-LDT-2030-2 25 Nov 2025

Do we need to call initBloodLeakDriver() here?

LEAHI-DD-FIRMWARE-LDT-2004-3 21 Nov 2025

Remove extra space before void. Align comments.

LEAHI-DD-FIRMWARE-LDT-2004-3 21 Nov 2025

We can abbreviate things in function and variable names, but in descriptive text we should write things out in complete words as this text goes into SDD document.

TEENSY-BOARD-LDT-2004-6 24 Nov 2025

Fix indent.

TEENSY-BOARD-LDT-2004-6 24 Nov 2025

Fix indent.

LEAHI-DD-FIRMWARE-LDT-2004-1 21 Nov 2025

Add comment to right.

LEAHI-RO-FIRMWARE-LDT-2116-1 22 Nov 2025

Fixed. Thanks

LEAHI-DD-FIRMWARE-LDT-2030-2 26 Nov 2025

fixed. thank you.

LEAHI-DD-FIRMWARE-LDT-2004-1 21 Nov 2025

///

LEAHI-DD-FIRMWARE-LDT-2004-3 21 Nov 2025

Align comments.

LEAHI-TESTSUITES-LDT-1650-1 26 Nov 2025

Now I am getting AUT path using aut_path = currentApplicationContext().cwd in test script

LEAHI-DD-FIRMWARE-LDT-2030-2 26 Nov 2025

Removed. Thank you.

LEAHI-DD-FIRMWARE-LDT-2030-2 25 Nov 2025

Keep 2 blank lines above/below test banner.

LEAHI-DD-FIRMWARE-LDT-2004-3 21 Nov 2025

Align comments.

LEAHI-DD-FIRMWARE-LDT-2004-3 21 Nov 2025

Why does this case manage so many more valves than other cases?

LEAHI-TD-FIRMWARE-LDT-1886-1 25 Nov 2025

Then your doxygen return comment looks backward.

LEAHI-TD-FIRMWARE-LDT-1886-1 25 Nov 2025

Why bypassing driver here?

LEAHI-TD-FIRMWARE-LDT-1886-1 25 Nov 2025

Use U32 unless there is a good reason to use U08.

LEAHI-DD-FIRMWARE-LDT-2004-1 21 Nov 2025

///

LEAHI-DD-FIRMWARE-LDT-2030-2 24 Nov 2025

need structure packing

LEAHI-DD-FIRMWARE-LDT-2030-2 24 Nov 2025

copy right missing

LEAHI-DD-FIRMWARE-LDT-2004-1 21 Nov 2025

Fix indent.

LEAHI-RO-FIRMWARE-LDT-2116-1 22 Nov 2025

Fixed. Thanks

LEAHI-RO-FIRMWARE-LDT-2116-1 22 Nov 2025

Fixed. Thanks

LEAHI-RO-FIRMWARE-LDT-2116-1 24 Nov 2025

Will fix on Beta branch to avoid changes to Dialin

LEAHI-DD-FIRMWARE-LDT-2030-2 26 Nov 2025

fixed. thanks

LEAHI-DD-FIRMWARE-LDT-2030-2 26 Nov 2025

fixed. thank you.

LEAHI-DD-FIRMWARE-LDT-2030-2 26 Nov 2025

fixed. thank you.

LEAHI-DD-FIRMWARE-LDT-2030-2 26 Nov 2025

fixed. thank you.

LEAHI-DD-FIRMWARE-LDT-2030-2 26 Nov 2025

fixed. thank you.

LEAHI-TD-FIRMWARE-LDT-1886-1 25 Nov 2025

Why are we bypassing driver here?

LEAHI-DD-FIRMWARE-LDT-2004-1 21 Nov 2025

///