•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DIALIN-LDT-2300-1 22 Sep 2025

I didn't see dbg variables in the publish list above.

LEAHI-DD-FIRMWARE-LDT-1196-6 30 Sep 2025

Done

LEAHI-TD-FIRMWARE-LDT-3505-1 05 Mar 2026

Blank line after declarations.

LEAHI-APPLICATION-LDT-1440-1 07 Oct 2025

Updated.

LEAHI-TD-FIRMWARE-LDT-3505-1 05 Mar 2026

blank line before return.

LEAHI-APPLICATION-LDT-1440-1 09 Oct 2025

Updated.

LEAHI-DD-FIRMWARE-LDT-3372-2 06 Mar 2026

fixed.

LEAHI-DD-FIRMWARE-LDT-3372-2 06 Mar 2026

fixed.

LEAHI-DD-FIRMWARE-LDT-3372-2 06 Mar 2026

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-3603-1 06 Mar 2026

Declarations should be at top of scope (right before memcpy).

LEAHI-APPLICATION-LDT-1440-1 09 Oct 2025

Updated.

LEAHI-APPLICATION-LDT-2264-1 10 Oct 2025

RESOLVED

LEAHI-APPLICATION-LDT-2264-1 07 Oct 2025

1) What are the actions for the:

  • ACT: SW =>UI
  • ACT: SW<= UI
    after the interval expiration?
    Do we have any notifications or updates on the UI from the SW?
    I think there should be only one SW->SW.


2) Changing the expiration to "time out" makes more sense.

3) Vitals (Manujal), TCH: ... integreated (typo) ....

LEAHI-DIALIN-LDT-2264-1 10 Oct 2025

shall end with RESPONSE

LEAHI-APPLICATION-LDT-1440-1 09 Oct 2025

Verify image size.

LEAHI-APPLICATION-LDT-1440-1 08 Oct 2025

Update TreatmentAdjustmentUltrafiltrationItem to prevent showing subscreens if TreatmentHome is not visible.

LEAHI-APPLICATION-LDT-1440-1 10 Oct 2025

RESOLVED

LEAHI-APPLICATION-LDT-1440-1 10 Oct 2025

RESOLVED

LEAHI-APPLICATION-LDT-1440-1 01 Oct 2025

Add mention for UF Start screen states (paused/resumed).

LEAHI-TESTSUITES-LDT-2278-1 03 Dec 2025

Please add a test to automatically send BP data...
1. Measure Vitals Button -> press button then send data from fw and the field will automatically populate on popup
2. When timer expires...
1. Test No rejection reason after expiration FW receives request then FW sends Vitals data and the vitals section on the main treatment screen will update with those values.
2 . Test With a rejection reason when time expires then the vitals popup will automaticallly popup and test that the popup appears if request is rejected

LEAHI-TD-FIRMWARE-LDT-3126-1 23 Feb 2026

Removed

LEAHI-APPLICATION-LDT-3433-1 06 Mar 2026

added new image

LEAHI-APPLICATION-LDT-3433-1 06 Mar 2026

updated

LEAHI-DD-FIRMWARE-LDT-3372-2 06 Mar 2026

updated.

LEAHI-TD-FIRMWARE-LDT-1415-3 06 Mar 2026

Removed

LEAHI-DD-FIRMWARE-LDT-3372-2 05 Mar 2026

above comment applicable here .

LEAHI-DD-FIRMWARE-LDT-3372-2 06 Mar 2026

Same question.

LEAHI-DD-FIRMWARE-LDT-3603-1 06 Mar 2026

No faults from Dialin commands - we never want Dialin to cause system to go to fault because it requested something invalid - we only NAK the invalid request.
We should do whatever is needed (if anything) to start the mode normally in an else.
And we should return TRUE/FALSE in these signal functions so that when it's called from Dialin msg handler, the msg handler can return ACK/NAK to Dialin if sub mode is invalid.

LEAHI-TD-FIRMWARE-LDT-1903-8 23 Feb 2026

You have these MIN/MAX definitions in both this unit and AirPump unit. Can we put these in header file for this unit and remove from AirPump unit?

LEAHI-DIALIN-LDT-2300-1 22 Sep 2025

I'm not sure I really understand the question here, but I do know that the DD Heaters data is being published with this handler: I've organized all heater data into a nested dictionary so that only one "variable" is being published. The same goes for the other publish functions before each handler. I will reorganize the order of the published variables so that timestamp is listed last.

LEAHI-APPLICATION-LDT-1616-1 22 Sep 2025

RESOLVED.

LEAHI-APPLICATION-LDT-1616-1 22 Sep 2025

It does not seem like the bool parameter of this signal is useful,
remove the bool and just emit the signal.

LEAHI-APPLICATION-LDT-1616-1 24 Sep 2025

RESOLVED

LEAHI-DIALIN-LDT-2300-1 25 Sep 2025

Done

LEAHI-DD-FIRMWARE-LDT-3372-2 06 Mar 2026

build switch fixes will be completed in the v2 conductivity sensor branch. Per what was agreed on back in November:

J1 - P9
J2 - P18
J3 - D17
J4 - D27
J5 - D29
J6 - D43
No sensor - D74 (redundant, so we should be able to live without it in short run)

LEAHI-DD-FIRMWARE-LDT-3372-2 06 Mar 2026

Remove extra blank line.

LEAHI-TD-FIRMWARE-LDT-1415-3 06 Mar 2026

I think we should just call signalInitiatePressureStabilization( USE_NORMAL_STABILIZATION_PERIOD );

LEAHI-DD-FIRMWARE-LDT-3372-2 06 Mar 2026

Remove blank line.

LEAHI-APPLICATION-LDT-1440-1 09 Oct 2025

Updated.

LEAHI-APPLICATION-LDT-2264-1 07 Oct 2025

Use ACTION_VIEW_CONNECTION instead, to be consistent, since it is directly connected to the _GuiController.

LEAHI-APPLICATION-LDT-2264-1 10 Oct 2025

RESOLVED

TD-LDT-1886-7 29 Sep 2025

Partial Close?

TD-LDT-1886-7 29 Sep 2025

1760 is now the expected nominal count for full travel? If 1760 is center of bell curve and 1700 is minimum, then 1820 should be max (not 1900)?

LEAHI-DD-FIRMWARE-LDT-2198-1 24 Sep 2025

I believe baro is being moved to the TD firmware. DD will have to get baro readings from TD broadcasts.

LEAHI-TD-FIRMWARE-LDT-3126-1 23 Feb 2026

Remove blank line.

LEAHI-DD-FIRMWARE-LDT-3603-1 06 Mar 2026

See my comment above. We should return BOOL so Dialin request can be ACK/NAK'd.

LEAHI-APPLICATION-LDT-1440-1 10 Oct 2025

RESOLVED

LEAHI-TESTSUITES-LDT-2085-1 25 Sep 2025

fixed typo

LEAHI-TESTSUITES-LDT-2085-1 29 Sep 2025

RESOLVED

LEAHI-APPLICATION-LDT-1440-1 08 Oct 2025

Remove Box column.