•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-1440-1 10 Oct 2025

RESOLVED

LEAHI-SW-PLUGINS-SIM-LDT-1440-1 10 Oct 2025

Will be done in next story.

TD-LDT-1886-7 29 Sep 2025

Why would we not initialize FPGA control? Is it too soon?

TD-LDT-1886-7 29 Sep 2025

Add function headers.

TD-LDT-1886-7 29 Sep 2025

Remove extra blank line.

LEAHI-COMMON-LDT-4832-1 07 Jul 2026

remove spaces before =

LEAHI-TD-FIRMWARE-LDT-4029-1 09 Jul 2026

Don't put comments on function prototypes. Doxygen gets details of functions from the function header.

LEAHI-TD-FIRMWARE-LDT-4029-1 09 Jul 2026

Syringe pump should already be stopped if preload is done. Do we need to call this here?

LEAHI-DD-FIRMWARE-LDT-4614-1 08 Jul 2026

Remove empty line.

LEAHI-DD-FIRMWARE-LDT-3372-2 04 Mar 2026

If all enumeration constants are non-negative and fit within the range of an int or unsigned int, the compiler has the flexibility to choose either a signed or unsigned type. In many common implementations, it defaults to a signed int

LEAHI-APPLICATION-LDT-1616-1 23 Sep 2025

yes when not active you can press increment or decrement which will then show the value and set value to the default value

LEAHI-APPLICATION-LDT-1616-1 23 Sep 2025

same?

LEAHI-APPLICATION-LDT-1616-1 24 Sep 2025

RESOLVED.

LEAHI-DIALIN-LDT-2300-1 22 Sep 2025

I didn't see dbg variables in the publish list above.

LEAHI-DD-FIRMWARE-LDT-1196-6 30 Sep 2025

Done

LEAHI-APPLICATION-LDT-1440-1 07 Oct 2025

Updated.

LEAHI-APPLICATION-LDT-1440-1 09 Oct 2025

Updated.

LEAHI-DD-FIRMWARE-LDT-3372-2 06 Mar 2026

fixed.

LEAHI-DD-FIRMWARE-LDT-3372-2 06 Mar 2026

fixed.

LEAHI-DD-FIRMWARE-LDT-3372-2 06 Mar 2026

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-4733-1 08 Jul 2026

Remove extra blank lines.

LEAHI-DD-FIRMWARE-LDT-3603-1 06 Mar 2026

Declarations should be at top of scope (right before memcpy).

LEAHI-TD-FIRMWARE-LDT-3505-1 05 Mar 2026

blank line before return.

LEAHI-TD-FIRMWARE-LDT-3505-1 05 Mar 2026

Blank line after declarations.

LEAHI-APPLICATION-LDT-1440-1 09 Oct 2025

Updated.

LEAHI-APPLICATION-LDT-2264-1 10 Oct 2025

RESOLVED

LEAHI-APPLICATION-LDT-2264-1 07 Oct 2025

1) What are the actions for the:

  • ACT: SW =>UI
  • ACT: SW<= UI
    after the interval expiration?
    Do we have any notifications or updates on the UI from the SW?
    I think there should be only one SW->SW.


2) Changing the expiration to "time out" makes more sense.

3) Vitals (Manujal), TCH: ... integreated (typo) ....

LEAHI-TD-FIRMWARE-LDT-2240-1 06 Jul 2026

I would keep blank line between library includes and regular includes.

LEAHI-DIALIN-LDT-2264-1 10 Oct 2025

shall end with RESPONSE

LEAHI-APPLICATION-LDT-1440-1 09 Oct 2025

Verify image size.

LEAHI-APPLICATION-LDT-1440-1 08 Oct 2025

Update TreatmentAdjustmentUltrafiltrationItem to prevent showing subscreens if TreatmentHome is not visible.

LEAHI-APPLICATION-LDT-1440-1 10 Oct 2025

RESOLVED

LEAHI-APPLICATION-LDT-1440-1 10 Oct 2025

RESOLVED

LEAHI-APPLICATION-LDT-1440-1 01 Oct 2025

Add mention for UF Start screen states (paused/resumed).

LEAHI-DD-FIRMWARE-LDT-3735-1 14 Jul 2026

If this is a override message handler, it is not in the table in Messaging.c and it does not have the proper parameter list (1 parameter for a message pointer).

LEAHI-DD-FIRMWARE-LDT-4733-1 08 Jul 2026

Count datatype seems to be integer. Type case to F32 to match with denominator data type.

LEAHI-DD-FIRMWARE-LDT-4733-1 08 Jul 2026

Remove empty space.

LEAHI-APPLICATION-LDT-4919-1 10 Jul 2026

fixed

LEAHI-DD-FIRMWARE-LDT-4614-1 08 Jul 2026

Remove empty line

LEAHI-APPLICATION-LDT-5074-3 10 Jul 2026

removed

LEAHI-DIALIN-LDT-4484-1 12 Jul 2026

Zoltan and I had a meeting, and the counter solution he provided works better than mine.
He explained to me that my proposed solution has flaws.
RESOLVED.

LEAHI-TD-FIRMWARE-LDT-4049-1 14 Jul 2026

Add a TODO

LEAHI-TD-FIRMWARE-LDT-4049-1 14 Jul 2026

Is this too early to tell DD to start? Ask Vinay.

LEAHI-TD-FIRMWARE-LDT-4049-1 14 Jul 2026

Change reject reason to DD_BUSY.

LEAHI-DD-FIRMWARE-LDT-3735-1 14 Jul 2026

Since these are coming from UI s/w now (right?), I don't think they should begin with "test" which we reserve for messages that only come from Dialin.
Move up above "test" functions.

LEAHI-DD-FIRMWARE-LDT-3735-1 14 Jul 2026

Add blank line between declarations and rest of function code.

LEAHI-DD-FIRMWARE-LDT-3735-1 14 Jul 2026

Add blank line before return statement.

LEAHI-DD-FIRMWARE-LDT-3735-1 14 Jul 2026

Add blank line between declarations and rest of function code (throughout this unit)

LEAHI-TESTSUITES-LDT-2278-1 03 Dec 2025

Please add a test to automatically send BP data...
1. Measure Vitals Button -> press button then send data from fw and the field will automatically populate on popup
2. When timer expires...
1. Test No rejection reason after expiration FW receives request then FW sends Vitals data and the vitals section on the main treatment screen will update with those values.
2 . Test With a rejection reason when time expires then the vitals popup will automaticallly popup and test that the popup appears if request is rejected

LEAHI-TD-FIRMWARE-LDT-3126-1 23 Feb 2026

Removed