Comment Search

space b/w '}' and 'Conductivity'. seen other places too in the file, please check and update.

remove the strings.py file from the project now that we are not going to be using it.

Why here?

I think so. the TD needs to know if we are successful in transitioning to PreGen for either the DD or the FP. Otherwise, TD is waiting for something else that'll never happen.

whether that should be a separate message response or ACK is up for discussion.

can you get the path relatively and not hard coded. This path is specific to your VM

updated

No I removed it.

Any specific reason this file is not refactored to the new standard?

Do not use the magic number.

Always check the return value of snprintf to detect potential errors

There shouldn't be a name if using typedef

switch case is better than if else. check for all similar implementation.

Need doxygen comments for all of the parameter

comparing signed and unsigned value. make FLOAT_COUNT as unsigned. Not checking the return value of snprintf if there is any error happened or not.

space required

can you get the path relatively and not hard coded. This path is specific to your VM

use complete word as in line 87 and 88 , PRESSURE

this will not work and fail. This is build specific and will only work with the current leahi build.. Please get the version using "./leahi --version" and use that

Should we be calling a get function in Conductivity.c (monitor) instead of driver? Monitor would give a filtered value and driver would give a raw value. I would think only the monitor would want the raw value.

Need doxygen comment.

Prefer something like if ( FALSE == isQueueFull() ).

#ifdef

let RO comes first , MSG_ID_FP_RO_FILTERED_REJECTION_RATIO

Follow alphabetical order of including header file

Fixed. Thanks