•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-2198-1 16 Sep 2025

Michael Garthwaite: Can we remove the M4 valve controls (across) in DD and keep it only as part of the IO/FP? So that the M4 valve actuation is done by one entity.

LEAHI-APPLICATION-LDT-1616-1 17 Sep 2025

Use "can" instead of "allow" to be consistent.

LEAHI-APPLICATION-LDT-1616-1 17 Sep 2025

Please do not use "do" for properties.
Those are intended for public slots.

For properties use "is", "has", "can", ...
Even active was better to be as "isActive" since it is bool.

LEAHI-APPLICATION-LDT-1616-1 17 Sep 2025

1 - The following properties belong to the same caller object:

  • vTreatmentCreate.acidConcentrateSet
  • vTreatmentCreate.acidConcentrate
    Therefore, the object already has it. Why do you send that back to it?


2 - You have the parameters in the following properties of the same object. Why do you work with the index to get the text and split it?

  • acidConcentratePotassium
  • acidConcentrateCalcium
LEAHI-DD-FIRMWARE-LDT-3372-2 04 Mar 2026

function removed. DD will now fault if we hit a failed state per execConductivityTeensy

LEAHI-TESTSUITES-LDT-3014-1 05 Mar 2026

Added the comment line in names.py file

LEAHI-TESTSUITES-LDT-2819-1 03 Mar 2026

I will remove this file we are trying to format the names.py file by using the python code instead of doing it manual it is still inprogress

LEAHI-DD-FIRMWARE-LDT-3372-2 06 Mar 2026

added

LEAHI-DD-FIRMWARE-LDT-3372-2 05 Mar 2026

Add default. What should we do if caller passed invalid sensor ID?

LEAHI-TD-FIRMWARE-LDT-1903-8 23 Feb 2026

Put each condition in ().
Also, should the setAirPumpState function be checking power is in range instead of here?

LEAHI-TD-FIRMWARE-LDT-3126-1 23 Feb 2026

Updated

LEAHI-DD-FIRMWARE-LDT-3372-2 04 Mar 2026

There is no default case in that function
switch ( sensorId )

Unknown macro: { case P9_COND}
LEAHI-APPLICATION-LDT-1616-1 18 Sep 2025

1-They come from different caller objects. The caller containing the acid concentrate QStringList is VTreatmentRanges and the set and selected index come from VTreatmentCreate.

2- Inside VTreatmentRanges the acidConcentratePotassium and acidConcentrateCalcium are RANGESET(). They get the ranges from the .conf file only so i could not use those to store the set value.

LEAHI-TESTSUITES-LDT-2278-1 06 Mar 2026

Updated the method

LEAHI-APPLICATION-LDT-1616-1 18 Sep 2025

reason adding actualValue is to achieve synchronization of both create Rx and the Rx popup. actualValue is only used in the refresh() method inisde of ValueAdjsuter.qml. To update the other instance of PreTreatmentCreateContent with the set vTreatmentCreate.<value> when its updated on the other one.

LEAHI-APPLICATION-LDT-1616-1 17 Sep 2025

When the dialog is invisible, the notification shall be cleared for the next time.

LEAHI-DD-FIRMWARE-LDT-3372-2 06 Mar 2026

Remove blank line.

LEAHI-TD-FIRMWARE-LDT-1903-9 06 Mar 2026

Should this event be TD_EVENT_AIR_TRAP_FILL?

LEAHI-COMMON-LDT-4832-1 01 Jul 2026

Is ADJUST appropriate in context of this message? What are we adjusting?

LEAHI-TD-FIRMWARE-LDT-4013-2 02 Jul 2026

Should this be an enum type?

LEAHI-TD-FIRMWARE-LDT-4160-1 02 Jul 2026

test instead of handle

LEAHI-TD-FIRMWARE-LDT-3126-1 23 Feb 2026

Updated

LEAHI-APPLICATION-LDT-1616-1 18 Sep 2025

updated per offline discussion. No confirm response. Updated to close when entering MODE_PRET

LEAHI-DD-FIRMWARE-LDT-3372-2 04 Mar 2026

The provided formula calculates electrolytic conductivity (k) by relating impedance measurements from a sensor to known calibration coefficients (B1,B2,B3) and an offset (B0).
k: The calculated conductivity.
impRz : The impedance of the solution, typically measured at a specific frequency (e.g., 100 kHz).
rtdRZ: The resistance of the Resistance Temperature Detector (RTD), used to perform temperature compensation.
B1,B2,B3, B0 : Empirical calibration coefficients specific to the sensor's geometry and electronic characteristics.

Linear Term (B3): Represents the primary relationship between conductance (1/impRZ) ) and conductivity. The factor of 1000 often scales the result into standard units like mS/cm or uS/cm

Temperature Compensation (B2 and B1): Since conductivity is highly temperature-dependent, these terms use rtdRZ
to adjust the calculation based on the actual temperature of the fluid. The logarithmic term (ln(rtdRz) accounts for non-linearities in the temperature response.

Offset (B0): Corrects for any residual signal or "zero-point" error in the measurement electronics.
.

LEAHI-APPLICATION-LDT-783-1 19 Sep 2025

Add missing parameter.

LEAHI-APPLICATION-LDT-783-1 19 Sep 2025

RESOLVED

LEAHI-APPLICATION-LDT-783-1 19 Sep 2025

RESOLVED

LEAHI-APPLICATION-LDT-783-1 19 Sep 2025

Update details

LEAHI-DD-FIRMWARE-LDT-4410-3 06 Jul 2026

What is 4 (or 2)? Should be #define or enum or const.

HD-DENBUG-326-1 22 Sep 2025

These should be initialized to zero in init function.

LEAHI-APPLICATION-LDT-1616-1 16 Sep 2025

TBDL: Let's discuss more later.

The clear functions in the stack are to call all the clear functions of the screens managed by the stack.
Any reason why it was removed from here?

LEAHI-DD-FIRMWARE-LDT-1196-6 07 Oct 2025

LDT-2198 was merged into this branch after being merged into staging_alpha. Branch will be killed and relevant code changes were reviewed appropriately.

LEAHI-APPLICATION-LDT-1616-1 23 Sep 2025

understood, but you have now two varables/propery for this purpose the one with _ in qml and the one with set in C++.
how do they get in sync?

LEAHI-DD-FIRMWARE-LDT-3372-2 05 Mar 2026

updated newCondModel to be a U32 before check then casted to enum after. Note: Calculate conductivity has a default statement that will catch any value that is outside of the model enum ( and execute standard conductivity model )

LEAHI-APPLICATION-LDT-2264-1 08 Oct 2025

updated

LEAHI-DD-FIRMWARE-LDT-3372-2 06 Mar 2026

removed check. the check now happens on before the get.

LEAHI-APPLICATION-LDT-1616-1 23 Sep 2025

same

LEAHI-APPLICATION-LDT-1616-1 16 Sep 2025

TBDL: Let's discuss more later.

Can you explain this block?
Why it calls the doCancell() regardless of the menu selection, shouldn't it be only for the Edit Rx?
And what is the actualIndex++?

LEAHI-APPLICATION-LDT-1616-1 23 Sep 2025

If not isActive, then canIncrement?

LEAHI-APPLICATION-LDT-1440-1 26 Sep 2025

Since radius can be set on this whole ProgressBar component externally, it is up to the user of this component to set the radius if there is a marker.
There is not a way internally to definitively enforce that there is no radius on the progress bar when a marker is present, if a radius is set manually externally.

Also, leaving this binding to the parent radius so that the radius of the inner fill will match the radius of the outer progress bar.

LEAHI-APPLICATION-LDT-1616-1 22 Sep 2025

Why is this changed to the properties,
what about the others?
does it make the code out of sync between functions?

LEAHI-DD-FIRMWARE-LDT-3372-2 06 Mar 2026

Remove extra blank line.

LEAHI-TESTSUITES-LDT-2085-1 24 Sep 2025

yes you are right.. i snuck in an objectName in LDT 1616 so I can do this and removed the text property

LEAHI-DIALIN-LDT-2300-1 22 Sep 2025

Replace "hd" with "dd".

LEAHI-TD-FIRMWARE-LDT-4072-2 27 Jun 2026

Where is testBatteryI2cStatusOverride (from BatteryDriver)?

LEAHI-APPLICATION-LDT-1440-1 30 Sep 2025

Previous implementation used two separate components (ProgressBarEx and Slider) that are visually separated for adjusting UF volume, so the previous components and implementation cannot be used for the new design.

LEAHI-APPLICATION-LDT-1440-1 30 Sep 2025

Fixed

LEAHI-APPLICATION-LDT-1440-1 30 Sep 2025

RESOLVED

LEAHI-APPLICATION-LDT-1440-1 30 Sep 2025

RESOLVED

LEAHI-TD-FIRMWARE-LDT-4160-1 07 Jul 2026

change accordingly