•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-3344-1 20 Feb 2026

This is total mess up . that is what I want it a clean implementation. created a ticket LDT-3563 and closing all review comments.

LEAHI-TD-FIRMWARE-LDT-1903-8 21 Feb 2026

capital F

LEAHI-TD-FIRMWARE-LDT-3126-1 20 Feb 2026

Input and Output is cumulativeBloodPrimevolume_mL.

LEAHI-TD-FIRMWARE-LDT-473-2 20 Feb 2026

I thought acid fields were F32?

LEAHI-TD-FIRMWARE-LDT-3126-1 20 Feb 2026

We need to look for user request to resume from pause where we would restart BP (at last rate we were at before pause) and re-open art/ven pinch valves and transition back to either ramp or run state (whichever state we were in when we paused).

LEAHI-DD-FIRMWARE-LDT-3344-1 19 Feb 2026

done.

LEAHI-TD-FIRMWARE-LDT-3126-1 03 Mar 2026

Removed

LEAHI-DD-FIRMWARE-LDT-3344-1 19 Feb 2026

done.

LEAHI-TD-FIRMWARE-LDT-3126-1 03 Mar 2026

These are the correct min/max values, but we can't use literals like this. Our coding standard calls these "magic numbers". What we want to do is call getU32TreatmentParamLowerRangeLimit() and getU32TreatmentParamUpperRangeLimit() functions from the TxParams service.

LEAHI-DD-FIRMWARE-LDT-3344-1 19 Feb 2026

done.

LEAHI-APPLICATION-LDT-1616-1 16 Sep 2025

It is not necessary, and will be redundant.
Please share extra requests before modifications.

LEAHI-APPLICATION-LDT-1616-1 16 Sep 2025

Thanks for the clarification.
Let me dig deeper during the execution review, and we'll discuss it then.

TBDL: Let's discuss more later.

LEAHI-DD-FIRMWARE-LDT-3344-1 19 Feb 2026

done. Please check if you are looking at the latest commit.

LEAHI-DD-FIRMWARE-LDT-3372-2 04 Mar 2026

Then need to add a default case in that function

LEAHI-TESTSUITES-LDT-2278-1 06 Mar 2026

Added the method to check the integrated BP cuff value from system,conf file if it is disable enable the value from UI
check_bp_cuff_enabled

LEAHI-DD-FIRMWARE-LDT-3344-1 18 Feb 2026

Only 1 return statement per function.

LEAHI-TD-FIRMWARE-LDT-473-2 18 Feb 2026

Can we uncomment these and send msg?

LEAHI-DD-FIRMWARE-LDT-3344-1 20 Feb 2026

Move this up to public definitions section.

LEAHI-DD-FIRMWARE-LDT-3344-1 20 Feb 2026

use getFPGAVersions() to check this . if Beta 1.9 , FPGA version id is 4 and 6 if beta 2.0

LEAHI-DD-FIRMWARE-LDT-3344-1 19 Feb 2026

Yes define registers for all variants without #if 1 and mark a TODO for removal later.

LEAHI-DD-FIRMWARE-LDT-3344-1 20 Feb 2026

Level.c is a higher level abstracted functions and should not implement the HW dependent details in this file. this details should be pushed to FPGADD. and single function should handle all the cases instead of multiple functions.

LEAHI-TESTSUITES-LDT-2278-1 05 Mar 2026

update method to

    # handler for messages from UI to FW
def handle_patient_vitals_request( message, timestamp = 0.0):
    """
    Called when the user requests to firmware from UI
    @return: None
    """
    global vitalsrequest
    vitalsrequest = True
LEAHI-DD-FIRMWARE-LDT-3372-2 06 Mar 2026

Why is D74 not a Teensy? And I though you were getting ride of this build switch and using test config (run time switch)?

LEAHI-APPLICATION-LDT-3393-1 06 Mar 2026

removed and model now lives in c++

LEAHI-TD-FIRMWARE-LDT-1903-8 23 Feb 2026

This looks like develop branch got merged into your branch. We should not be doing that. Always merge your branch to develop in that direction only.

LEAHI-APPLICATION-LDT-1616-1 17 Sep 2025

The intent is to synchronize. If the user clears either the popup Rx or the pretreatment create Rx then only that instance was clearing before. Not both. So now when we initiate the clear (when back to standby "onStandbyChanged" or when the "Clear All" option is selected in prescription ) the order is (Q_INVOKABLE call ) vTreatmentCreate.doClear() -> (c++ signal) emit didClear() -> (slot in qml) onDidClear() -> (QML method) _root.clear(). The _root.clear() is inside the PreTreatmentCreateContent so all instances of it will get cleared at the same time synchronizing them and this removes that stack dependency linking all those clear methods down to the same _root.clear

LEAHI-APPLICATION-LDT-1616-1 16 Sep 2025

Since we have the underlying highlighter, why do we need this?

LEAHI-TD-FIRMWARE-LDT-3126-1 23 Feb 2026

Updated

LEAHI-TD-FIRMWARE-LDT-1903-8 23 Feb 2026

If I don't check it here, Dialin get a true for even invalid range. I need to pass the result immediately to user so that user can take the action.

LEAHI-APPLICATION-LDT-1616-1 17 Sep 2025

Thanks for the clarification.
No need for any extra notification, that would be redundant then.
Although it is not used, since its pair (pass) is used, let's keep the fail signal.
RESOLVED.

LEAHI-APPLICATION-LDT-1616-1 16 Sep 2025

move this to the Variables to make sur the same is typed always and use the code completion qml checks.
keep the qsTr in the Variables.qml definitions.

Or define in here (same qml) if not used anywhere else.

LEAHI-DD-FIRMWARE-LDT-3603-1 06 Mar 2026

We shouldn't request op mode until we're sure we're happy with the whole thing.
Need to determine whether we are already in the op mode being requested. If so, no need to request it again - just request new sub mode if not already in it. If not, the currentSubMode checked below is not relevant (applies to current mode, not the requested mode) and we need to request new op mode and signal that new op mode that we will want to start in a specific sub mode.

LEAHI-APPLICATION-LDT-3433-1 05 Mar 2026

generate new image with message id

LEAHI-TESTSUITES-LDT-2278-1 05 Mar 2026

this test is not added to test the measure button i do not see qhewre o_measureVitalsButton_TouchRect is pressed other than the place its not needed

LEAHI-TD-FIRMWARE-LDT-3505-1 18 Feb 2026

Just a heads up that all message handling functions in Leahi have the same prototype - just different function names (i.e. BOOL funcName( MESSAGE_T *message)) and that includes all Dialin command message handlers like these.

LEAHI-TD-FIRMWARE-LDT-1903-8 23 Feb 2026

Yes, without checking the changes in this file, I pushed it. It is OK when I merge the code. There is no option to correct since my local branch shows 28.its auto generated and it will take next version during the merge with staging.

LEAHI-DD-FIRMWARE-LDT-3372-2 06 Mar 2026

fixed

LEAHI-DD-FIRMWARE-LDT-3352-1 23 Feb 2026

its a reverse logic - is it OK to make positive instead of not defined ?

LEAHI-TESTSUITES-LDT-2819-1 05 Mar 2026

please also removet his file as well

LEAHI-TESTSUITES-LDT-3060-1 03 Mar 2026

Now updated to first Standby then click on Settings menu, then Service Mode as already logged with password before, then click on feature configuration option
td_simulator.td_operation_mode(TDOpModes.MODE_STAN.value, 0)
headerbar_container = waitForObject(names.o_mainMenu_MainMenu, 3000)
mouseClick(utility.findChildByText(headerbar_container, config.SETTINGS))

td_simulator.td_operation_mode(TDOpModes.MODE_SERV.value, 0)
device_settings_grid = waitForObject(names.o_DeviceSettingsGrid, 3000)
mouseClick(utility.findChildByText(device_settings_grid, config.FEATURE_CONFIGURATIONS))

LEAHI-APPLICATION-LDT-1616-1 16 Sep 2025

Could you use update instead of sync, for consistency, since it has not been used anywhere for that purpose, and also sync is mainly used for cloud data communications?
For all the accuracies <Sync>All, Synchronize, sync, .....

LEAHI-TD-FIRMWARE-LDT-3126-1 23 Feb 2026

Should we add this test config? Systems team will likely want it eventually since they wanted it in Denali.

LEAHI-TD-FIRMWARE-LDT-3126-1 23 Feb 2026

I will Update as per Raghu treatment parameter

LEAHI-DD-FIRMWARE-LDT-3372-2 06 Mar 2026

fixed.

LEAHI-DD-FIRMWARE-LDT-3352-1 23 Feb 2026

need a brief description about this feature and how it is implemented/logic/math etc - also comment on the previous logic

LEAHI-DD-FIRMWARE-LDT-3372-2 04 Mar 2026

at least mention what is the difference between the two apparoach?

LEAHI-DD-FIRMWARE-LDT-2198-1 16 Sep 2025

Michael Garthwaite: Can we remove the M4 valve controls (across) in DD and keep it only as part of the IO/FP? So that the M4 valve actuation is done by one entity.

LEAHI-APPLICATION-LDT-1616-1 17 Sep 2025

Use "can" instead of "allow" to be consistent.

LEAHI-APPLICATION-LDT-1616-1 17 Sep 2025

Please do not use "do" for properties.
Those are intended for public slots.

For properties use "is", "has", "can", ...
Even active was better to be as "isActive" since it is bool.

LEAHI-APPLICATION-LDT-1616-1 17 Sep 2025

1 - The following properties belong to the same caller object:

  • vTreatmentCreate.acidConcentrateSet
  • vTreatmentCreate.acidConcentrate
    Therefore, the object already has it. Why do you send that back to it?


2 - You have the parameters in the following properties of the same object. Why do you work with the index to get the text and split it?

  • acidConcentratePotassium
  • acidConcentrateCalcium