•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-3344-1 18 Feb 2026

I don't see an alarm triggered in this function.

LEAHI-DD-FIRMWARE-LDT-3344-1 18 Feb 2026

If result is U08, why are we returning U16?

LEAHI-TD-FIRMWARE-LDT-3539-1 20 Feb 2026

Updated

LEAHI-TD-FIRMWARE-LDT-473-2 19 Feb 2026

Updated

LEAHI-TD-FIRMWARE-LDT-473-2 20 Feb 2026

removed both enums

LEAHI-DD-FIRMWARE-LDT-3344-1 19 Feb 2026

There is a standardized level checking logic proposed , please check with Noe

LEAHI-DD-FIRMWARE-LDT-3344-1 20 Feb 2026

readFloaterLevelStatus is higher level functions that give the data from the FPGA.
Reason why we had these get functions here is, based on the FPGA response we translate it to the user understandable enum values (low, medium, high)

LEAHI-APPLICATION-LDT-1616-1 16 Sep 2025

TBDL: Let's discuss more later.

Move to the PreTreatmentCreateStack.qml
Think of these types of things as modules.
If you have the CreateTreatment as a module, the Stack manager file shall take care of screens and their state, and not the main.qml.
Is there any reason they are called here and not on the section that has been removed from the Create Stack?

LEAHI-TD-FIRMWARE-LDT-3126-1 02 Mar 2026

Updated

LEAHI-TD-FIRMWARE-LDT-1394-1 02 Mar 2026

Update I/O section here to include rotor revs accumulated and previous.

LEAHI-TD-FIRMWARE-LDT-3126-1 02 Mar 2026

Should we set resume state here? I know it's initialized to ramp state already, but in case we come back to ramp it may be safer to set it here.

LEAHI-TD-FIRMWARE-LDT-3505-1 18 Feb 2026

We will not have this saline bolus state in Leahi.

LEAHI-TD-FIRMWARE-LDT-473-2 20 Feb 2026

Updated

LEAHI-TD-FIRMWARE-LDT-473-2 19 Feb 2026

Had that question. Thanks
Changed to else block

LEAHI-TESTSUITES-LDT-2741-1 03 Mar 2026

added all options as function comment for user reference

LEAHI-DD-FIRMWARE-LDT-3344-1 19 Feb 2026

Updated

LEAHI-TD-FIRMWARE-LDT-3126-1 03 Mar 2026

I think what matters is that we are in Treatment: Blood Prime state. I think any of the 3 blood prime states is ok for this message.

LEAHI-APPLICATION-LDT-1616-1 17 Sep 2025

RESOLVED.

LEAHI-DD-FIRMWARE-LDT-3344-1 12 Feb 2026

Can we follow the same terminology as DD, starting a variable with 'fpga...'. for all IOFP variables?

LEAHI-DD-FIRMWARE-LDT-3344-1 19 Feb 2026

changed.

LEAHI-TD-FIRMWARE-LDT-3126-1 03 Mar 2026

I think result and accepted are essentially the same. We should just have one flag and only set to TRUE if everything is correct.

LEAHI-DD-FIRMWARE-LDT-3344-1 19 Feb 2026

changed to U32

LEAHI-TD-FIRMWARE-LDT-1840-1 20 Feb 2026

This is a msg payload structure. Even though all fields are 4 bytes, we should still pack it in case we add smaller fields later.

LEAHI-DD-FIRMWARE-LDT-3344-1 19 Feb 2026

removed from GPIO file and added in FpgaDD.c file

LEAHI-DD-FIRMWARE-LDT-1477-1 20 Feb 2026

These don't need to be initialized.

LEAHI-DD-FIRMWARE-LDT-3344-1 19 Feb 2026

done

LEAHI-DD-FIRMWARE-LDT-3344-1 19 Feb 2026

done.

LEAHI-DD-FIRMWARE-LDT-3344-1 19 Feb 2026

done.

LEAHI-DD-FIRMWARE-LDT-3344-1 20 Feb 2026

Noe says we can distinguish between beta 1.9 and 2.0 w/ ID (4 and 6).
We still need test configs for beta 1.0 stuff and non-fpga differences.
We can use DD fpga ID # here in this macro instead of test config.
Since this is all temporary, I'm not that concerned about how we do this so long as it works.

LEAHI-DD-FIRMWARE-LDT-3344-1 18 Feb 2026

Seems old file. sync with latest staging

LEAHI-DD-FIRMWARE-LDT-3344-1 20 Feb 2026

why do we need #if 1 here ?

LEAHI-DD-FIRMWARE-LDT-3344-1 20 Feb 2026

This is a reset call, as the default requirement is to be on Beta 1.9 HW
The logic is checking if the user is resetting the Beta 2.0 config, if yes, we will have to fall back to the Beta 1.9 FPGA registers

LEAHI-DD-FIRMWARE-LDT-3344-1 20 Feb 2026

I think Sameer is saying that the monitor should just call one get level function in FPGA and that one function (in FpgaDD.c) would handle all of this beta 1/1.9/2.0 stuff.
I agree, but didn't comment on it because it's all temporary anyway.

LEAHI-DD-FIRMWARE-LDT-3344-1 18 Feb 2026

We should be a little more descriptive in brief here. Describe calculation of pump speed, monitoring for pump speed alarms and publishing pump data.

LEAHI-DD-FIRMWARE-LDT-3344-1 18 Feb 2026

I would consider leaving publish here. Monitor is called from priority task. CAN publishing happens in general task.

LEAHI-DD-FIRMWARE-LDT-3344-1 18 Feb 2026

Only 1 return per function.

LEAHI-TD-FIRMWARE-LDT-3539-1 20 Feb 2026

Updated

LEAHI-TD-FIRMWARE-LDT-3539-1 20 Feb 2026

Why change rank back to 206? If priority is low, rank was probably correct at 711. I think you had correct properties before - it was just in the wrong row.

LEAHI-TD-FIRMWARE-LDT-473-2 18 Feb 2026

When do you plan on removing this?

LEAHI-TD-FIRMWARE-LDT-473-2 20 Feb 2026

you are right, I missed it here.
Fixed.

LEAHI-DD-FIRMWARE-LDT-3344-1 20 Feb 2026

Why do we need a get function to call another get function? The caller of this function should just call getFPGAGPIOStatus() and then we wouldn't need this.

LEAHI-DD-FIRMWARE-LDT-3344-1 20 Feb 2026

why its checking beta 2 and then setting beta 1.9 HW ?

LEAHI-TESTSUITES-LDT-3060-1 23 Feb 2026

Added test.verify as per comment

LEAHI-TESTSUITES-LDT-3060-1 23 Feb 2026

Added test.verify as per comment

LEAHI-TESTSUITES-LDT-3060-1 23 Feb 2026

Added test.verify as per comment

LEAHI-TD-FIRMWARE-LDT-1903-8 20 Feb 2026

Add space around () i.e. ..Scalar( F32 percentage );

LEAHI-TD-FIRMWARE-LDT-1903-8 20 Feb 2026

In comment, specify units is % duty cycle (0..100%).

LEAHI-TESTSUITES-LDT-3060-1 19 Feb 2026

this seems to fail here because if we enter TREATMENT_DIALYSIS_STATE then the Blood Prime screen is not going to show and thus failing the squish test case

LEAHI-TESTSUITES-LDT-3060-1 19 Feb 2026

for testing booleans please use test.verify()

LEAHI-TD-FIRMWARE-LDT-473-2 20 Feb 2026

I think this function should be in ModeTreatment or Messaging.