Comment Search

RESOLVED
BN Approves

RESOLVED
BN Approves

Will resolve it while merging the staging to this branch after CR approval

added a todo for testing it after we have the new beta 2 units.

please use FPGA version function to initialize or handle HW version

this is handled by vTreatmentCreate.doClear() to synchronize the clearing on both the pretreatment create rx and popup. The call has been consolodated and moved to the onStandbyChanged slot in main.qml

Execution Review:

1 - The Rx button should only be visible/work when the op_mode is one of the following (or not the other ones).

• 4 - MODE_TPAR
• 5 - MODE_PRET
• 6 - MODE_TREA
• 7 - MODE_POST

2 - And when the Create Rx screen itself is visible/active.

3 - A request:

• Can you populate the currently added K, Ca from the previous Acit Concentrate addition by the pen icon?
• And if the set K, Ca in the dialog is the same as previously added, notify the user of the duplication, same as what is done for the constant ones which come from the settings.

this has already been addressed. I think you have commented on removed code.

This param has been renamed to HEPARIN_STOP_TIME which is a couple rows below so we don't need to add this.

S in status should be capitalized.

If leak sensor is coming via FPGA, it doesn't belong in GPIO unit. This unit is for GPIO pins on our microprocessor. GPIO pins on FPGA should be gotten using get functions in the FpgaDD unit.

RESOLVED.

Remove extra blank line.

Why remove these functions. All static functions should be prototyped up here.

done.

Updated

please update throughout for testing bools use test.verify

As discussed, this will be done after we stabilize to single fpga structure. To avoid multiple line changes.

done.

done.

done.

done.

done.

done. Please check if you are looking at the latest commit.

read the FPGA ID and initialize it