•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-15306-3 02 Jun 2023

Done.

DD-LDT-482-4 06 Jun 2025

Align comment.

HD-DEN-15306-3 02 Jun 2023

This check is too far out. Each check function inside should check this with DG comm.

LEAHI-DIALIN-LDT-566-1 23 Jun 2025

fixed.

HD-DEN-15306-3 02 Jun 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15306-3 02 Jun 2023

Remove this condition.

LEAHI-DD-FIRMWARE-LDT-3344-1 17 Feb 2026

Vinay, based on your work with rinsepump, Do you have any persistence value in mind?

LEAHI-DIALIN-LDT-566-1 23 Jun 2025

fixed.

RO-LDT-566-1 23 Jun 2025

updated all the alarms of this story to have their respective ranks and properties

LEAHI-DD-FIRMWARE-LDT-3372-2 02 Mar 2026

then we return false as expected

LEAHI-APPLICATION-LDT-2071-1 29 Aug 2025

Thanks!
Resolved.

LEAHI-DIALIN-LDT-566-1 23 Jun 2025

Just removed in firmware.

LEAHI-TD-FIRMWARE-LDT-473-2 17 Feb 2026

replace with else block

RO-LDT-566-1 24 Jun 2025

Alarms in their respective rank

TD-LDT-2043-1 29 Aug 2025

Replace 100 to #define.

RO-LDT-1242-1 29 Aug 2025

I don't think alarms will work with gaps in this enum. Other table(s) will complain I think. Lookups will find wrong alarm, etc...

LEAHI-TD-FIRMWARE-LDT-1903-8 02 Mar 2026

I think this would be a TD s/w fault (alarm already define). Just need a new TD s/w fault ID in AlarmMgmtSWFaults.h.

UI-DENBUG-331-1 17 Feb 2026

RESOLVED
BN Approves

LEAHI-APPLICATION-LDT-1021-1 24 Jun 2025

add another for the disconnect and identify the error in the relative request of the response.

LEAHI-APPLICATION-LDT-1021-1 24 Jun 2025

revert the headerBar anchoring anywhere in this code and leave FIXME: BEHROUZ so I can fix it later.

LEAHI-APPLICATION-LDT-1021-1 24 Jun 2025

follow the WifiList model and attribute to avoid extra connection?

LEAHI-APPLICATION-LDT-1021-1 24 Jun 2025

remove these

LEAHI-TD-FIRMWARE-LDT-3539-1 17 Feb 2026

Priority doesn't look right. Should be High I think. Check properties from Denali project.

LEAHI-APPLICATION-LDT-907-2 04 Aug 2025

RESOLVED

LEAHI-APPLICATION-LDT-907-2 04 Aug 2025

All references to VHDAirBubbleData need to be changed (to VTDAirBubbleData?) or removed.

LEAHI-APPLICATION-LDT-907-2 04 Aug 2025

Filename and class name (and all references to class name in file) do not match.

UI-DENBUG-331-1 17 Feb 2026

RESOLVED
BN Approves

LEAHI-APPLICATION-LDT-907-2 04 Aug 2025

RESOLVED

LEAHI-APPLICATION-LDT-907-2 04 Aug 2025

Msg ID:

LEAHI-APPLICATION-LDT-1536-1 08 Aug 2025

RESOLVED

DD-LDT-1873-1 08 Aug 2025

Should we rename the unit to FPInterface?

LEAHI-DD-FIRMWARE-LDT-2198-1 10 Sep 2025

removed

LEAHI-DD-FIRMWARE-LDT-2198-1 10 Sep 2025

Added

LEAHI-DD-FIRMWARE-LDT-2198-1 09 Sep 2025

Should IO sensors come first?

LEAHI-DD-FIRMWARE-LDT-3344-1 17 Feb 2026

we can start with 500msec. if we change the speed during runtime, say 10% to 20% PWM, need to see how long it takes to stabilize and accordingly this persistence can be set.

LEAHI-DD-FIRMWARE-LDT-2198-1 10 Sep 2025

Done. Yes. In the Init function, there is a default value set.

LEAHI-TD-FIRMWARE-LDT-473-2 17 Feb 2026

Updated

LEAHI-TD-FIRMWARE-LDT-473-2 17 Feb 2026

reworded

LEAHI-TD-FIRMWARE-LDT-3539-1 17 Feb 2026

Based on the Denali properties, I have written the following.

LEAHI-DD-FIRMWARE-LDT-2198-1 10 Sep 2025

it's based on the application need. Currently D4 and D50 set based on the heaters control need. Also D28, D30 temprature moving average done for alarm handling. rest will be handled as needed.

LEAHI-DD-FIRMWARE-LDT-2198-1 10 Sep 2025

Initialize in init function, not here.

LEAHI-DD-FIRMWARE-LDT-2198-1 10 Sep 2025

Add a TODO comment. Is there a workable value to set target pressure to for now until we get baro from TD?

LEAHI-DD-FIRMWARE-LDT-2198-1 10 Sep 2025

Add blank line below banner.

LEAHI-TD-FIRMWARE-LDT-473-2 17 Feb 2026

fixed

LEAHI-DD-FIRMWARE-LDT-3344-1 17 Feb 2026

added a todo.

LEAHI-DD-FIRMWARE-LDT-3344-1 17 Feb 2026

done

LEAHI-DD-FIRMWARE-LDT-3344-1 17 Feb 2026

done.

LEAHI-DD-FIRMWARE-LDT-3344-1 17 Feb 2026

done.

LEAHI-DD-FIRMWARE-LDT-3344-1 17 Feb 2026

done. added a TODO.

LEAHI-DD-FIRMWARE-LDT-3103-1 17 Feb 2026

Vinayakam Mani had it removed. Can you please let us know why you have this commented out in latest staging?