I think this whole function should be moved to the PeristalticPump.c driver unit. We don't want controller/monitor level units directly accessing fpga registers - the drivers should be doing that.
What I meant was that we don't care which blood prime state we're in - what we care about is that we are in treatment mode and priming blood - otherwise this message doesn't make sense and we should reject it because we're not in the right state. if ( ( MODE_TREA == getCurrentOperationMode() ) && ( TREATMENT_BLOOD_PRIME_STATE == getTreatmentState() ) )
I would also use different (4) parameters and give them a relevant, short name, so users in the code can set them as false or true without knowing the -q meaning.
It also gives the application flexibility to change the CLI switches without affecting the rest of the test, and only this function would need to be changed.
* Options:
* -h, --help Displays help on commandline options.
* --help-all Displays help including Qt specific
* options.
* -v, --version Displays version information.
* -c, --canOut Show the Can Frame Output
* -m, --msgOut Show the Message Output
* -l, --logOut Show the Logs Output
* -0, --enable-keep-awake Enable send low priority, empty message
* on the CANBus just to keep UI board CAN
* driver awake
* -i, --fake-interval <interval> Test fake message interval(ms)
* -f, --fake-message <data> Test fake message data
* will use default sequenced long fake
* message if set to 00(default)
* will used only if correct integer value
* assigned for interval option
* -b, --fake-message-seq-at-begin Test fake message sequence at the
* beginning of the frame
* -u, --disable-unhandled-report Disable unhandled messages report as an
* error in the log
* -d, --disable-dialin-unhandled Disable the Dialin messages logged as
* unhandled
* -q, --disable-timeout Disables communication timeout
* -a, --disable-alarm-no-minimize Disables alarm no minimize
* -S, --disable-sd-card-fail-log-stop disable-sd-card-fail-log-stop
* -C, --disable-cloudsync-fail-stop disable-cloudsync-fail-stop
* -k, --disable-check-in-log Disables Check-In Log
* -K, --disable-acknow-log Disables Acknowledgment Log
* -D, --enable-dry-demo Enables Dry-Demo Mode
* -A, --active-can-bus <CANBus> Sets the Active CANBus [Shall start with
* 'can' or 'vcan]
* -E, --enable-manufacturing Enables the manufacturing mode to
* configure the system for the first time.
* -R, --use-root-home In case the application is not in
* Manufacturing Setup but needs to use root
* home folder for configurations.
* -U, --enable-update-mode Enables the update mode to update only
* necessary files during the update and
* keep the rest.
* -x, --use-log-long-name Use the log long file name format
* <date>_<time>_<serial>_<mode>
* -y, --use-log-cloud-upload Use the log cloud upload
* -z, --use-log-compression Use the log compression
* -L, --use-log-unhandled-only Use the unhandled messages only to log
I am still keeping M4 valve for some more time, when there is a need to operate DD stand-alone system (Without FP, but with IO system). So M4 valve and couple of pressure sensors (M1 and M3) are still active in DD system for time being.
Remove the defaultImagePath variable and put the QStringLiteral into the false case of the ternary so that if imagePath exists, then the string construction will never be executed.
Good point. I was going to inform everyone on the SW team (I've already told Tiffany).
We need to keep a correct version of this file in the repository since it includes the build and run parameters of the project (weirdly, although it is project-specific, everyone should use the same configuration and not a user-specific one).
In the past, when I had unit tests in the project, we had to keep changes in this file. Recently, in the Leahi project, I have removed them. Additionally, for the Leahi project, some build configurations have been updated.
In this branch, I have updated the file for the Leahi project, and we should no longer keep track of changes to this file.
Therefore, from now on, after this branch is merged into staging, please ignore any changes QtCreator makes to this file.
