•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DIALIN-LDT-566-1 23 Jun 2025

fixed.

RO-LDT-566-1 23 Jun 2025

Are all of these really low priority? Check properties. Should probably resemble DG faults in Denali.

LEAHI-APPLICATION-LDT-1788-1 01 Aug 2025

RESOLVED

LEAHI-APPLICATION-LDT-1788-1 01 Aug 2025

RESOLVED

DD-LDT-1873-1 08 Aug 2025

Done.

RO-LDT-566-2 01 Aug 2025

Remove blank line.

LEAHI-DIALIN-LDT-566-2 01 Aug 2025

Where is 0x5B?

LEAHI-APPLICATION-LDT-907-2 04 Aug 2025

sources/model/MModel.h include for this file needs to be updated from MHDAirBubbleData.h to MTDAirBubbleData.h

LEAHI-APPLICATION-LDT-3433-1 05 Mar 2026

update anchors and undefine bottom one and remove outer item

LEAHI-APPLICATION-LDT-1788-1 04 Aug 2025

What is the vIndex.column() for?

LEAHI-DD-FIRMWARE-LDT-3372-2 05 Mar 2026

it should be mentioned what function is used for calculating the equation.

DD-LDT-1873-1 08 Aug 2025

I remember seeing once some CRC error. To continue development, disabled fault mode for a while.

DD-LDT-1873-1 08 Aug 2025

This function infers (in its name) that it is for the primary heater only. So why take a heater ID param?

DD-LDT-1873-1 08 Aug 2025

adjustedTargetTemp says it is for the primary heater (d5). Why are we saying it is for the trimmer heater here?

LEAHI-APPLICATION-LDT-2160-1 27 Aug 2025

Can you use MouseArea pressAndHold and pressAndHoldInterval instead of this timer?
(https://doc.qt.io/archives/qt-5.15/qml-qtquick-mousearea.html#pressAndHold-signal)

LEAHI-SW-LDT-2071-1 29 Aug 2025

updated to use conversions.bytearray_to_integer

LEAHI-APPLICATION-LDT-2071-1 29 Aug 2025

Can you remind me where these are used?
We already have the hex version defined in msg_ids.py.

TD-LDT-2043-1 29 Aug 2025

Fixed.

LEAHI-DD-FIRMWARE-LDT-2198-1 09 Sep 2025

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-2198-1 11 Sep 2025

removed

LEAHI-DD-FIRMWARE-LDT-2198-1 11 Sep 2025

Fixed. thanks!

LEAHI-DD-FIRMWARE-LDT-2198-1 09 Sep 2025

FP_SW_FAULT_ID_T

DD-LEAH-227-1 01 Oct 2024

Done.

HD-DEN-15306-3 02 Jun 2023

Done. The countdown timer was renamed for clarity.

HD-DEN-15306-3 01 Jun 2023

This was safer the other way. Why change?

LEAHI-SW-LDT-261-2 05 Jun 2025

RESOLVED

HD-DEN-15306-3 02 Jun 2023

RESOLVED in CODE WALKTHROUGH.

LEAHI-DD-FIRMWARE-LDT-2198-1 09 Sep 2025

Add blank line before pragma.

DD-LDT-482-4 06 Jun 2025

Done.

LEAHI-DD-FIRMWARE-LDT-2198-1 09 Sep 2025

What about non-mode FP init calls (e.g. monitors, etc...)

LEAHI-DD-FIRMWARE-LDT-2198-1 09 Sep 2025

run DD operation ...

LEAHI-APPLICATION-LDT-907-2 04 Aug 2025

same as http://devapps.diality.us:8060/cru/#LEAHI-APPLICATION-LDT-907-2CFR-69436

LEAHI-APPLICATION-LDT-2160-1 10 Sep 2025

This image is not viewable.
Seems like a broken image?

LEAHI-APPLICATION-LDT-450-1 09 Jun 2025

To make the ! more visible, I always try to put a space between the ! and the surrounding text (not to be confused or misread with i,l,|).

LEAHI-APPLICATION-LDT-2160-1 05 Sep 2025

Could you please also add the horizontal slider line(very thin/narrow/1 or 2 pixel height)?
You already have only the indicator/handler, but the line that shows the allowable moving min, max would be very helpful.
Just the line without any numbers or any extra info.

LEAHI-APPLICATION-LDT-1788-1 05 Aug 2025

updated

LEAHI-APPLICATION-LDT-713-1 13 Jun 2025

Thanks, Great catch.
Fixed.

LEAHI-DIALIN-LDT-566-1 23 Jun 2025

fixed.

LEAHI-DD-FIRMWARE-LDT-3372-2 02 Mar 2026

Yes as it is a way for us to identify if the teensy is not responding to us correctly. This along with no LED activity on the board helps us identify teensy failures

LEAHI-APPLICATION-LDT-2160-1 27 Aug 2025

RESOLVED

LEAHI-APPLICATION-LDT-1616-1 17 Sep 2025

Thanks, that works too.
RESOLVED.

LEAHI-APPLICATION-LDT-2160-1 27 Aug 2025

Declare mCategory and size const, if possible.

LEAHI-DD-FIRMWARE-LDT-3372-2 02 Mar 2026

Can you clarify? this is allowing us to switch conductivity calculations based on the needs of the dialin user. ( systems team testing for accuracy )

LEAHI-DD-FIRMWARE-LDT-3372-2 02 Mar 2026

fixed.

LEAHI-DIALIN-LDT-566-1 23 Jun 2025

UF pump doesn't have any temp sensor and nothing to do with this module. I just placed the comment here to add additional UF pump.

LEAHI-DD-FIRMWARE-LDT-3372-2 02 Mar 2026

added

LEAHI-APPLICATION-LDT-1788-1 01 Aug 2025

RESOLVED

LEAHI-APPLICATION-LDT-1788-1 01 Aug 2025

RESOLVED

LEAHI-APPLICATION-LDT-1788-1 01 Aug 2025

RESOLVED

LEAHI-TD-FIRMWARE-LDT-1903-8 02 Mar 2026

fixed in latest code