•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-2686-1 27 Oct 2025

fixed margins

LEAHI-APPLICATION-LDT-2160-1 27 Aug 2025

updated

LEAHI-APPLICATION-LDT-2160-1 27 Aug 2025

It may be more efficient to pass the bool by const value instead of const reference.

RO-LDT-1809-3 27 Aug 2025

Change to ( skipSet != TRUE )

LEAHI-APPLICATION-LDT-1063-1 28 Aug 2025

Learned that FP versions will be merged ENTIRELY with DD and so not needed

LEAHI-APPLICATION-LDT-2686-1 27 Oct 2025

updated

LEAHI-DD-FIRMWARE-LDT-2198-1 10 Sep 2025

Was waiting for changes from Conductivity, uncommented now.

LEAHI-APPLICATION-LDT-2071-1 29 Aug 2025

We need to find a way to notify the user of rejection.
In the current design, I do not see any room to display the rejection reason message.
We may need to consider a dialog that pops up, displaying only the rejection reason for the current response and a close button on top (right/left).

LEAHI-SW-LDT-2071-1 18 Aug 2025

Can you change to say TD Main Treatment Data

LEAHI-DD-FIRMWARE-LDT-2198-1 10 Sep 2025

Done.

LEAHI-APPLICATION-LDT-2686-1 27 Oct 2025

updated

LEAHI-APPLICATION-LDT-2686-1 27 Oct 2025

updated

LEAHI-APPLICATION-LDT-2686-1 27 Oct 2025

updated

LEAHI-APPLICATION-LDT-2686-1 27 Oct 2025

fixed icon

LEAHI-APPLICATION-LDT-2686-1 27 Oct 2025

fixed

LEAHI-APPLICATION-LDT-2686-1 27 Oct 2025

updated

LEAHI-APPLICATION-LDT-2666-1 27 Oct 2025

Updated.

BOOTLOADER-LEAH-1415-1 01 Oct 2024

When do you plan to do this?

HD-DEN-15306-3 02 Jun 2023

Remove blank line.

BOOTLOADER-LEAH-1415-1 01 Oct 2024

When do you plan to do this?

BOOTLOADER-LEAH-1415-1 01 Oct 2024

Remove this function.

HD-DEN-15306-3 02 Jun 2023

Renamed for clarification.

BOOTLOADER-LEAH-1415-1 01 Oct 2024

Returns TRUE if flash complete, FALSE if not.

HD-DEN-15306-3 02 Jun 2023

Done. Changed each instance to the negative form for consistency.

HD-DEN-15306-3 02 Jun 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15306-3 01 Jun 2023

How is this different than checking CPLD? Condition is cleared when CPLD no longer sees power loss (w/ 150ms delay I guess). Seems simpler to use CPLD function instead of checking 2 alarms.

LEAHI-TD-FIRMWARE-LDT-3126-1 26 Feb 2026

Response payload is not U08. I believe UI will be expecting a payload of type UI_RESPONSE_PAYLOAD_T (defined in Messaging.h). Verify with Nico that this is the payload he is expecting in response. See signalPauseResumeUF() function for example of how to respond to a UI request.

HD-DEN-15306-3 02 Jun 2023

RESOLVED in CODE WALKTHROUGH.

DD-LEAH-225-1 16 Oct 2024

I don't see a low-level driver unit for these pumps. Consider breaking this unit up into a driver and a controller.

HD-DEN-15306-3 02 Jun 2023

Done.

BOOTLOADER-LEAH-1415-1 01 Oct 2024

FPGA unit does not need to know when a transmit has completed?

HD-DEN-15306-3 02 Jun 2023

Done.

HD-DEN-15306-3 02 Jun 2023

Needs an else to zero out of range counter.

LEAHI-APPLICATION-LDT-713-1 13 Jun 2025

should this file be excluded in the repository and be in the gitignore as its QtCreator user specific?

DD-LDT-482-4 06 Jun 2025

Done

DD-LDT-482-4 06 Jun 2025

Is this named appropriately?

DD-LEAH-227-1 01 Oct 2024

Target speed is always positive. Fabs is not required in this place and removed.

DD-LEAH-227-1 01 Oct 2024

Done.

DD-LEAH-227-1 01 Oct 2024

Done.

DD-LEAH-227-1 30 Sep 2024

Should be "hasTurnOnPumpsBeenRequested". There are also 2 clear flags being set.

HD-DEN-16680-2 09 Oct 2024

RESOLVED in CODE WALKTHROUGH on behalf of Sean Nash

LEAHI-APPLICATION-LDT-713-1 16 Jun 2025

RESOLVED

RO-LDT-566-1 23 Jun 2025

fixed. Thanks!

LEAHI-APPLICATION-LDT-450-1 09 Jun 2025

remove spacing after vAdjustmentVersions.. same goes for the other times vAdjustmentVersions is being called in this file

LEAHI-SW-LDT-450-1 11 Jun 2025

test

LEAHI-APPLICATION-LDT-450-1 12 Jun 2025

RESOLVED

LEAHI-DIALIN-LDT-566-1 23 Jun 2025

that is cmd_dialysate_delivery_set_state_override(). Line 237

LEAHI-APPLICATION-LDT-1788-1 01 Aug 2025

can not use that here. This clicked assigned the currentIndex property to the delegate index. This if statement is just to do it once if already clicked on.

RO-LDT-566-1 24 Jun 2025

It doesnt consider our include settings when it does the update. good eye and fixed.

RO-LDT-566-1 23 Jun 2025

Do you want to update the filename as well to FP? if so, please update files with RO ( FpgaRO, SystemCommRO etc.,)