•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-907-2 04 Aug 2025

RESOLVED

DD-LDT-1473-2 04 Aug 2025

This is also breaking FP f/w. Why do you both have M4?

LEAHI-APPLICATION-LDT-1788-1 05 Aug 2025

fixed

HD-DEN-15367-1 29 May 2023

Update header. currentPreTreatmentState, signalTestConfigRsrvrMgmtUse

HD-DEN-15196-2 15 May 2023

Fixed. Thanks!

HD-DEN-15367-1 29 May 2023

Add signalTestConfigRsrvrMgmtUse, currentReservoirMgmtState

DG-DEN-15367-1 30 May 2023

Fix alignment.

LEAHI-TD-FIRMWARE-LDT-3126-1 26 Feb 2026

Use getTargetBloodFlowRate() instead.

HD-DEN-15229-1 15 May 2023

Removed

HD-DEN-15196-2 16 May 2023

Fixed. Thanks!

BOOTLOADER-LEAH-1415-1 01 Oct 2024

Why return anything? Your OperationModes unit doesn't not even look at it.

DG-DEN-15196-3 16 May 2023

RESOLVED IN CODE WALK THROUGH

DG-DEN-15196-3 16 May 2023

#define for initial/undefined.

LEAHI-SW-LDT-261-2 30 May 2025

RESOLVED.

DIALIN-DEN-15196-1 16 May 2023

Looks like you're mixing old and new state data in the dictionary.
I would think they would want the new tuples in their own dictionary to have a clean, consistent history of state transitions.
What does Sarina and her team think about this?

LEAHI-SW-LDT-261-2 30 May 2025

RESOLVED

DG-DEN-15274-1 16 May 2023

Remove (U32) cast.

DIALIN-DIAL-252-1 19 May 2023

No code changes made in this branch. Closing review.

HD-DEN-15359-1 26 May 2023

Will always be integers. Prefer to store them that way.

DG-DEN-15413-1 26 May 2023

No firmware changes required. Issue resolved by changes to the DG FPGA Test build.

HD-DEN-15363-2 26 May 2023

Originally there BLD communications was going to use an available alarm. The final decision was to repurpose an existing alarm. Hence there were no firmware changes necessary.

HD-DEN-15359-1 27 May 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-15359-1 25 May 2023

Could these recently added variables be defined as F32 instead of casting?

HD-DEN-15359-1 30 May 2023

Can't keep in message x47 as f/w will not have calculated new min/max yet.
I made it so message x9 will broadcast immediately after user changes pressure limit windows.

HD-DEN-15359-1 31 May 2023

Done.

HD-DEN-15359-1 29 May 2023

Fixed.

HD-DEN-15359-1 29 May 2023

Fixed.

HD-DEN-15359-1 29 May 2023

Yes. Fixed.

HD-DEN-15359-1 29 May 2023

Yes. Fixed.

HD-DEN-15359-1 29 May 2023

Fixed.

HD-DEN-13865-1 29 May 2023

Fixed.

HD-DEN-15359-1 29 May 2023

don't you need to add the venous asymmetric here to be reset?
Since I am going to give user an option to adjust it during treatment.

HD-DEN-15359-1 30 May 2023

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-15359-1 30 May 2023

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-15359-1 29 May 2023

same here?

HD-DEN-15359-1 30 May 2023

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-15359-1 29 May 2023

Isn't the Venous Asymmetric missing?

HD-DEN-15359-1 30 May 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-15359-1 27 May 2023

Add pressureLimitsActive to header.

HD-DEN-15359-1 30 May 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-15359-1 27 May 2023

Add pressureLimitsActive to header.

HD-DEN-13865-1 30 May 2023

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-15396-2 30 May 2023

Updated.

HD-DEN-15359-1 30 May 2023

Thanks, that works too.
RESOLVED IN CODE WALKTHROUGH

HD-DEN-15359-1 30 May 2023

Seems the only message which is providing the calculated A/V min/max is here in message 0x09.
I think it was better to keep the min, max of the arterial and venous in the message 0x47 (A/V InTx adj) to let UI immediately have the updated values,
instead of the x09 which is a broadcast and won't immediately send the updated/calculated min/max, and causes a short delay (depending on interval of the broadcast) to update the UI.
Or in both if the message 0x09 is getting continuously updated during treatment.

HD-DEN-15359-1 30 May 2023

Add stabilizationStartTimeMs to header.

HD-DEN-15396-2 30 May 2023

Consider using MAX() macro in Common.h.

HD-DEN-15396-2 31 May 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15359-1 31 May 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-15455-1 01 Jun 2023

Looks like it's already there.