•  

Comment Results

Review Name Created Custom Fields Content
DD-LEAH-210-5 29 Aug 2024

Done.

DG-DEN-15274-1 17 May 2023

Done

TD-LEAH-32-4 03 Sep 2024

Done.

DD-LEAH-210-5 03 Sep 2024

Done.

DD-LEAH-210-5 03 Sep 2024

Done.

DD-LEAH-210-5 03 Sep 2024

Done.

HD-DEN-15306-1 24 May 2023

If we think that this is the only spurious alarm that may occur with power loss. We know fan rpm also occurs, but the fans do recover when AC returns. Comm errors have occurred, but they seem rare now; it's unclear whether they stop with AC returning or the operational state. Would we expect other operational impacts of operating from battery, or the loss and return of AC? Battery alarms, etc.?

The block timer runs from the time the condition clears in alarm management (cpld flag, or flag plus alarm state). If alarms are not included here, the timer may (probably will) time out with the alarm still active and the valves still improperly positioned. The valve position error will occur immediately after clearing the alarms, even with the alarms status checked in valves. The timer could be relocated to valves, but that doesn't take care of other sources of alarms after power recovery.

LEAHI-SW-LDT-261-2 03 Jun 2025

fixed!

TD-LEAH-32-4 04 Sep 2024

Fixed.

DD-LEAH-227-1 30 Sep 2024

I don't see these params in the function header and they don't appear to be used or needed.

LEAHI-SW-LDT-261-2 03 Jun 2025

fixed!

DD-LEAH-210-5 29 Aug 2024

Add s/w fault.

TD-LEAH-32-4 04 Sep 2024

Remove this code. There is no RTC anymore.

HD-DEN-17053-1 16 Sep 2024

RESOLVED in CODE WALKTHROUGH.

TD-LEAH-41-1 16 Sep 2024

Fixed.

BOOTLOADER-LEAH-1415-1 01 Oct 2024

Shouldn't this state at least transition back to update state when new update request is made? Where does that happen and why doesn't it happen here?

TD-LEAH-41-1 16 Sep 2024

I have changed this common routine to take 16 bit as an input, per latest changes on DD- HDD pressure sensors. please update as required.

DD-LEAH-220-2 16 Sep 2024

Isn't bicarb bag de-scoped?

DD-LEAH-220-2 16 Sep 2024

Replace TD with DD.

LEAHI-SW-LDT-261-2 03 Jun 2025

fixed!

LEAHI-SW-LDT-261-2 28 May 2025

Please add a TODO and a summary stating that "The payload is TBD (as indicated by the provided screen items)".

LEAHI-SW-LDT-261-2 28 May 2025

Please add a TODO and a summary stating that "The payload is TBD (as indicated by the provided screen items)".

BOOTLOADER-LEAH-1415-1 01 Oct 2024

Remove test code.

BOOTLOADER-LEAH-1415-1 01 Oct 2024

Remove test code.

LEAHI-SW-LDT-261-2 28 May 2025

Please change this to CRAPIZED.
Use the Denali ID with either FF at the end or 0F.
To avoid confusion about whether that is the implementation.

LEAHI-SW-LDT-261-2 28 May 2025

Please also complete the DD version request.
We missed the DD one in the Model View.

  • Add any necessary plugins to the simulator as needed.
  • Add a section/component for it on the same page as the others (we do not separate TD,DD for now)
LEAHI-DIALIN-LDT-261-1 27 May 2025

This message is currently not implemented in the fw message list. Sean Nash

Have made a temporary enum in dialin if its sufficient.

RO-LDT-566-2 30 Jul 2025

Can you clarify?

DD-LEAH-227-1 01 Oct 2024

Not required, since the pump will be in "OFF" state when target speed is close to zero. The flag is used to communicate when ramp reached and moved to control state.

DD-LEAH-227-1 01 Oct 2024

Done.

LEAHI-APPLICATION-LDT-1788-1 01 Aug 2025

yes removed

LEAHI-APPLICATION-LDT-1788-1 01 Aug 2025

RESOLVED

LEAHI-APPLICATION-LDT-1788-1 01 Aug 2025

If this property is not being used, then can it be eliminated for now?

LEAHI-APPLICATION-LDT-1788-1 01 Aug 2025

RESOLVED

DD-LDT-1473-1 01 Aug 2025

Done.

LEAHI-APPLICATION-LDT-907-2 04 Aug 2025

Add sources/view/td/data/VTDAirBubbleData.cpp.

RO-LDT-566-2 01 Aug 2025

Remove extra blank lines.

RO-LDT-566-2 01 Aug 2025

Remove blank line.

RO-LDT-566-2 01 Aug 2025

Remove blank line.

DD-LDT-1473-1 04 Aug 2025

Where did this valve enum go?

RO-LDT-1809-3 26 Aug 2025

Why are these here? If not truly common to all f/w, consider moving these functions to FluidPump or ROPump.

LEAHI-APPLICATION-LDT-1536-1 04 Aug 2025

yes it is a component

LEAHI-APPLICATION-LDT-907-2 04 Aug 2025

Put this under the //Project for the project specific imports.
and one empty line after from the next block (//QML imports)

LEAHI-APPLICATION-LDT-907-2 04 Aug 2025

Update the description for this message.

DD-LDT-1873-1 08 Aug 2025

Done.

LEAHI-APPLICATION-LDT-1788-1 04 Aug 2025

please if _root.enableMute = false, do nothing.
I think if we do the _root.clicked(), that will cause development confusion, which means the button is not disabled, it does something that may not be actually related.

DG-DEN-15274-1 13 May 2023

Are these TODOs going to be removed?

HD-DEN-15196-2 15 May 2023

Fixed. Thanks!

LEAHI-TD-FIRMWARE-LDT-3126-1 26 Feb 2026

I think we actually should be getting commanded blood flow rate here (getTargetBloodFlowRate) instead of measured rate.

HD-DEN-15196-2 15 May 2023

RESOLVED in CODE WALKTHROUGH.