•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-15196-2 16 May 2023

RESOLVED IN CODE WALKTHROUGH

DD-LEAH-210-5 03 Sep 2024

Done.

DG-DEN-15274-1 16 May 2023

Done

LEAHI-DIALIN-LDT-261-1 28 May 2025

Thanks
RESOLVED

DD-LEAH-210-5 03 Sep 2024

Done.

DG-DEN-15274-1 17 May 2023

If these are only for Dialin, move down to test support functions area.

DG-DEN-15274-1 17 May 2023

RESOLVED in CODE WALKTHROUGH.

TD-LEAH-32-4 04 Sep 2024

We should have #define for this number.

TD-LEAH-32-4 04 Sep 2024

This line needs a doxygen comment.

LEAHI-SW-LDT-261-2 28 May 2025

The BOOL in FW is 4 bytes (U32).
Please update the length in the model as well.

TD-LEAH-32-4 04 Sep 2024

Do you think we need it? So we should ask Noe to add it?

DD-LEAH-210-5 29 Aug 2024

Alphabetize the app includes.

TD-LEAH-32-4 04 Sep 2024

Some day. I don't even know what it is and if we even used it in Denali. For now, I want to close this out and merge to staging.

TD-LEAH-41-1 16 Sep 2024

HD/DG update to TD/DD.

HD-DEN-17053-1 13 Sep 2024

Remove extra blank line.

LEAHI-SW-LDT-261-2 30 May 2025

RESOLVED

LEAHI-SW-LDT-261-2 03 Jun 2025

Completed DD Version response model, please review

LEAHI-APPLICATION-LDT-1516-1 29 Jul 2025

RESOLVED

DD-LEAH-220-2 17 Sep 2024

Done.

DD-LEAH-220-2 16 Sep 2024

I don't see Dialin override functions for read and error counter.

DD-LEAH-227-1 30 Sep 2024

Looks like it's returning converted pressure (and that it will eventually return converted & calibrated pressure).

TD-LDT-736-1 29 Jul 2025

Fixed.

BOOTLOADER-LEAH-1415-1 01 Oct 2024

Remove test code.

RO-LDT-566-2 30 Jul 2025

fixed. thanks!

BOOTLOADER-LEAH-1415-1 01 Oct 2024

If we are in the check image process, that means we are wanting to jump to the app (assuming check is successful). If we get an update command from UI during the check, I think that should take precedence - abort the check and service the update request.

DD-LEAH-227-1 01 Oct 2024

Will be done once your changes available in staging.

RO-LDT-566-2 30 Jul 2025

removed.

DD-LEAH-227-1 01 Oct 2024

Done.

DD-LEAH-227-1 30 Sep 2024

This looks like a copy/paste error. I don't think we're setting step speed in this function.

DD-LEAH-227-1 30 Sep 2024

Alarm appears to be on a CRC mismatch or a timeout, not a CRC change.

RO-LDT-566-2 30 Jul 2025

this was used to help read the stop property for alarms. It has been removed.

DG-DEN-15274-1 14 May 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-15196-2 15 May 2023

Fixed. Thanks!

DD-LEAH-227-1 30 Sep 2024

Change comment to "Monitor temperatures".

HD-DEN-15196-2 15 May 2023

Fixed. Thanks!

HD-DEN-15196-2 15 May 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15196-2 15 May 2023

RESOLVED in CODE WALKTHROUGH.

DG-DENBUG-318-1 27 May 2025

Removed. UI is updated too.

BOOTLOADER-LEAH-1415-1 01 Oct 2024

I think it's better (and maybe coding standard) to assign the state (from get function) to a local variable and use that variable in the switch.

LEAHI-DIALIN-LDT-261-1 28 May 2025

That is sufficient. Thanks.
RESOLVED

HD-DEN-15229-1 15 May 2023

Done. Reset door flag also.

LEAHI-TD-FIRMWARE-LDT-3126-1 02 Mar 2026

You moved it, but didn't change anything. The comment says it's a timer counter but the variable name suggests it is actually a flow rate. I want you to fix the comment.

DD-LEAH-210-5 29 Aug 2024

Will be addressed once Concentrate pump driver is included. this function carries the parameter (#define) related to concentrate pump.

HD-DEN-15229-1 15 May 2023

Removed

LEAHI-DIALIN-LDT-261-1 28 May 2025

Thanks
RESOLVED

DD-LEAH-210-5 29 Aug 2024

Done.

HD-DEN-15229-1 15 May 2023

RESOLVED in CODE WALKTHROUGH.

DD-LEAH-210-5 29 Aug 2024

Done.

LEAHI-TESTSUITES-LDT-2741-1 03 Mar 2026

removed data_1.tsv file from branch

DD-LEAH-210-5 29 Aug 2024

Done. Once Concentrate pump driver added, deenergize function will be enabled