•  

Comment Results

Review Name Created Custom Fields Content
DD-LEAH-210-5 30 Aug 2024

Done.

DD-LEAH-210-5 30 Aug 2024

Done.

HD-DEN-15274-1 17 May 2023

Add patientConnectionConfirm and doorOpened to header.

DD-LDT-1473-1 28 Jul 2025

Done.

DD-LEAH-210-5 30 Aug 2024

Done.

TD-LDT-802-1 28 Jul 2025

Should be TRUE since BP is running.

DD-LEAH-210-5 30 Aug 2024

Done.

DD-LEAH-210-5 30 Aug 2024

Done.

LEAHI-APPLICATION-LDT-1516-1 29 Jul 2025

RESOLVED

DD-LEAH-210-5 03 Sep 2024

Done.

LEAHI-APPLICATION-LDT-1516-1 29 Jul 2025

Remove this Windows hidden file.

DD-LEAH-210-5 03 Sep 2024

Done.

TD-LEAH-32-4 04 Sep 2024

This function is used to calculate the baro sensor's CRC.

LEAHI-APPLICATION-LDT-1516-1 29 Jul 2025

yes i agree makes more sense that way of whats going on.. I moved this to where they are being instantiated

TD-LEAH-32-4 04 Sep 2024

Noe didn't include it.

DD-LEAH-210-5 29 Aug 2024

Alphabetize the app includes group.

DD-LEAH-210-5 29 Aug 2024

Move this up to function header as a "@warning".

DD-LEAH-210-5 30 Aug 2024

No solo standby mode.

TD-LEAH-32-4 04 Sep 2024

I can update the numbers.

RO-LDT-566-2 30 Jul 2025

functions have been removed as we no longer need it. ( Controlling to flow )

RO-LDT-566-2 30 Jul 2025

fixed. thanks!

BOOTLOADER-LEAH-1415-1 30 Sep 2024

Correct. I moved them.

BOOTLOADER-LEAH-1415-1 01 Oct 2024

Remove test code.

DD-LEAH-227-1 01 Oct 2024

Done.

DD-LEAH-227-1 01 Oct 2024

Done.

RO-LDT-566-2 30 Jul 2025

They are in the source file. These definitions have also been moved to the source file as well.

RO-LDT-566-2 24 Jul 2025

Not an output.

LEAHI-APPLICATION-LDT-1788-1 01 Aug 2025

the way this and "Settings_Category_InstructionsImagesLoc" is being used as an arguement for Settings_Path_Name which already has the "/". For ex.. "/home/denali/Public/luis/application/config/configurations/"

LEAHI-APPLICATION-LDT-1788-1 01 Aug 2025

moved here

RO-LDT-566-2 01 Aug 2025

Update inputs/outputs

LEAHI-APPLICATION-LDT-1788-1 01 Aug 2025

Declare as 'const QString'.

LEAHI-APPLICATION-LDT-1788-1 01 Aug 2025

Misspelling (lsitVisible)?

LEAHI-APPLICATION-LDT-1788-1 01 Aug 2025

Does this need to be a Flickable if there are only going to be 10 items max in it? If the Flickable is not needed, can this item be eliminated and just have the contained TouchGrid take its place?

LEAHI-TD-FIRMWARE-LDT-3126-1 26 Feb 2026

I would expect there to be a change to Messaging.c (to add association between msg ID to this new function to the look-up table), but I don't see it.

HD-DEN-15196-2 14 May 2023

Post treatment starts in drain reservoirs submode which does have a substate. Once we leave drain reservoirs submode, then we should call this function with no substate for remainder of post treatment submodes.

HD-DEN-15196-2 15 May 2023

RESOLVED in CODE WALKTHROUGH.

BOOTLOADER-LEAH-1415-1 01 Oct 2024

Do this TODO.

DD-LEAH-210-5 29 Aug 2024

Done.

DD-LEAH-210-5 29 Aug 2024

Done.

HD-DEN-15229-1 14 May 2023

By this point, we've already accepted the confirm from user so we need to move on to next state even if door is open - not sure this could even happen if we require door closed for entirety of this state.

HD-DEN-15229-1 15 May 2023

Reset proper flag.

HD-DEN-15196-2 15 May 2023

Should the argument for setCurrentSubState be a CONSUMABLE_SELF_TEST_STATE_T? Other calls don't cast to U32.

DD-LEAH-210-5 30 Aug 2024

Done.

DG-DEN-15274-1 16 May 2023

Don't forget to roll compatibility for all 3 stacks.

LEAHI-DIALIN-LDT-261-1 27 May 2025

Please remove all the default values for the function parameters to check for all the sent arguments, and ensure that when this function is called, no parameter is left as default, and all are set.
Please check all the other functions as well.

DD-LEAH-210-5 30 Aug 2024

Done.

TD-LEAH-32-4 03 Sep 2024

Fixed.

TD-LEAH-32-4 03 Sep 2024

This function was for the 4 pinch valves in HD so I don't think a VBT control is right for this.
I figured we could sort this out when we work on the valves controller/monitor unit.

DD-LEAH-210-5 29 Aug 2024

There will be no drain pump, right?

DD-LEAH-210-5 29 Aug 2024

Remove blank line.